From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755586AbcLZLRX (ORCPT ); Mon, 26 Dec 2016 06:17:23 -0500 Received: from gloria.sntech.de ([95.129.55.99]:57916 "EHLO gloria.sntech.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754261AbcLZLRV (ORCPT ); Mon, 26 Dec 2016 06:17:21 -0500 From: Heiko Stuebner To: Elaine Zhang Cc: mturquette@baylibre.com, sboyd@codeaurora.org, xf@rock-chips.com, robh+dt@kernel.org, mark.rutland@arm.com, linux-clk@vger.kernel.org, huangtao@rock-chips.com, xxx@rock-chips.com, cl@rock-chips.com, linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH v3 4/4] clk: rockchip: add new pll-type for rk3328 Date: Mon, 26 Dec 2016 12:17:06 +0100 Message-ID: <30891453.yaZWColTmb@phil> User-Agent: KMail/5.2.3 (Linux/4.8.0-1-amd64; KDE/5.27.0; x86_64; ; ) In-Reply-To: <1482723930-5876-5-git-send-email-zhangqing@rock-chips.com> References: <1482723930-5876-1-git-send-email-zhangqing@rock-chips.com> <1482723930-5876-5-git-send-email-zhangqing@rock-chips.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Am Montag, 26. Dezember 2016, 11:45:30 CET schrieb Elaine Zhang: > The rk3328's pll and clock are similar with rk3036's, > it different with pll_mode_mask, the rk3328 soc > pll mode only one bit(rk3036 soc have two bits) > so these should be independent and separate from > the series of rk3328s. > > Changes in v3: > fix up the pll type pll_rk3328 description and use > > Signed-off-by: Elaine Zhang > --- pll-specific code looks good now, but please make this patch before the clock controller in the series and move the @@ -130,6 +152,7 @@ enum rockchip_pll_type { pll_rk3036, pll_rk3066, + pll_rk3328, pll_rk3399, }; from patch3 into this one. Thanks Heiko PS: I will have some comments for the clock controller patch, but it's xmas, so that may take bit still.