From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752698AbdEVHdr (ORCPT ); Mon, 22 May 2017 03:33:47 -0400 Received: from mout.web.de ([212.227.15.4]:49755 "EHLO mout.web.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752077AbdEVHdp (ORCPT ); Mon, 22 May 2017 03:33:45 -0400 To: netdev@vger.kernel.org, "David S. Miller" , Herbert Xu , Steffen Klassert Cc: LKML , kernel-janitors@vger.kernel.org From: SF Markus Elfring Subject: [PATCH] flowcache: Delete an error message for a failed memory allocation in flow_cache_cpu_prepare() Message-ID: <308bd3f5-d4f8-068b-7110-f9499ea7624e@users.sourceforge.net> Date: Mon, 22 May 2017 09:33:07 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.1.1 MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Language: en-GB Content-Transfer-Encoding: 7bit X-Provags-ID: V03:K0:Aqhgkit5wZiV/UkpXteOzdX7RemduIFuj3dluIjqpQcPTyhAM9A EwyZtOd/AS8dfKvP0KPcJS4V48Ds45ojhIIGVVSLy7utdpBiflEJFqGrVgginz6WOsGCTpG Tm/52ONwVfRTFYH8Qw39bleasSoxeTAaL2zaQlG1ad4QXtRG0w+GOpQkOs2sFotWRiwFGMQ Llq2257GsWyKGorgO/d4w== X-UI-Out-Filterresults: notjunk:1;V01:K0:GHcpUgbzQBA=:hgy2Gr0uQJB23tZM4r1LLk ZpJau7kmCBQIYgNkt70TLBgSYICgfSaeJgsURQ9bBoOTeVipav/4gAZyJNfs6ttxw46rUyqv7 VLnrY8qd3PyDaNvFp+azdHVSUWAahhscyA6cDGLbW5a1JtFKdRpPLmUHxIPBj6304PPrIl7tG Fp7XjyZij2jQiZba9m/YW1awWq2fHI9L8Comv8xGC9UEc7VpFXW6zld0dnQSwM79IZak4hAPS EQ/my5bn9wSZKI9aheR8DOHqZD/Yj4zFPVn/iZua81fwbSmj70xMXQJejxrXFDIKpgISIcKG9 0ZeZkF7WLz6nwYpfBN1RzATJS+c9d4aaYhu/VoIp6+Vdb3vnxatUX3At7flpPPeg0Kvp82ynq z1iVLUo7wbJFfnHVBnBC2g8NwTDy8/4ycIhTBq+IAYRw3CqSCiZCdBm9s4vz32smyK+UUgKC6 09AKj0jwSVfYFxMwsXWRnJFvfLM+CLJcK5xF/qC1lZM3C5Q6n8A8zwr1wzuaMDWEgP8mZX8V2 cY+YfvUgrBG8YKGebkmynIP+k95IEdNkraUJawDGjw0yB2PI074PdG2nY0DJh0mBgiFwIZ/aU vqi88oSanmqid4CdMnOyfBmAHnZSXtPJULGBlH3IZNR7AzLuwrzFKQNwQPVtduxVKsrdmEBsy EczrM3aDHboCPzULHkFhOFr0huPRj42a959zS2o+1V8jX9SkpT21/q4EFqqNZtqN1IqOQTy6I mH3Mk/NZagJdv9qhwZLz+6OZNO1rXVcrRA/tMUsoE/LdyTrcEQe6AI4MYjJkMSCeOiIEhzYTd c9yJyVB Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Markus Elfring Date: Mon, 22 May 2017 09:19:51 +0200 Omit an extra message for a memory allocation failure in this function. This issue was detected by using the Coccinelle software. Link: http://events.linuxfoundation.org/sites/events/files/slides/LCJ16-Refactor_Strings-WSang_0.pdf Signed-off-by: Markus Elfring --- net/core/flow.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/net/core/flow.c b/net/core/flow.c index f7f5d1932a27..08c851236b97 100644 --- a/net/core/flow.c +++ b/net/core/flow.c @@ -412,7 +412,6 @@ static int flow_cache_cpu_prepare(struct flow_cache *fc, int cpu) - if (!fcp->hash_table) { - pr_err("NET: failed to allocate flow cache sz %u\n", sz); + if (!fcp->hash_table) return -ENOMEM; - } + fcp->hash_rnd_recalc = 1; fcp->hash_count = 0; tasklet_init(&fcp->flush_tasklet, flow_cache_flush_tasklet, 0); -- 2.13.0