From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752504AbaJPKqU (ORCPT ); Thu, 16 Oct 2014 06:46:20 -0400 Received: from galahad.ideasonboard.com ([185.26.127.97]:36832 "EHLO galahad.ideasonboard.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751609AbaJPKqS (ORCPT ); Thu, 16 Oct 2014 06:46:18 -0400 From: Laurent Pinchart To: Maxime Ripard Cc: dmaengine@vger.kernel.org, Vinod Koul , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Antoine =?ISO-8859-1?Q?T=E9nart?= , lars@metafoo.de, Russell King , Dan Williams Subject: Re: [PATCH v2 05/53] dmaengine: Add device_terminate_all callback Date: Thu, 16 Oct 2014 13:46:29 +0300 Message-ID: <3094993.Wejb51jFmk@avalon> User-Agent: KMail/4.12.5 (Linux/3.14.14-gentoo; KDE/4.12.5; x86_64; ; ) In-Reply-To: <1413454672-27400-6-git-send-email-maxime.ripard@free-electrons.com> References: <1413454672-27400-1-git-send-email-maxime.ripard@free-electrons.com> <1413454672-27400-6-git-send-email-maxime.ripard@free-electrons.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Maxime, Thank you for the patch. On Thursday 16 October 2014 12:17:04 Maxime Ripard wrote: > Split out the terminate_all command from device_control to a dma_device > callback. In order to preserve backward capability, still rely on > device_control if no such callback has been implemented. > > Eventually, this will allow to create a generic dma_slave_caps callback. I like eventually better than hopefully ;-) > Signed-off-by: Maxime Ripard Acked-by: Laurent Pinchart > --- > include/linux/dmaengine.h | 6 ++++++ > 1 file changed, 6 insertions(+) > > diff --git a/include/linux/dmaengine.h b/include/linux/dmaengine.h > index b89c8004fcd8..4d0294ec3567 100644 > --- a/include/linux/dmaengine.h > +++ b/include/linux/dmaengine.h > @@ -616,6 +616,8 @@ struct dma_tx_state { > * 0 or an error code > * @device_resume: Resumes any transfer on a channel previously > * paused. Returns 0 or an error code > + * @device_terminate_all: Aborts all transfers on a channel. Returns 0 > + * or an error code > * @device_tx_status: poll for transaction completion, the optional > * txstate parameter can be supplied with a pointer to get a > * struct with auxiliary transfer status information, otherwise the call > @@ -686,6 +688,7 @@ struct dma_device { > unsigned long arg); > int (*device_pause)(struct dma_chan *chan); > int (*device_resume)(struct dma_chan *chan); > + int (*device_terminate_all)(struct dma_chan *chan); > enum dma_status (*device_tx_status)(struct dma_chan *chan, > dma_cookie_t cookie, > struct dma_tx_state *txstate); > @@ -784,6 +787,9 @@ static inline int dma_get_slave_caps(struct dma_chan > *chan, struct dma_slave_cap > > static inline int dmaengine_terminate_all(struct dma_chan *chan) > { > + if (chan->device->device_terminate_all) > + return chan->device->device_terminate_all(chan); > + > return dmaengine_device_control(chan, DMA_TERMINATE_ALL, 0); > } -- Regards, Laurent Pinchart