From: Stephan Mueller <smueller@chronox.de>
To: Herbert Xu <herbert@gondor.apana.org.au>, steffen.klassert@secunet.com
Cc: LKML <linux-kernel@vger.kernel.org>
Subject: crypto: user - crypto_alg_match removal
Date: Sat, 22 Nov 2014 23:25:05 +0100 [thread overview]
Message-ID: <3095384.PkgHxCg8eG@tauon> (raw)
Hi Steffen, Herbert,
may I ask for the reasons why crypto_alg_match exists? Doesn't it
implement crypto_alg_lookup -- and that not even complete? Is there a
particular reason why this exact flag of crypto_alg_match is really
needed in the context of crypto_user?
Unless there is such valid reason, may I ask whether we can remove
crypto_alg_match and simply use crypto_alg_lookup in all instances where
crypto_alg_match is invoked using the following replacement:
alg = crypto_alg_lookup(p->cru_name, p->cru_type, p->cru_mask)
The only problem with this replacement is that p->cru_driver_name is not
considered with that. Do you think a double invocation of
crypto_alg_lookup should be done or that even the user space interface
should be changed such that cru_driver_name is removed from it?
Note, this change would now imply that crypto_user follows the kernel-
internal crypto API invocation approach.
Thanks
Stephan
next reply other threads:[~2014-11-22 22:25 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-11-22 22:25 Stephan Mueller [this message]
2014-11-24 7:22 ` crypto: user - crypto_alg_match removal Steffen Klassert
2014-11-24 12:29 ` Stephan Mueller
2014-11-25 8:42 ` Steffen Klassert
2014-11-25 9:00 ` Stephan Mueller
2014-11-25 9:06 ` Herbert Xu
2014-11-25 9:24 ` Steffen Klassert
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3095384.PkgHxCg8eG@tauon \
--to=smueller@chronox.de \
--cc=herbert@gondor.apana.org.au \
--cc=linux-kernel@vger.kernel.org \
--cc=steffen.klassert@secunet.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox