From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1946289AbbEOVZV (ORCPT ); Fri, 15 May 2015 17:25:21 -0400 Received: from mout.kundenserver.de ([212.227.17.13]:54458 "EHLO mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1946011AbbEOVZM convert rfc822-to-8bit (ORCPT ); Fri, 15 May 2015 17:25:12 -0400 From: Arnd Bergmann To: Pali =?ISO-8859-1?Q?Roh=E1r?= Cc: =?ISO-8859-1?Q?Beno=EEt?= Cousson , Tony Lindgren , Ulf Hansson , linux-omap@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mmc@vger.kernel.org Subject: Re: [PATCH 1/2] mmc: omap_hsmmc: Add support for slot-name property in DT Date: Fri, 15 May 2015 23:25:05 +0200 Message-ID: <3099867.Z5GbY7oWl2@wuerfel> User-Agent: KMail/4.11.5 (Linux/3.16.0-10-generic; KDE/4.11.5; x86_64; ; ) In-Reply-To: <201505152322.37739@pali> References: <1431724489-32359-1-git-send-email-pali.rohar@gmail.com> <2523437.y90mKuWhc3@wuerfel> <201505152322.37739@pali> MIME-Version: 1.0 Content-Transfer-Encoding: 8BIT Content-Type: text/plain; charset="iso-8859-1" X-Provags-ID: V03:K0:MVKuEtI5w3jk3teEW6ula2eGkchl7ZWnbcP/+5sLjAAeiToSUiD qbk0KfyCR2lLXBWMVpRlqeBh4/avx0+d4BLl9hCth70yJqyG0/EgWUnMW+RG+W97zMnAIN9 3VftPbQIcEFVhUU1MEiKfKTsd9TGbbMnDtW0u/m20RQuQCBss/X5hQ7Iw9P0kxOtEaiXmM5 Pfx6QXrZH+wOjLN+7rziQ== X-UI-Out-Filterresults: notjunk:1; Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Friday 15 May 2015 23:22:37 Pali Rohár wrote: > On Friday 15 May 2015 23:19:44 Arnd Bergmann wrote: > > On Friday 15 May 2015 23:14:48 Pali Rohár wrote: > > > diff --git a/drivers/mmc/host/omap_hsmmc.c > > > b/drivers/mmc/host/omap_hsmmc.c index 9df2b68..f6073dd 100644 > > > --- a/drivers/mmc/host/omap_hsmmc.c > > > +++ b/drivers/mmc/host/omap_hsmmc.c > > > @@ -1901,6 +1901,8 @@ static struct omap_hsmmc_platform_data > > > *of_get_hsmmc_pdata(struct device *dev) > > > > > > if (of_find_property(np, "ti,needs-special-hs-handling", > > > NULL)) > > > > > > pdata->features |= HSMMC_HAS_HSPE_SUPPORT; > > > > > > + of_property_read_string(np, "slot-name", &pdata->name); > > > + > > > > > > return pdata; > > > > > > } > > > > This property needs to be documented in > > Documentation/devicetree/bindings/mmc/mmc.txt and preferably the > > implementation moved into mmc_of_parse. > > > > We should not have an interface like this specific to one driver. > > > > Arnd > > Interface is already present for platform data code (which do not use > DT). So "pdata->name" is not DT specific... > The driver can of course keep providing the name from platform_data where that is used. All I was saying is that when you introduce a DT property, it should not be specific to that driver. Arnd