From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id A2671C636D3 for ; Mon, 6 Feb 2023 15:50:48 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230166AbjBFPur (ORCPT ); Mon, 6 Feb 2023 10:50:47 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:59284 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229943AbjBFPup (ORCPT ); Mon, 6 Feb 2023 10:50:45 -0500 Received: from mga12.intel.com (mga12.intel.com [192.55.52.136]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id CD9C0FE for ; Mon, 6 Feb 2023 07:50:44 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1675698644; x=1707234644; h=message-id:date:mime-version:subject:to:cc:references: from:in-reply-to:content-transfer-encoding; bh=Z2z46pZ+plYwvmFUk/wU0Ooz61UTdjoZtZP9H7Gsu7I=; b=hvRpWNhPIN0xtFfFsNyVKQxOfGJ5usM4pdrTyrxRwiMQAcyklIu/BdAN vEdB+ZAwpJUnSwuGSqPfIM60zuEUvPZynL6xAjy+ChPsT6QnIpXp55S2s f+830iPcxFvqFkGnbYBxfbNl6vE3tgbY2CY4bXyS7HV15XE9v+Kf5dV2F YdBikP3MXRcXQsShN/DRzqt5v+c7hNG0Jvj2UDTNNtgZ+tWDw/LbkDa4p VSKct529AWYOcS0gYKZ6or5KayeD21VPNLHMevsabWHEEfyFzY3+FFiwq NsK6hQNPIJ+5StXyerewbdWRcQ2GRDRSu161UHPSDdgoCTAVO13gUbxT6 g==; X-IronPort-AV: E=McAfee;i="6500,9779,10613"; a="308879635" X-IronPort-AV: E=Sophos;i="5.97,276,1669104000"; d="scan'208";a="308879635" Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by fmsmga106.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 06 Feb 2023 07:49:37 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6500,9779,10613"; a="809179353" X-IronPort-AV: E=Sophos;i="5.97,276,1669104000"; d="scan'208";a="809179353" Received: from linux.intel.com ([10.54.29.200]) by fmsmga001.fm.intel.com with ESMTP; 06 Feb 2023 07:49:35 -0800 Received: from [10.212.205.76] (kliang2-mobl1.ccr.corp.intel.com [10.212.205.76]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by linux.intel.com (Postfix) with ESMTPS id 1FE4F58068A; Mon, 6 Feb 2023 07:49:14 -0800 (PST) Message-ID: <30bc05e4-a479-ad53-22b1-4afca4fa7ec2@linux.intel.com> Date: Mon, 6 Feb 2023 10:49:02 -0500 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.6.1 Subject: Re: [PATCH V3 3/3] perf test: Support the retire_lat check Content-Language: en-US To: Arnaldo Carvalho de Melo Cc: peterz@infradead.org, mingo@redhat.com, linux-kernel@vger.kernel.org, ak@linux.intel.com, eranian@google.com, irogers@google.com References: <20230202192209.1795329-1-kan.liang@linux.intel.com> <20230202192209.1795329-3-kan.liang@linux.intel.com> <8e493d2f-827a-03d9-610b-6246502bf92a@linux.intel.com> From: "Liang, Kan" In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2023-02-06 10:34 a.m., Arnaldo Carvalho de Melo wrote: > Em Mon, Feb 06, 2023 at 12:32:54PM -0300, Arnaldo Carvalho de Melo escreveu: >> Em Mon, Feb 06, 2023 at 10:17:46AM -0500, Liang, Kan escreveu: >>> >>> >>> On 2023-02-06 10:01 a.m., Arnaldo Carvalho de Melo wrote: >>>> Em Thu, Feb 02, 2023 at 11:22:09AM -0800, kan.liang@linux.intel.com escreveu: >>>>> From: Kan Liang >>>>> >>>>> Add test for the new field for Retire Latency in the X86 specific test. >>>> >>>> Is this passing 'perf test' for you? >>> >>> Ah, it should be the original V2 missed the below change. >> >> Can you please send this as a separate patch as I already merged >> torvalds/master and added more csets on top, so to just fix it and >> force push now would be bad. >> >> Please use what is in my perf/core branch and add a Fixes for that v2 >> patch. > > BTW, the 3rd patch with the test is already on the tmp.perf/core branch, > that will move to perf/core after the next round of container build > tests. > Thanks. I will sent a V4 to fix the 'perf test' issue. Thanks, Kan > - Arnaldo > >> Thanks, >> >> - Arnaldo >> >>> @@ -100,5 +101,25 @@ void arch_perf_synthesize_sample_weight(const >>> struct perf_sample *data, >>> if (type & PERF_SAMPLE_WEIGHT_STRUCT) { >>> *array &= 0xffffffff; >>> *array |= ((u64)data->ins_lat << 32); >>> + *array |= ((u64)data->retire_lat << 48); >>> } >>> } >>> >>> Could you please remove the V2 and re-apply the V3? >> >>> $ sudo ./perf test -v "x86 sample parsing" >>> 74: x86 Sample parsing : >>> --- start --- >>> test child forked, pid 3316797 >>> test child finished with 0 >>> ---- end ---- >>> x86 Sample parsing: Ok >>> >>> >>> Thanks, >>> Kan >>> >>>> >>>> [root@quaco ~]# perf test -v "x86 sample parsing" >>>> 74: x86 Sample parsing : >>>> --- start --- >>>> test child forked, pid 72526 >>>> Samples differ at 'retire_lat' >>>> parsing failed for sample_type 0x1000000 >>>> test child finished with -1 >>>> ---- end ---- >>>> x86 Sample parsing: FAILED! >>>> [root@quaco ~]# >>>> >>>> - Arnaldo >>>> >>>>> Signed-off-by: Kan Liang >>>>> --- >>>>> >>>>> New patch since V2 >>>>> >>>>> tools/perf/arch/x86/tests/sample-parsing.c | 5 ++++- >>>>> 1 file changed, 4 insertions(+), 1 deletion(-) >>>>> >>>>> diff --git a/tools/perf/arch/x86/tests/sample-parsing.c b/tools/perf/arch/x86/tests/sample-parsing.c >>>>> index 690c7c07e90d..a061e8619267 100644 >>>>> --- a/tools/perf/arch/x86/tests/sample-parsing.c >>>>> +++ b/tools/perf/arch/x86/tests/sample-parsing.c >>>>> @@ -27,8 +27,10 @@ static bool samples_same(const struct perf_sample *s1, >>>>> const struct perf_sample *s2, >>>>> u64 type) >>>>> { >>>>> - if (type & PERF_SAMPLE_WEIGHT_STRUCT) >>>>> + if (type & PERF_SAMPLE_WEIGHT_STRUCT) { >>>>> COMP(ins_lat); >>>>> + COMP(retire_lat); >>>>> + } >>>>> >>>>> return true; >>>>> } >>>>> @@ -48,6 +50,7 @@ static int do_test(u64 sample_type) >>>>> struct perf_sample sample = { >>>>> .weight = 101, >>>>> .ins_lat = 102, >>>>> + .retire_lat = 103, >>>>> }; >>>>> struct perf_sample sample_out; >>>>> size_t i, sz, bufsz; >>>>> -- >>>>> 2.35.1 >>>>> >>>> >> >> -- >> >> - Arnaldo >