public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Jakub Slepecki <jakub.slepecki@intel.com>
To: "Loktionov, Aleksandr" <aleksandr.loktionov@intel.com>,
	"intel-wired-lan@lists.osuosl.org"
	<intel-wired-lan@lists.osuosl.org>
Cc: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
	"Kitszel, Przemyslaw" <przemyslaw.kitszel@intel.com>,
	"Nguyen, Anthony L" <anthony.l.nguyen@intel.com>,
	"michal.swiatkowski@linux.intel.com"
	<michal.swiatkowski@linux.intel.com>
Subject: Re: [PATCH iwl-next v2 5/8] ice: update mac,vlan rules when toggling between VEB and VEPA
Date: Fri, 28 Nov 2025 09:29:08 +0100	[thread overview]
Message-ID: <30c166ee-c113-434d-acca-15bc7c46722f@intel.com> (raw)
In-Reply-To: <IA3PR11MB89867D7081F88828EAC0E107E5D1A@IA3PR11MB8986.namprd11.prod.outlook.com>

On 2025-11-25 9:52, Loktionov, Aleksandr wrote:
> Better to provide exact bash commands.

All right, I'll review the commands in the 0/8 and see if I can expand
them for this context.  I'll refer it here.  I suppose I could add the
bridge(8) example for hwmode?  Something like:

     Testing hints:
         MAC,VLAN rules are created only if entire series is applied.
         The easiest way to test that rules were adjusted is to run traffic
         and observe what packets are sent to LAN.  VEPA is expected to behave
         same as before the series.  VEB is expected to (a) behave like VEPA
         if loopback traffic would cross VLANs, or (b) behave as before.
         Traffic from/to external hosts is expected to remain unchanged.

         Refer to 0/8 for full network configuration.  To change hwmode use:

         bridge link set dev $pf hwmode {veb,vepa}

> Reviewed-by: Aleksandr Loktionov <aleksandr.loktionov@intel.com>

I'll drop it since you did not explicitly say it's fine to keep it.

Thanks!

  reply	other threads:[~2025-11-28  8:29 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-11-25  8:34 [PATCH iwl-next v2 0/8] ice: in VEB, prevent "cross-vlan" traffic Jakub Slepecki
2025-11-25  8:34 ` [PATCH iwl-next v2 1/8] ice: in dvm, use outer VLAN in MAC,VLAN lookup Jakub Slepecki
2025-11-25  8:34 ` [PATCH iwl-next v2 2/8] ice: allow creating mac,vlan filters along mac filters Jakub Slepecki
2025-11-25  8:34 ` [PATCH iwl-next v2 3/8] ice: do not check for zero mac when creating " Jakub Slepecki
2025-11-25  8:34 ` [PATCH iwl-next v2 4/8] ice: allow overriding lan_en, lb_en in switch Jakub Slepecki
2025-11-25  8:59   ` Loktionov, Aleksandr
2025-11-28 11:55     ` Jakub Slepecki
2025-12-01  7:37       ` Loktionov, Aleksandr
2025-12-02 13:54         ` Jakub Slepecki
2025-11-25  8:34 ` [PATCH iwl-next v2 5/8] ice: update mac,vlan rules when toggling between VEB and VEPA Jakub Slepecki
2025-11-25  8:52   ` Loktionov, Aleksandr
2025-11-28  8:29     ` Jakub Slepecki [this message]
2025-11-28  8:36       ` Loktionov, Aleksandr
2025-11-28 12:28         ` Jakub Slepecki
2025-12-01  7:41           ` Loktionov, Aleksandr
2025-11-25  8:34 ` [PATCH iwl-next v2 6/8] ice: add functions to query for vsi's pvids Jakub Slepecki
2025-11-25  8:34 ` [PATCH iwl-next v2 7/8] ice: add mac vlan to filter API Jakub Slepecki
2025-11-25  8:34 ` [PATCH iwl-next v2 8/8] ice: in VEB, prevent "cross-vlan" traffic from hitting loopback Jakub Slepecki

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=30c166ee-c113-434d-acca-15bc7c46722f@intel.com \
    --to=jakub.slepecki@intel.com \
    --cc=aleksandr.loktionov@intel.com \
    --cc=anthony.l.nguyen@intel.com \
    --cc=intel-wired-lan@lists.osuosl.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=michal.swiatkowski@linux.intel.com \
    --cc=netdev@vger.kernel.org \
    --cc=przemyslaw.kitszel@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox