From: Lu Baolu <baolu.lu@linux.intel.com>
To: Joerg Roedel <joro@8bytes.org>,
Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Cc: baolu.lu@linux.intel.com, Joerg Roedel <jroedel@suse.de>,
iommu@lists.linux-foundation.org, linux-kernel@vger.kernel.org,
David Woodhouse <dwmw2@infradead.org>,
Will Deacon <will@kernel.org>
Subject: Re: [PATCH v2 1/1] iommu/vt-d: Move intel_iommu_ops to header file
Date: Tue, 15 Feb 2022 09:31:37 +0800 [thread overview]
Message-ID: <30e45a7e-088d-7479-a284-68effadf3cbe@linux.intel.com> (raw)
In-Reply-To: <YgpY1IIBkFIxxjbm@8bytes.org>
On 2/14/22 9:27 PM, Joerg Roedel wrote:
> On Mon, Feb 07, 2022 at 04:12:40PM +0200, Andy Shevchenko wrote:
>> diff --git a/include/linux/intel-iommu.h b/include/linux/intel-iommu.h
>> index 69230fd695ea..1036c1900b5c 100644
>> --- a/include/linux/intel-iommu.h
>> +++ b/include/linux/intel-iommu.h
>> @@ -813,6 +813,8 @@ bool context_present(struct context_entry *context);
>> struct context_entry *iommu_context_addr(struct intel_iommu *iommu, u8 bus,
>> u8 devfn, int alloc);
>>
>> +extern const struct iommu_ops intel_iommu_ops;
>> +
> The intel_iommu_ops symbol is only used in drivers/iommu/intel, so I
> would prefer a header in that directory. But I leave that up to Baolu to
> decide.
Agreed. I also have a plan to split them out into a internal header.
Best regards,
baolu
next prev parent reply other threads:[~2022-02-15 1:33 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-02-07 14:12 [PATCH v2 1/1] iommu/vt-d: Move intel_iommu_ops to header file Andy Shevchenko
2022-02-09 11:56 ` Andy Shevchenko
2022-02-14 13:27 ` Joerg Roedel
2022-02-15 1:31 ` Lu Baolu [this message]
2022-02-15 9:51 ` Andy Shevchenko
2022-02-16 7:03 ` Lu Baolu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=30e45a7e-088d-7479-a284-68effadf3cbe@linux.intel.com \
--to=baolu.lu@linux.intel.com \
--cc=andriy.shevchenko@linux.intel.com \
--cc=dwmw2@infradead.org \
--cc=iommu@lists.linux-foundation.org \
--cc=joro@8bytes.org \
--cc=jroedel@suse.de \
--cc=linux-kernel@vger.kernel.org \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox