From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8B4CD317715 for ; Tue, 30 Dec 2025 14:51:09 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1767106273; cv=none; b=t/FzXEiYExvCZxnmgpjpYaVLWblLSmWHsn2qgimeYc4RC9nfDDxEKcujeIlX7BVmfvz7O+Nh5WDRxjZZEj1y9zmG5shtu3FY4AMXS2Xqc3HYRHgSBaaq5htxhFH59XA8rBju/KjrPk1ehiRpvOFnN470bxIw/2j3pYMCsnd3aCE= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1767106273; c=relaxed/simple; bh=IiF1c3u4rp9iHh+96BFtbjILDmqjiKEfbIHKMbPt+Hg=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=F8Rcz65a6VN29SPlxRqqeDtzrMaqiWmkqxyKkvXkAR+WdKzB4HAR6zih6zpqOUTrXYsYnJsvKgHufbL55rSxew32kTCT3TdZ3HszFkLNN67SZ9LAwNXVPW0bP0jEjgEa69DcJ9h1m/C+Bu7LwXyAIMzbJiUB9e/78V2HjYyxcbQ= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=l5CYbXUH; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=R+rBhx3U; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="l5CYbXUH"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="R+rBhx3U" Received: from pps.filterd (m0279868.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 5BUBDb612670845 for ; Tue, 30 Dec 2025 14:51:08 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= gsMeU+DNb3dWUzggZmnZIryb8fe97Lkah5M+iOlelsY=; b=l5CYbXUHjmhQzIzT 1uixQu10HsCo18ML01r8G5BtnHC7VlY/xRrwzu1INGH1VhZQrDX4RYWg75An1VIX dGtBQLS7WJov31HH8Xeou2q/xav5grZaB/bIN62rylMTcgAdiOl7e3wOEREyQUi5 P6d3alIk1arp8S8qRV6HRKUAva5QixgnRjvPelwzBf2h2rcOUpGZPuMYI6pynhke nawrDaxKOroJcr0ASloAGX9nt94nb2xywMlC0/hsjjnY1o8O92ekot9VNDf9fet8 boi4pH2aYX+JfxOihGQTPgNtEXAxecf3UAKhSR/0yZinMzjsXyE8kTqoKlalYDHe K0kIlQ== Received: from mail-qv1-f71.google.com (mail-qv1-f71.google.com [209.85.219.71]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4bc4fcss0p-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Tue, 30 Dec 2025 14:51:08 +0000 (GMT) Received: by mail-qv1-f71.google.com with SMTP id 6a1803df08f44-8887c61412bso34609446d6.1 for ; Tue, 30 Dec 2025 06:51:08 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1767106267; x=1767711067; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=gsMeU+DNb3dWUzggZmnZIryb8fe97Lkah5M+iOlelsY=; b=R+rBhx3UjYU0DutPoyc3ZNQFLQPSqr/QKAkY/6HXRJ2CqlPDBetutb/okdH4il4ZZR ycCJBgMeWQq1ILce3RYxM+h647LE8/HlhEUNLAAPi+5kXHfLTjvOh2fE/I+wIhdxXJyD IDoa3HSeOVHbeMsfYmuxVCXtoU14VO0e5qzHYmWlopQYqen6vF7ECUATKA8JNvcpMIdG NE7xgUH88mLFDX5EWCByRB91i/SFJmx8KzQZRIwufrqDXkizzPOlIW9i8/7BdzrZeNCF qjZ1Osk8kscpnVd3FzDGQcSrIzuh3nXhHf9xBSe2yJXbdQ/beHJdyVjT/Beg1dHJBkoT 5GYg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1767106267; x=1767711067; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=gsMeU+DNb3dWUzggZmnZIryb8fe97Lkah5M+iOlelsY=; b=RW/n+R9wIwuO38zQ1smltqKwYDaLXmeuB0QnRhglqD7Mi2xD5yln7EtM5duxlCxJPM LJmu2Lbq0Qg/GFp3z7yRTZApmnLFQCkyoATj8xvbUYD/kFgKY+HWIAqyextLF5BU93UX mnTGsc/2kPb/06/0dFChKr7FC2yA/yE+baNwOMlaKXbucR54e4Oq9DcI7dwp5SSopZE6 lq4OwHjBwuPLQ6T7x0Np93QJ6hPOdEtFNTvepWbQhTPdctCvlBEVHekKrGeafkP7JD/l 4EvGpuSoz1OWJvObrFOLsREfcu+3d0XbP69M+PgVJlWnu9Th3Gb44eblF4sYDuujY6WO MOnw== X-Forwarded-Encrypted: i=1; AJvYcCX1kurjINGnHKXg5eI+UUfVvfD20d/ABmxa9eKeiORPM0cT8gOxcV7ZI9bB7B4eS8tgS6R2v0UVxuioYMw=@vger.kernel.org X-Gm-Message-State: AOJu0YwopGtEL7sVQ9Xs7vbpCAP/xMl3znSYzZfi/xjuJentJki+YMBi khs51AkauCF5uee7KmMmBpG/txFs71wQLOxV2FgvUirXUOe8Qa9VHcUl5KQti2BvKDaQKZJ1RN/ D41H46iuydX0tZwhp2CzpXzPuY4B9zpBPxFacKpfbOtU3pzc4hH5f5aNMzdUWyGNjWdk= X-Gm-Gg: AY/fxX5iWQvz5xbQsjwYJXTkH+d64V3sx+aRhij4TZQEHGjZLGjxozcvr7GOirqnLQg OCPi/IFolQRdyKcRSLgZvSc03+XBnOlFrE4gSipaYmfz3HAGun9XV6IK44nCx0Dp92FT07ghmMi OcdYnJkoLAEdD6orpiEDJ/Wuj5VjHpjeCEDJLM1Lz6Bl+AYKFaJU3jDsHPjeH7vUXI9xeL5AT+T Yr5axL1aUu1HLWtaWtUwO2wYDsAVgBHgRC3y5XSVrT9wsxh3EIvghEhQsYCQkhDcSo+7wOnqeKG 25BhgR6m0NCdip+DgT3T8icWKIVeKl3LWjtbOCCnXTb502MxiPMJIGs5ew2T0f17djM3Jfqihvm tXjdxvfZ4H8YB5NPRxHNvNJFWDJA3PMefXrtmW4sfzMvAfH56FyGbS/74YWp+YukE7Q== X-Received: by 2002:a05:622a:cc:b0:4ee:1db1:a61d with SMTP id d75a77b69052e-4f4abcf3ba4mr391083281cf.3.1767106267409; Tue, 30 Dec 2025 06:51:07 -0800 (PST) X-Google-Smtp-Source: AGHT+IF5OEshsq3tBs6p+dR5ZRcyitw9aC/nlfCN7CImHWgb6q7KFoia0dUeAt3oNkAbTOQF1VirAw== X-Received: by 2002:a05:622a:cc:b0:4ee:1db1:a61d with SMTP id d75a77b69052e-4f4abcf3ba4mr391083011cf.3.1767106266956; Tue, 30 Dec 2025 06:51:06 -0800 (PST) Received: from [192.168.119.72] (078088045245.garwolin.vectranet.pl. [78.88.45.245]) by smtp.gmail.com with ESMTPSA id 4fb4d7f45d1cf-64b9105655asm35092579a12.9.2025.12.30.06.51.05 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 30 Dec 2025 06:51:06 -0800 (PST) Message-ID: <30ee8541-3ec2-49ac-8fe0-987cdc5b16e7@oss.qualcomm.com> Date: Tue, 30 Dec 2025 15:51:04 +0100 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v10 5/5] arm64: dts: qcom: talos-evk: Add support for QCS615 talos evk board To: Sudarshan Shetty , andersson@kernel.org, konradybcio@kernel.org Cc: robh@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org, linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org References: <20251230130227.3503590-1-tessolveupstream@gmail.com> <20251230130227.3503590-6-tessolveupstream@gmail.com> Content-Language: en-US From: Konrad Dybcio In-Reply-To: <20251230130227.3503590-6-tessolveupstream@gmail.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Proofpoint-GUID: _fU4IMjIkKxRcJtzrCmDR6E7eEXPRuRg X-Proofpoint-ORIG-GUID: _fU4IMjIkKxRcJtzrCmDR6E7eEXPRuRg X-Proofpoint-Spam-Details-Enc: AW1haW4tMjUxMjMwMDEzNCBTYWx0ZWRfX7gLjPcVPpIUa eSuOmslCXvNakM6kshFYYPp0zU8I7kTBhgrS1kKMCmWz3DHKzB/lKaapGcXf4g3sCYlAAyQN65p NHKesUdNkfWgiYOK1ic1dzd911a0JBsZL0jaOVGqR6axSRjF84Qbx355hUEO2TYcsz6JNOHmNQY +MezK+Q8ZTnIStno22bK5AGiZEhtyUI5vyc7fm5qlbihyiiW+FYvMFRQdy0BWih0x9ZRSh7J2/w 56i2NIXVusTYBLeai0wfIFZq7Bs9+wQ+4odk1FHOlqjw2DrPks7t//K5+DbNX8wUzx4RU0pEqcz BTZlI/zSZLbbTmj9ZNpYX7N8fBvdfVM575brQtpPR1czSUxnyUlX+Mb8i/3oRdnk5LZC17TeViM kb17vUriFCoSGOGCueO3Iho6QtrUW3k8zjgO8VRd0/zAgujgx6HpT4JmsxVqJhdDGE0Gh8zaXbM LocDYznlLuBPOLY9SpQ== X-Authority-Analysis: v=2.4 cv=foHRpV4f c=1 sm=1 tr=0 ts=6953e6dc cx=c_pps a=UgVkIMxJMSkC9lv97toC5g==:117 a=FpWmc02/iXfjRdCD7H54yg==:17 a=IkcTkHD0fZMA:10 a=wP3pNCr1ah4A:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=OLXAHnxLARgaXDuhxGIA:9 a=QEXdDO2ut3YA:10 a=1HOtulTD9v-eNWfpl4qZ:22 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1121,Hydra:6.1.9,FMLib:17.12.100.49 definitions=2025-12-30_01,2025-12-30_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 malwarescore=0 phishscore=0 bulkscore=0 suspectscore=0 lowpriorityscore=0 clxscore=1015 adultscore=0 priorityscore=1501 impostorscore=0 spamscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2512120000 definitions=main-2512300134 On 12/30/25 2:02 PM, Sudarshan Shetty wrote: > Add the device tree for the QCS615-based Talos EVK platform. The > platform is composed of a System-on-Module following the SMARC > standard, and a Carrier Board. > > The Carrier Board supports several display configurations, HDMI and > LVDS. Both configurations use the same base hardware, with the display > selection controlled by a DIP switch. [...] > +++ b/arch/arm64/boot/dts/qcom/talos-evk-lvds-auo,g133han01.dtso > @@ -0,0 +1,126 @@ > +// SPDX-License-Identifier: BSD-3-Clause > +/* > + * Copyright (c) Qualcomm Technologies, Inc. and/or its subsidiaries. > + */ > +/dts-v1/; > +/plugin/; > + > +#include > + > +&{/} { > + backlight: backlight { > + compatible = "gpio-backlight"; > + gpios = <&tlmm 59 GPIO_ACTIVE_HIGH>, > + <&tlmm 115 GPIO_ACTIVE_HIGH>; > + default-on; > + }; > + > + hdmi_connector: hdmi-out { > + status = "disabled"; > + }; This should be a &label_reference [...] > + wifi_1p8v: regulator-wifi-1p8v { > + compatible = "regulator-fixed"; > + regulator-name = "wifi_1p8v"; > + regulator-min-microvolt = <1800000>; > + regulator-max-microvolt = <1800000>; > + gpio = <&tlmm 91 GPIO_ACTIVE_HIGH>; > + enable-active-high; > + pinctrl-names = "default"; > + pinctrl-0 = <&wifi_reg_en_pins_state>; property-n property-names consistently, please > + regulator-boot-on; > + regulator-always-on; > + }; > + > + wifi_3p85v: regulator-wifi-3p85v { > + compatible = "regulator-fixed"; > + regulator-name = "wifi_3p85v"; > + regulator-min-microvolt = <3850000>; > + regulator-max-microvolt = <3850000>; > + gpio = <&tlmm 91 GPIO_ACTIVE_HIGH>; > + enable-active-high; > + pinctrl-names = "default"; > + pinctrl-0 = <&wifi_reg_en_pins_state>; ditto [...] > +&tlmm { > + bt_en_state: bt-en-state { > + pins = "gpio85"; > + function = "gpio"; > + bias-pull-down; > + output-low; output-low/high should be unnecessary as these pins are governed by the kernel driver lg otherwise Konrad