From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 14C6547DD6C for ; Tue, 5 May 2026 13:43:00 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.129.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777988582; cv=none; b=A11bL8zS4SuAMfhU6yq6P9usc5VPu/YgvxmTExnaOcJ5E9C/OyDP6bB54OIqQ1hzoEc0rdCvHEk5JjFvCMi7AhqHLuU5ifO3/iD6+wG3fx9iEFwWXHGcbDYKRJh/00XPTnPVdPyjso3KPQeCIgEB9GD+E4xdC0vVrA42pkrksrs= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777988582; c=relaxed/simple; bh=KoGS6aWgQmyghW2+RcilZE/a4UalTY9FWST44iSCrmQ=; h=Message-ID:Date:MIME-Version:Subject:To:References:From: In-Reply-To:Content-Type; b=AW8Fe3KObYIeOJ1zPNckU4D61BQ1Llddb0GnbSnOKTebSyYerw2Pdde+xeBHLRL1s5bSVCRuaPrMFHVUnOPQBtpsAX3PR6lfjsoswKptIHhX+FMqHBJ6aLW3rBG9/lt/kdsPhqp6x6iLFtg8Z26B+NpHpBnZ03b9/TmBKaJKiwM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=hpaqQUEu; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b=XiYgCUaa; arc=none smtp.client-ip=170.10.129.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="hpaqQUEu"; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b="XiYgCUaa" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1777988580; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=+U+GpGXOrL0cMnQRbFcA7ylLjvJDYXi4Fcpm7XE5qos=; b=hpaqQUEux0Ns4KxPqGS0iHkQ0VAuaB77NjA25sSxkIxl8+y6XTBrl/hOlL8GRKiZ4YoLny ToEWQsPKNYat41j/W1bQ6fg+ULAiUkzCozFOkFeXkWm0g+hdHZspSl5fJBXp5apz14TIDO vJtuAQOmpkwptSSMgDCNejjpu1YKAp0= Received: from mail-wr1-f70.google.com (mail-wr1-f70.google.com [209.85.221.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-385-qwLbh5wUOg-tWcGvu73ZUw-1; Tue, 05 May 2026 09:42:55 -0400 X-MC-Unique: qwLbh5wUOg-tWcGvu73ZUw-1 X-Mimecast-MFC-AGG-ID: qwLbh5wUOg-tWcGvu73ZUw_1777988573 Received: by mail-wr1-f70.google.com with SMTP id ffacd0b85a97d-44696b11265so5620255f8f.0 for ; Tue, 05 May 2026 06:42:54 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=google; t=1777988573; x=1778593373; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:to:subject:user-agent:mime-version:date:message-id:from :to:cc:subject:date:message-id:reply-to; bh=+U+GpGXOrL0cMnQRbFcA7ylLjvJDYXi4Fcpm7XE5qos=; b=XiYgCUaamZm6WTSI43K90aaOEBA5Nx5HVT+DagaNvt4YXFGrM8PC/hruoust7T0UOh /JjptZ6ZEWwSE/YaFAa1nL2d++YeXMdcGUapz/E9Nj6ERAP4LeEBEb/BwxZlhLRMjPnM RjSYKiQycZbwL/Sm4Aqbs7A8LZi+XRKYp4rKVh8Hqp0cWeiAbOyla7MiRj8r9A2U2ZEO gUf4q4fcD0EEwWP++lGtlMPSDvksWAM77zE6Pf5pmJyQLfX6AX9uoMLg1tBSDninDQNc JKr+HKgQaDzGm+rYUt3n73FIInQIqZbZMAcuckIrFPHYxUbV5SMqfPzbnf3YLzQcOCZd Ol+w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1777988573; x=1778593373; h=content-transfer-encoding:in-reply-to:from:content-language :references:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=+U+GpGXOrL0cMnQRbFcA7ylLjvJDYXi4Fcpm7XE5qos=; b=dkNqZfmU0NPCtla97LvXIUuk2lU3xaImUVpyEPjTr9pu6YhLvSHla6xG6f2EL4NAM0 gfjyVYXxDpx28lMVKhnI6nL1cZ0EGTGS/tO9NphpItr9fOUbvMm+F+W9Aou37CPF1a/r bG18a4VqIldZkP3NPJbr7WConAseH11A5ofhrNCwCY406kCwutk2UaUelieYxdpZa1/d d2xq0JQH0Z1jME6Bt5i57nLZX2d1EdBXx55Ot5sxtSDftMI0eGMlYeJNA10JkA1oHUcR 2D4MJ7ie4htjHa9QWCTWdwvaz510UatobvAZ4dx7cUw85ciIhcYw2MxJ72l8Y/iKT0zV otVw== X-Forwarded-Encrypted: i=1; AFNElJ9u52BJHIWdqDgUKdIh0sZSnjQk27mCmTxGKbZOi9aPuyvyQMSjSXydu+uqeMekpPr7m90oSp7xsW92YF8=@vger.kernel.org X-Gm-Message-State: AOJu0Yw+PV+gAZaPSDHuTuI1gVCrTk1GnkMDJAjfNkV0Rvne3woEcJp4 ulEC0Xq048bYrmKNhlh3jxs8pMxjzElyzbi9o8j3nqfry+DWqxyuOsiNrjUkkaOlrsPPnlvOng6 VfWobgmWs/iq+cWYUGCupPjYOQfEQaHt9wXgBTXTZMKwXQdtx0ZNNxn7fEAp8fgS/Lg== X-Gm-Gg: AeBDieu56rZDEG7DlqT+/79UtvwKliX/wjxVRqbzzAzGurqBL37Xv3rwtFni4FGEveG 4rGAOjC7fGRsV1Kw7oL6FMZeOL8UCldCysWqqee4FIQxk38ZP1OpM8H/SD7ufeIqU+H0fOoZl0D GSq65SdvbZkr+92DfkWPLfmd3E8rL9l8A6roEsnto0pbUCG2ULM3SFbMcvTbqDewKIldXfgDTK+ tRxYyX76cEURgkAUWZi3za1R3gjqAdp8tHy1FuE++w829dKJnRmFwgJGwVNAJB1t14N6PUtKrB5 XyypCMts9q+GNw8mwSSjiiGKfyOR6W2Cr+d+Bv86AkHcIu6eLRaLWdXMisN8pn+LgaRInW1E0QM hUYTL2hCP6BApQoV2PTWAD8+0PFpqGSVkRLq0DcuvfmfsFs6YNJS1rMfJnZsN0y/tCdc= X-Received: by 2002:a05:600c:a30a:b0:485:30d4:6b9e with SMTP id 5b1f17b1804b1-48d18ce275fmr36490115e9.21.1777988573086; Tue, 05 May 2026 06:42:53 -0700 (PDT) X-Received: by 2002:a05:600c:a30a:b0:485:30d4:6b9e with SMTP id 5b1f17b1804b1-48d18ce275fmr36489575e9.21.1777988572565; Tue, 05 May 2026 06:42:52 -0700 (PDT) Received: from [192.168.88.32] ([212.105.155.47]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-48d149d49acsm30503175e9.1.2026.05.05.06.42.47 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 05 May 2026 06:42:52 -0700 (PDT) Message-ID: <30f588ad-cf80-432b-bde3-13b3c0d5a124@redhat.com> Date: Tue, 5 May 2026 15:42:46 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH net, v3] net: mana: Fix crash from unvalidated SHM offset read from BAR0 during FLR To: Dipayaan Roy , kys@microsoft.com, haiyangz@microsoft.com, wei.liu@kernel.org, decui@microsoft.com, andrew+netdev@lunn.ch, davem@davemloft.net, edumazet@google.com, kuba@kernel.org, leon@kernel.org, longli@microsoft.com, kotaranov@microsoft.com, horms@kernel.org, shradhagupta@linux.microsoft.com, ssengar@linux.microsoft.com, ernis@linux.microsoft.com, shirazsaleem@microsoft.com, linux-hyperv@vger.kernel.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, linux-rdma@vger.kernel.org, stephen@networkplumber.org, jacob.e.keller@intel.com, dipayanroy@microsoft.com, leitao@debian.org, kees@kernel.org, john.fastabend@gmail.com, hawk@kernel.org, bpf@vger.kernel.org, daniel@iogearbox.net, ast@kernel.org, sdf@fomichev.me, yury.norov@gmail.com References: Content-Language: en-US From: Paolo Abeni In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 5/1/26 4:47 AM, Dipayaan Roy wrote: > @@ -73,10 +74,28 @@ static int mana_gd_init_pf_regs(struct pci_dev *pdev) > gc->phys_db_page_base = gc->bar0_pa + gc->db_page_off; > > sriov_base_off = mana_gd_r64(gc, GDMA_SRIOV_REG_CFG_BASE_OFF); > + if (sriov_base_off >= gc->bar0_size || > + gc->bar0_size - sriov_base_off < > + GDMA_PF_REG_SHM_OFF + sizeof(u64) || > + !IS_ALIGNED(sriov_base_off, sizeof(u64))) { > + dev_err(gc->dev, > + "SRIOV base offset 0x%llx out of range or unaligned (BAR0 size 0x%llx)\n", > + sriov_base_off, (u64)gc->bar0_size); > + return -EPROTO; > + } I think that the additional fix suggested by sashiko is really worthy, but should go in a separate patch. @Dipayaan: please follow-up on that one, thanks! Paolo