From: Andrei Warkentin <awarkentin@vmware.com>
To: Valdis Kletnieks <Valdis.Kletnieks@vt.edu>
Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
Andrei Warkentin <andreiw@vmware.com>,
kgdb-bugreport@lists.sourceforge.net,
Jason Wessel <jason.wessel@windriver.com>,
Matt Mackall <mpm@selenic.com>,
Andrei Warkentin <andrey.warkentin@gmail.com>
Subject: Re: [PATCHv3 2/3] NETKGDB: Ethernet/UDP/IP KDB transport.
Date: Sun, 26 Feb 2012 21:36:40 -0800 (PST) [thread overview]
Message-ID: <310080656.1570547.1330321000661.JavaMail.root@zimbra-prod-mbox-2.vmware.com> (raw)
In-Reply-To: <116798.1330320543@turing-police.cc.vt.edu>
Hi,
----- Original Message -----
> From: "Valdis Kletnieks" <Valdis.Kletnieks@vt.edu>
> To: "Andrei Warkentin" <andrey.warkentin@gmail.com>
> Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org, "Andrei Warkentin" <andreiw@vmware.com>,
> kgdb-bugreport@lists.sourceforge.net, "Jason Wessel" <jason.wessel@windriver.com>, "Matt Mackall" <mpm@selenic.com>
> Sent: Monday, February 27, 2012 12:29:03 AM
> Subject: Re: [PATCHv3 2/3] NETKGDB: Ethernet/UDP/IP KDB transport.
>
> This *really* needs a discussion of the security implications of
> this. Do
> you *really* want to have a kgdb that will accept connections from
> *anywhere*?
> Sounds like an insta-root waiting to happen.
>
It does *really* need documentation. It's not meant for general purpose use.
Just like Android devices come with KDB compiled out, this shouldn't be
built in. That means that netkgdb should be default off and come with a
huge warning. It is insta-root. And that's the message it should carry with it.
It's no different from running kgdboc - anyone has root access if they press
Alt-PrtScrn-g, right?
> > +the assigned interface IP address changes. This makes it useful
> > +in an environment where it's not known ahead of time what computer
> > +will connect to perform the crash analysis.
>
> Exactly. You don't know ahead of time who's going to connect. That's
> the
> problem...
It's not a problem unless you make it one. If I am running a private test farm
where I provision 250+ machines or VMs, and I have 10-15 devs that could possibly
investigate the issue, it's not realistic to know ahead of times what internal
IP address the connection could come from.
I will update the docs and the Kconfig (default=off). That should be
sufficient for PEBCAK failures.
Cheers,
A
next prev parent reply other threads:[~2012-02-27 5:36 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1330137851-4716-1-git-send-email-andrey.warkentin@gmail.com>
2012-02-27 2:05 ` NetKGDB support v2 Andrei Warkentin
2012-02-27 2:05 ` [PATCHv2 1/2] NETPOLL: Extend rx_hook support Andrei Warkentin
2012-02-27 2:05 ` [PATCHv2 2/2] NETKGDB: Ethernet/UDP/IP KDB transport Andrei Warkentin
2012-02-27 3:30 ` NetKGDB v3 Andrei Warkentin
2012-02-27 3:30 ` [PATCHv3 1/3] NETPOLL: Extend rx_hook support Andrei Warkentin
2012-02-27 23:17 ` Jason Wessel
2012-02-27 23:33 ` Andrei Warkentin
2012-02-28 16:06 ` Jason Wessel
2012-02-28 17:43 ` Andrei Warkentin
2012-03-01 21:04 ` Andrei Warkentin
2012-03-01 22:24 ` Jason Wessel
2012-03-01 23:41 ` Andrei Warkentin
2012-02-27 3:30 ` [PATCHv3 2/3] NETKGDB: Ethernet/UDP/IP KDB transport Andrei Warkentin
2012-02-27 5:29 ` Valdis.Kletnieks
2012-02-27 5:36 ` Andrei Warkentin [this message]
2012-02-27 3:30 ` [PATCHv3 3/3] KGDB: Allow registering multiple I/O ops Andrei Warkentin
2012-02-27 4:38 ` NetKGDB v3 David Miller
2012-02-27 4:43 ` Andrei E. Warkentin
2012-02-28 0:04 ` Stephen Hemminger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=310080656.1570547.1330321000661.JavaMail.root@zimbra-prod-mbox-2.vmware.com \
--to=awarkentin@vmware.com \
--cc=Valdis.Kletnieks@vt.edu \
--cc=andreiw@vmware.com \
--cc=andrey.warkentin@gmail.com \
--cc=jason.wessel@windriver.com \
--cc=kgdb-bugreport@lists.sourceforge.net \
--cc=linux-kernel@vger.kernel.org \
--cc=mpm@selenic.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox