From: Baolu Lu <baolu.lu@linux.intel.com>
To: "Tian, Kevin" <kevin.tian@intel.com>,
Joerg Roedel <joro@8bytes.org>, Will Deacon <will@kernel.org>,
Robin Murphy <robin.murphy@arm.com>,
Jason Gunthorpe <jgg@ziepe.ca>,
"Badger, Eric" <ebadger@purestorage.com>
Cc: baolu.lu@linux.intel.com,
"iommu@lists.linux.dev" <iommu@lists.linux.dev>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 3/3] iommu/vt-d: Remove scalabe mode in domain_context_clear_one()
Date: Mon, 4 Mar 2024 16:39:14 +0800 [thread overview]
Message-ID: <31054869-9373-481b-a002-5200e26a7bba@linux.intel.com> (raw)
In-Reply-To: <BN9PR11MB527694903CD8E8FBC6C1FB168C232@BN9PR11MB5276.namprd11.prod.outlook.com>
On 2024/3/4 15:53, Tian, Kevin wrote:
>> From: Lu Baolu<baolu.lu@linux.intel.com>
>> Sent: Thursday, February 29, 2024 5:48 PM
>>
>> @@ -2175,9 +2175,6 @@ static void domain_context_clear_one(struct
>> device_domain_info *info, u8 bus, u8
>> struct context_entry *context;
>> u16 did_old;
>>
>> - if (!iommu)
>> - return;
>> -
> is this check only relevant to sm mode or should it be removed for
> both legacy/sm? If the latter please add a note in the commit msg.
This kind of check makes no sense. I didn't take it to sm mode. So only
need to remove it in the legacy path.
Anyway, let me update the commit message to reflect this change.
Best regards,
baolu
prev parent reply other threads:[~2024-03-04 8:39 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-29 9:48 [PATCH 0/3] iommu: Fix domain check on release (part 2/2) Lu Baolu
2024-02-29 9:48 ` [PATCH 1/3] iommu/vt-d: Setup scalable mode context entry in probe path Lu Baolu
2024-03-04 7:48 ` Tian, Kevin
2024-03-04 8:23 ` Baolu Lu
2024-03-04 9:05 ` Tian, Kevin
2024-03-04 11:13 ` Baolu Lu
2024-02-29 9:48 ` [PATCH 2/3] iommu/vt-d: Remove scalable mode context entry setup from attach_dev Lu Baolu
2024-03-04 7:50 ` Tian, Kevin
2024-02-29 9:48 ` [PATCH 3/3] iommu/vt-d: Remove scalabe mode in domain_context_clear_one() Lu Baolu
2024-03-04 7:53 ` Tian, Kevin
2024-03-04 8:39 ` Baolu Lu [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=31054869-9373-481b-a002-5200e26a7bba@linux.intel.com \
--to=baolu.lu@linux.intel.com \
--cc=ebadger@purestorage.com \
--cc=iommu@lists.linux.dev \
--cc=jgg@ziepe.ca \
--cc=joro@8bytes.org \
--cc=kevin.tian@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=robin.murphy@arm.com \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox