From: David Howells <dhowells@redhat.com>
To: Mike Frysinger <vapier@gentoo.org>
Cc: dhowells@redhat.com, uclinux-dev@uclinux.org,
linux-kernel@vger.kernel.org, Greg Ungerer <gerg@uclinux.org>,
uclinux-dist-devel@blackfin.uclinux.org,
David McCullough <davidm@snapgear.com>
Subject: Re: [uClinux-dev] Re: [PATCH] FDPIC: respect PT_GNU_STACK exec markings when creating NOMMU stack
Date: Fri, 04 Dec 2009 09:40:32 +0000 [thread overview]
Message-ID: <31066.1259919632@redhat.com> (raw)
In-Reply-To: <200912040207.09801.vapier@gentoo.org>
Mike Frysinger <vapier@gentoo.org> wrote:
> > + flush_icache_range(mm->brk, brk);
> > return mm->brk = brk;
> > }
>
> probably want mm->brk + brk for the second argument
Ummm... Why? mm->brk and brk are both addresses - note the return statement
where brk just gets assigned to mm->brk.
David
next prev parent reply other threads:[~2009-12-04 9:42 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-11-28 15:24 [PATCH] FDPIC: respect PT_GNU_STACK exec markings when creating NOMMU stack Mike Frysinger
2009-11-28 18:47 ` [uClinux-dev] " Mike Frysinger
2009-12-02 13:44 ` David Howells
2009-12-02 21:29 ` [uClinux-dev] " Mike Frysinger
2009-12-03 17:58 ` David Howells
2009-12-04 7:07 ` Mike Frysinger
2009-12-04 9:40 ` David Howells [this message]
2009-12-04 10:26 ` Mike Frysinger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=31066.1259919632@redhat.com \
--to=dhowells@redhat.com \
--cc=davidm@snapgear.com \
--cc=gerg@uclinux.org \
--cc=linux-kernel@vger.kernel.org \
--cc=uclinux-dev@uclinux.org \
--cc=uclinux-dist-devel@blackfin.uclinux.org \
--cc=vapier@gentoo.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox