public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
* fs/namei.c lookup_flags is misleading
@ 2001-06-20  6:37 Keith Owens
  0 siblings, 0 replies; only message in thread
From: Keith Owens @ 2001-06-20  6:37 UTC (permalink / raw)
  To: linux-kernel

2.4.6-pre3 and earlier.  fs/namei.c:lookup_flags() checks for O_CREATE,
it even has a comment saying that O_CREATE|O_EXCL is a special case.
But the only place lookup_flags() is called has

if (!(flag & O_CREAT)) {
	if (path_init(pathname, lookup_flags(flag), nd))

so O_CREATE can never be set.  Not a bug, just misleading.  It does not
help that path_walk() has a variable called lookup_flags.


^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2001-06-20  6:38 UTC | newest]

Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2001-06-20  6:37 fs/namei.c lookup_flags is misleading Keith Owens

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox