From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755700Ab0ELLiQ (ORCPT ); Wed, 12 May 2010 07:38:16 -0400 Received: from mx1.redhat.com ([209.132.183.28]:22339 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752180Ab0ELLiO (ORCPT ); Wed, 12 May 2010 07:38:14 -0400 Organization: Red Hat UK Ltd. Registered Address: Red Hat UK Ltd, Amberley Place, 107-111 Peascod Street, Windsor, Berkshire, SI4 1TE, United Kingdom. Registered in England and Wales under Company Registration No. 3798903 From: David Howells In-Reply-To: <1273634462-2672-3-git-send-email-walken@google.com> References: <1273634462-2672-3-git-send-email-walken@google.com> <1273634462-2672-1-git-send-email-walken@google.com> To: Michel Lespinasse Cc: dhowells@redhat.com, Linus Torvalds , Ingo Molnar , Thomas Gleixner , LKML , Andrew Morton , Mike Waychison , Suleiman Souhlal , Ying Han Subject: Re: [PATCH 02/12] rwsem: use single atomic update for sem count when waking up readers. Date: Wed, 12 May 2010 12:36:36 +0100 Message-ID: <31121.1273664196@redhat.com> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Michel Lespinasse wrote: > + * write lock. However, we only only wake someone up Can you get rid of the excess 'only' whilst you're at it? David