Re: [patch V4 part 3 09/29] x86/entry/32: Provide macro to emit IDT entry stubs

Andy Lutomirski
2020-05-11T00:55:28Z

On Tue, May 5, 2020 at 7:15 AM Thomas Gleixner <tglx@linutronix.de> wrote:
>
> From: Thomas Gleixner <tglx@linutronix.de>
>
> 32 and 64 bit have unnecessary different ways to populate the exception
> entry code. Provide a idtentry macro which allows to consolidate all of
> that.
>
> Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
> Reviewed-by: Alexandre Chartre <alexandre.chartre@oracle.com>

Acked-by: Andy Lutomirski <luto@kernel.org>
> + /* fixup %gs */
> + GS_TO_REG %ecx
> + movl PT_GS(%esp), %edi # get the function address
> + REG_TO_PTGS %ecx
> + SET_KERNEL_GS %ecx

This GS garbage remains an atrocity. Some day if I'm inspired to
clean up 32-bit stuff, I'll decrapify it.