Re: [patch V4 part 3 12/29] x86/entry/common: Provide idtentry_enter/exit()

Mathieu Desnoyers
2020-05-14T01:08:33Z

----- On May 5, 2020, at 9:44 AM, Thomas Gleixner tglx@linutronix.de wrote:
[...]
> + * Invokes:
> + * - lockdep irqflag state tracking as low level ASM entry disabled
> + * interrupts.
> + *
> + * - Context tracking if the exception hit user mode.
> + *
> + * - RCU notification if the exception hit kernel mode

Nit: missing "." at end of line.

> + *
> + * - The hardirq tracer to keep the state consistent as low level ASM
> + * entry disabled interrupts.

> + * This needs to be done very carefully.
> + * idtentry_enter() invoked rcu_irq_enter(). This
> + * needs to undone before scheduling.

Nit: "to undone" -> "to be undone".

Thanks,

Mathieu

--
Mathieu Desnoyers
EfficiOS Inc.