From: Jarkko Nikula <jarkko.nikula@linux.intel.com>
To: Wolfram Sang <wsa+renesas@sang-engineering.com>,
linux-i3c@lists.infradead.org
Cc: linux-kernel@vger.kernel.org, linux-renesas-soc@vger.kernel.org,
Alexandre Belloni <alexandre.belloni@bootlin.com>
Subject: Re: [PATCH v4 4/5] i3c: mipi-i3c-hci: use parity8 helper instead of open coding it
Date: Wed, 8 Jan 2025 14:09:34 +0200 [thread overview]
Message-ID: <3117d2d9-260a-4e02-8c22-4e078e01ddd5@linux.intel.com> (raw)
In-Reply-To: <20250107090204.6593-5-wsa+renesas@sang-engineering.com>
On 1/7/25 11:02 AM, Wolfram Sang wrote:
> The kernel has now a generic helper for getting parity with easier to
> understand semantics. Make use of it. Here, it also fixes a bug because
> the correct algorithm is using XOR ('^=') instead of ADD ('+=').
>
> Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com>
> Tested-by: Jarkko Nikula <jarkko.nikula@linux.intel.com>
> ---
>
> Change since v3:
>
> * updated commit message to mention the bugfix
>
> I intentionally did not add a Fixes tag because this fix depends on
> patch 1. The proper fix for backporting would change this to XOR, I'd
> think.
>
Stable rules allow also cherry picking additional patches. To me picking
patch 1 and 4 sounds better than an intermediate fix since bug has been
here from the beginning. IMHO not so urgent than a regression.
Looks like we have been lucky. First dynamic address is 0x9 and previous
algorithm gets the same calculated dat_w0 value for at least for the
addresses 0x9 and 0xa.
next prev parent reply other threads:[~2025-01-08 12:09 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-01-07 9:01 [PATCH v4 0/5] i3c: introduce and use generic parity helper Wolfram Sang
2025-01-07 9:01 ` [PATCH v4 1/5] bitops: add generic parity calculation for u8 Wolfram Sang
2025-01-07 9:02 ` [PATCH v4 2/5] hwmon: (spd5118) Use generic parity calculation Wolfram Sang
2025-01-07 9:02 ` [PATCH v4 3/5] i3c: dw: use parity8 helper instead of open coding it Wolfram Sang
2025-01-07 9:02 ` [PATCH v4 4/5] i3c: mipi-i3c-hci: " Wolfram Sang
2025-01-08 12:09 ` Jarkko Nikula [this message]
2025-01-08 12:56 ` Wolfram Sang
2025-01-08 15:32 ` Jarkko Nikula
2025-01-07 9:02 ` [PATCH v4 5/5] i3c: cdns: " Wolfram Sang
2025-01-08 7:23 ` [PATCH v4 0/5] i3c: introduce and use generic parity helper Wolfram Sang
2025-01-12 23:05 ` Alexandre Belloni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3117d2d9-260a-4e02-8c22-4e078e01ddd5@linux.intel.com \
--to=jarkko.nikula@linux.intel.com \
--cc=alexandre.belloni@bootlin.com \
--cc=linux-i3c@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=wsa+renesas@sang-engineering.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox