From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3E20DC33CAA for ; Tue, 21 Jan 2020 11:47:19 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 19B6D20882 for ; Tue, 21 Jan 2020 11:47:19 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729526AbgAULrR (ORCPT ); Tue, 21 Jan 2020 06:47:17 -0500 Received: from mga17.intel.com ([192.55.52.151]:61041 "EHLO mga17.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729416AbgAULrR (ORCPT ); Tue, 21 Jan 2020 06:47:17 -0500 X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga006.jf.intel.com ([10.7.209.51]) by fmsmga107.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 21 Jan 2020 03:47:16 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.70,345,1574150400"; d="scan'208";a="228796761" Received: from linux.intel.com ([10.54.29.200]) by orsmga006.jf.intel.com with ESMTP; 21 Jan 2020 03:47:16 -0800 Received: from [10.226.38.27] (unknown [10.226.38.27]) by linux.intel.com (Postfix) with ESMTP id 6FBE95802A3; Tue, 21 Jan 2020 03:47:14 -0800 (PST) Subject: Re: [PATCH v6 0/2] spi: cadence-quadpsi: Add support for the Cadence QSPI controller From: "Ramuthevar, Vadivel MuruganX" To: Vignesh Raghavendra , broonie@kernel.org, linux-spi@vger.kernel.org, linux-kernel@vger.kernel.org Cc: robh+dt@kernel.org, dan.carpenter@oracle.com, cheol.yong.kim@intel.com, qi-ming.wu@intel.com References: <20191230074102.50982-1-vadivel.muruganx.ramuthevar@linux.intel.com> <860aecbc-22d3-c9ce-3570-44115d6e81b2@ti.com> <1aa6033a-c9e1-579b-0916-25037c07654d@linux.intel.com> Message-ID: <3118e6d5-84f3-cbcf-6a42-761b0d23cb72@linux.intel.com> Date: Tue, 21 Jan 2020 19:47:13 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:60.0) Gecko/20100101 Thunderbird/60.9.1 MIME-Version: 1.0 In-Reply-To: <1aa6033a-c9e1-579b-0916-25037c07654d@linux.intel.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit Content-Language: en-US Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi, On 15/1/2020 2:21 PM, Ramuthevar, Vadivel MuruganX wrote: > Hi, > > On 15/1/2020 2:13 PM, Vignesh Raghavendra wrote: >> Hi, >> >> On 12/30/2019 1:11 PM, Ramuthevar,Vadivel MuruganX wrote: >>> Add support for the Cadence QSPI controller. This controller is >>> present in the Intel Lightning Mountain(LGM) SoCs, Altera and TI SoCs. >>> This driver has been tested on the Intel LGM SoCs. >>> >>> This driver does not support generic SPI and also the implementation >>> only supports spi-mem interface to replace the existing driver in >>> mtd/spi-nor/cadence-quadspi.c, the existing driver only support SPI-NOR >>> flash memory. >>> >> >> >> I am finally able to get spi-mem based cadence-quaspi driver working on >> TI platforms with DMA and DAC mode. I have also incorporated changes to >> disable DAC and autopolling for your intel SoC: > > Thanks! a lot for the confirmation, with your changes it is working on > TI platform. > >> https://github.com/r-vignesh/linux/commits/qspi >> >> (Top two patches are of interest) >> >> I have tested both DAC and INDAC mode with s25fl flash and everything >> seems to be fine. Could you re test the driver on your SoC? while re-testing QSPI_NOR/NAND both didn't work, after few changes from patchV6 followed by your changes, now QSPI-NOR started working,  soon will be sending updated patch version which includes your changes as well as my changes without affecting both the platforms(TI and Intel). BTW,  Have you tested QSPI-NAND on your platform ? with our patches. Thanks! for your review and support. Regards Vadivel >> Feel free to >> fold it into your series if everything works. > sure, I will test on Intel SoC with your changes . > > Regards > Vadivel >> Regards >> Vignesh >> >> >>