* [PATCH v2] arm64: dts: freescale: imx8mp-phyboard-pollux: Add and enable TPM
@ 2024-08-07 15:18 Benjamin Hahn
2024-08-07 16:10 ` Fabio Estevam
` (2 more replies)
0 siblings, 3 replies; 6+ messages in thread
From: Benjamin Hahn @ 2024-08-07 15:18 UTC (permalink / raw)
To: Rob Herring, Krzysztof Kozlowski, Conor Dooley, Shawn Guo,
Sascha Hauer, Pengutronix Kernel Team, Fabio Estevam,
Teresa Remmet
Cc: devicetree, imx, linux-arm-kernel, linux-kernel, Benjamin Hahn
Add support for TPM for phyBOARD Pollux.
Signed-off-by: Benjamin Hahn <B.Hahn@phytec.de>
---
Changes in v2:
- renamed tpm node to tpm@0
- removed num-cs
- cleanup pinctrl
- Link to v1: https://lore.kernel.org/r/20240805-imx8mp-tpm-v1-1-1e89f0268999@phytec.de
---
.../dts/freescale/imx8mp-phyboard-pollux-rdk.dts | 26 ++++++++++++++++++++++
1 file changed, 26 insertions(+)
diff --git a/arch/arm64/boot/dts/freescale/imx8mp-phyboard-pollux-rdk.dts b/arch/arm64/boot/dts/freescale/imx8mp-phyboard-pollux-rdk.dts
index 00a240484c25..0e8200413557 100644
--- a/arch/arm64/boot/dts/freescale/imx8mp-phyboard-pollux-rdk.dts
+++ b/arch/arm64/boot/dts/freescale/imx8mp-phyboard-pollux-rdk.dts
@@ -103,6 +103,23 @@ reg_vcc_3v3_sw: regulator-vcc-3v3-sw {
};
};
+/* TPM */
+&ecspi1 {
+ #address-cells = <1>;
+ #size-cells = <0>;
+ cs-gpios = <&gpio5 9 GPIO_ACTIVE_LOW>;
+ pinctrl-names = "default";
+ pinctrl-0 = <&pinctrl_ecspi1>;
+ status = "okay";
+
+ tpm: tpm@0 {
+ compatible = "infineon,slb9670", "tcg,tpm_tis-spi";
+ reg = <0>;
+ spi-max-frequency = <38000000>;
+ status = "okay";
+ };
+};
+
&eqos {
pinctrl-names = "default";
pinctrl-0 = <&pinctrl_eqos>;
@@ -300,6 +317,15 @@ &gpio4 {
};
&iomuxc {
+ pinctrl_ecspi1: ecspi1grp {
+ fsl,pins = <
+ MX8MP_IOMUXC_ECSPI1_MISO__ECSPI1_MISO 0x80
+ MX8MP_IOMUXC_ECSPI1_MOSI__ECSPI1_MOSI 0x80
+ MX8MP_IOMUXC_ECSPI1_SCLK__ECSPI1_SCLK 0x80
+ MX8MP_IOMUXC_ECSPI1_SS0__GPIO5_IO09 0x00
+ >;
+ };
+
pinctrl_eqos: eqosgrp {
fsl,pins = <
MX8MP_IOMUXC_ENET_MDC__ENET_QOS_MDC 0x2
---
base-commit: 17712b7ea0756799635ba159cc773082230ed028
change-id: 20240805-imx8mp-tpm-3df607b1f5f1
Best regards,
--
Benjamin Hahn <B.Hahn@phytec.de>
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH v2] arm64: dts: freescale: imx8mp-phyboard-pollux: Add and enable TPM
2024-08-07 15:18 [PATCH v2] arm64: dts: freescale: imx8mp-phyboard-pollux: Add and enable TPM Benjamin Hahn
@ 2024-08-07 16:10 ` Fabio Estevam
2024-08-08 2:26 ` Peng Fan
2024-08-08 10:27 ` Krzysztof Kozlowski
2 siblings, 0 replies; 6+ messages in thread
From: Fabio Estevam @ 2024-08-07 16:10 UTC (permalink / raw)
To: Benjamin Hahn
Cc: Rob Herring, Krzysztof Kozlowski, Conor Dooley, Shawn Guo,
Sascha Hauer, Pengutronix Kernel Team, Teresa Remmet, devicetree,
imx, linux-arm-kernel, linux-kernel
Hi Benjamin,
On Wed, Aug 7, 2024 at 12:18 PM Benjamin Hahn <B.Hahn@phytec.de> wrote:
>
> Add support for TPM for phyBOARD Pollux.
>
> Signed-off-by: Benjamin Hahn <B.Hahn@phytec.de>
Reviewed-by: Fabio Estevam <festevam@gmail.com>
^ permalink raw reply [flat|nested] 6+ messages in thread
* RE: [PATCH v2] arm64: dts: freescale: imx8mp-phyboard-pollux: Add and enable TPM
2024-08-07 15:18 [PATCH v2] arm64: dts: freescale: imx8mp-phyboard-pollux: Add and enable TPM Benjamin Hahn
2024-08-07 16:10 ` Fabio Estevam
@ 2024-08-08 2:26 ` Peng Fan
2024-08-08 10:27 ` Krzysztof Kozlowski
2 siblings, 0 replies; 6+ messages in thread
From: Peng Fan @ 2024-08-08 2:26 UTC (permalink / raw)
To: Benjamin Hahn, Rob Herring, Krzysztof Kozlowski, Conor Dooley,
Shawn Guo, Sascha Hauer, Pengutronix Kernel Team, Fabio Estevam,
t.remmet@phytec.de
Cc: devicetree@vger.kernel.org, imx@lists.linux.dev,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org
> Subject: [PATCH v2] arm64: dts: freescale: imx8mp-phyboard-pollux:
> Add and enable TPM
>
> Add support for TPM for phyBOARD Pollux.
>
> Signed-off-by: Benjamin Hahn <B.Hahn@phytec.de>
> ---
> Changes in v2:
> - renamed tpm node to tpm@0
> - removed num-cs
> - cleanup pinctrl
> - Link to v1:
> ---
> .../dts/freescale/imx8mp-phyboard-pollux-rdk.dts | 26
> ++++++++++++++++++++++
> 1 file changed, 26 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/freescale/imx8mp-phyboard-pollux-
> rdk.dts b/arch/arm64/boot/dts/freescale/imx8mp-phyboard-pollux-
> rdk.dts
> index 00a240484c25..0e8200413557 100644
> --- a/arch/arm64/boot/dts/freescale/imx8mp-phyboard-pollux-rdk.dts
> +++ b/arch/arm64/boot/dts/freescale/imx8mp-phyboard-pollux-rdk.dts
> @@ -103,6 +103,23 @@ reg_vcc_3v3_sw: regulator-vcc-3v3-sw {
> };
> };
>
> +/* TPM */
> +&ecspi1 {
> + #address-cells = <1>;
> + #size-cells = <0>;
Duplicated with imx8mp.dtsi. Other than this:
Reviewed-by: Peng Fan <peng.fan@nxp.com>
Regards,
Peng.
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH v2] arm64: dts: freescale: imx8mp-phyboard-pollux: Add and enable TPM
2024-08-07 15:18 [PATCH v2] arm64: dts: freescale: imx8mp-phyboard-pollux: Add and enable TPM Benjamin Hahn
2024-08-07 16:10 ` Fabio Estevam
2024-08-08 2:26 ` Peng Fan
@ 2024-08-08 10:27 ` Krzysztof Kozlowski
2024-08-09 7:11 ` Benjamin Hahn
2 siblings, 1 reply; 6+ messages in thread
From: Krzysztof Kozlowski @ 2024-08-08 10:27 UTC (permalink / raw)
To: Benjamin Hahn, Rob Herring, Krzysztof Kozlowski, Conor Dooley,
Shawn Guo, Sascha Hauer, Pengutronix Kernel Team, Fabio Estevam,
Teresa Remmet
Cc: devicetree, imx, linux-arm-kernel, linux-kernel
On 07/08/2024 17:18, Benjamin Hahn wrote:
> Add support for TPM for phyBOARD Pollux.
>
> Signed-off-by: Benjamin Hahn <B.Hahn@phytec.de>
> ---
> Changes in v2:
> - renamed tpm node to tpm@0
> - removed num-cs
> - cleanup pinctrl
> - Link to v1: https://lore.kernel.org/r/20240805-imx8mp-tpm-v1-1-1e89f0268999@phytec.de
> ---
> .../dts/freescale/imx8mp-phyboard-pollux-rdk.dts | 26 ++++++++++++++++++++++
> 1 file changed, 26 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/freescale/imx8mp-phyboard-pollux-rdk.dts b/arch/arm64/boot/dts/freescale/imx8mp-phyboard-pollux-rdk.dts
> index 00a240484c25..0e8200413557 100644
> --- a/arch/arm64/boot/dts/freescale/imx8mp-phyboard-pollux-rdk.dts
> +++ b/arch/arm64/boot/dts/freescale/imx8mp-phyboard-pollux-rdk.dts
> @@ -103,6 +103,23 @@ reg_vcc_3v3_sw: regulator-vcc-3v3-sw {
> };
> };
>
> +/* TPM */
> +&ecspi1 {
> + #address-cells = <1>;
> + #size-cells = <0>;
> + cs-gpios = <&gpio5 9 GPIO_ACTIVE_LOW>;
> + pinctrl-names = "default";
> + pinctrl-0 = <&pinctrl_ecspi1>;
> + status = "okay";
> +
> + tpm: tpm@0 {
> + compatible = "infineon,slb9670", "tcg,tpm_tis-spi";
> + reg = <0>;
> + spi-max-frequency = <38000000>;
> + status = "okay";
Did you disabled it anywhere?
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH v2] arm64: dts: freescale: imx8mp-phyboard-pollux: Add and enable TPM
2024-08-08 10:27 ` Krzysztof Kozlowski
@ 2024-08-09 7:11 ` Benjamin Hahn
2024-08-09 7:27 ` Krzysztof Kozlowski
0 siblings, 1 reply; 6+ messages in thread
From: Benjamin Hahn @ 2024-08-09 7:11 UTC (permalink / raw)
To: Krzysztof Kozlowski, Rob Herring, Krzysztof Kozlowski,
Conor Dooley, Shawn Guo, Sascha Hauer, Pengutronix Kernel Team,
Fabio Estevam, Teresa Remmet
Cc: devicetree@vger.kernel.org, imx@lists.linux.dev,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org
On 08.08.24 12:27, Krzysztof Kozlowski wrote:
> On 07/08/2024 17:18, Benjamin Hahn wrote:
>> Add support for TPM for phyBOARD Pollux.
>>
>> Signed-off-by: Benjamin Hahn <B.Hahn@phytec.de>
>> ---
>> Changes in v2:
>> - renamed tpm node to tpm@0
>> - removed num-cs
>> - cleanup pinctrl
>> - Link to v1: https://lore.kernel.org/r/20240805-imx8mp-tpm-v1-1-1e89f0268999@phytec.de
>> ---
>> .../dts/freescale/imx8mp-phyboard-pollux-rdk.dts | 26 ++++++++++++++++++++++
>> 1 file changed, 26 insertions(+)
>>
>> diff --git a/arch/arm64/boot/dts/freescale/imx8mp-phyboard-pollux-rdk.dts b/arch/arm64/boot/dts/freescale/imx8mp-phyboard-pollux-rdk.dts
>> index 00a240484c25..0e8200413557 100644
>> --- a/arch/arm64/boot/dts/freescale/imx8mp-phyboard-pollux-rdk.dts
>> +++ b/arch/arm64/boot/dts/freescale/imx8mp-phyboard-pollux-rdk.dts
>> @@ -103,6 +103,23 @@ reg_vcc_3v3_sw: regulator-vcc-3v3-sw {
>> };
>> };
>>
>> +/* TPM */
>> +&ecspi1 {
>> + #address-cells = <1>;
>> + #size-cells = <0>;
>> + cs-gpios = <&gpio5 9 GPIO_ACTIVE_LOW>;
>> + pinctrl-names = "default";
>> + pinctrl-0 = <&pinctrl_ecspi1>;
>> + status = "okay";
>> +
>> + tpm: tpm@0 {
>> + compatible = "infineon,slb9670", "tcg,tpm_tis-spi";
>> + reg = <0>;
>> + spi-max-frequency = <38000000>;
>> + status = "okay";
> Did you disabled it anywhere?
No, we don't disable it anywhere at the moment.
Benjamin
>
> Best regards,
> Krzysztof
>
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH v2] arm64: dts: freescale: imx8mp-phyboard-pollux: Add and enable TPM
2024-08-09 7:11 ` Benjamin Hahn
@ 2024-08-09 7:27 ` Krzysztof Kozlowski
0 siblings, 0 replies; 6+ messages in thread
From: Krzysztof Kozlowski @ 2024-08-09 7:27 UTC (permalink / raw)
To: Benjamin Hahn, Rob Herring, Krzysztof Kozlowski, Conor Dooley,
Shawn Guo, Sascha Hauer, Pengutronix Kernel Team, Fabio Estevam,
Teresa Remmet
Cc: devicetree@vger.kernel.org, imx@lists.linux.dev,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org
On 09/08/2024 09:11, Benjamin Hahn wrote:
>>> + #address-cells = <1>;
>>> + #size-cells = <0>;
>>> + cs-gpios = <&gpio5 9 GPIO_ACTIVE_LOW>;
>>> + pinctrl-names = "default";
>>> + pinctrl-0 = <&pinctrl_ecspi1>;
>>> + status = "okay";
>>> +
>>> + tpm: tpm@0 {
>>> + compatible = "infineon,slb9670", "tcg,tpm_tis-spi";
>>> + reg = <0>;
>>> + spi-max-frequency = <38000000>;
>>> + status = "okay";
>> Did you disabled it anywhere?
>
> No, we don't disable it anywhere at the moment.
Then drop it...
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2024-08-09 7:27 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-08-07 15:18 [PATCH v2] arm64: dts: freescale: imx8mp-phyboard-pollux: Add and enable TPM Benjamin Hahn
2024-08-07 16:10 ` Fabio Estevam
2024-08-08 2:26 ` Peng Fan
2024-08-08 10:27 ` Krzysztof Kozlowski
2024-08-09 7:11 ` Benjamin Hahn
2024-08-09 7:27 ` Krzysztof Kozlowski
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox