From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756812AbcA2VGU (ORCPT ); Fri, 29 Jan 2016 16:06:20 -0500 Received: from mout.kundenserver.de ([212.227.126.130]:58967 "EHLO mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751075AbcA2VGS (ORCPT ); Fri, 29 Jan 2016 16:06:18 -0500 From: Arnd Bergmann To: Al Viro Cc: linux-arch@vger.kernel.org, linux-kbuild@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 02/12] EXPORT_SYMBOL() for asm Date: Fri, 29 Jan 2016 22:06:15 +0100 Message-ID: <3120161.7CSEIIFIYh@wuerfel> User-Agent: KMail/4.11.5 (Linux/3.16.0-10-generic; KDE/4.11.5; x86_64; ; ) In-Reply-To: <1454095114-4128-2-git-send-email-viro@ZenIV.linux.org.uk> References: <20160129191744.GB17997@ZenIV.linux.org.uk> <1454095114-4128-2-git-send-email-viro@ZenIV.linux.org.uk> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" X-Provags-ID: V03:K0:03Ax7U01KXtI9qymQ5tOPNxJGnK5HckWXwVI9bk/H9LeVxeCyWE VfJ8GTmqWGaYJ9H5nr84UQxu7J8JOYnw3n9rWFqlkulsgFQ5vb0614WvvlEpwDQKLBuf4f2 rzGxXZ/jpl05aFEcwbgt93qKxfgPPT9JnZm0MFkOnV+uZn81ywWophXVqE/y0jDbgroKSnP TjYzJUujO8J6U+5lXkUJA== X-UI-Out-Filterresults: notjunk:1;V01:K0:VlXKH3r5NPc=:u80UIGtDmKBOkMekzkhJEa ImA2RVxKo81occlK056bHdIaP/5wyPDzGfA31QbX4hs3dyUaV0avT6ZG0ZuF/arRVN0QKdKBW I0aZxXPL1jxJYWVWZ3dgHDGu4jSmbE0scm1vEaNUeqrJn1Xl5hXGtUcQdL7DJvB6Dhiq+lm9O DULJ68E21YNyZZrVSqqpKV/n2F5gtdLHzmDF0dvzjzg4z6KqXonoUFppYQapt1b2I0GEafw/Z 26hZOHS9/bjC/TxwyOaBmcK1z8T6ksim4gf271ZSsguujlJocGVhSfiehucHmsWRFwJUXNMn+ VZ6vks3qbd5H+L/xS2yrd9QGwferRW/7+rfQK0rHGnRB7xi/JiLCPolW4Cnq8Xh2O8hOMAygi 640beezTftUE0sTvEMagEecoK36B4sF34+YGdTVPB4ai6R7ZT1D5uWNTRgYSOPSwOfgGsc1kp 6IAsiAgghTbAg40nvir2mYJbt8Ba6FiqhXQkr5Cwyx+TCNCT5Ci3yU4lNu9n8QkxythoiffPm M/xWqLwjp8T7Vj3Z8wL0dGrReZaoCyA2g8hdIzoi08/SKq8gIaO/Nk2jY2pvYVb/q3ChAGool ZA0z6+Ce5cAMMpAX8OKcK0YT8f6WrTY1YWXLjMdyFUV4AklHa+O8TNbj5AJFMevPpFR+FbTJa qaDbyaDYiKvnd9m+j/tO7pY0lcUq7vgUpAmYKpRJf70U15dPljfEo6q6z/AjCgCCfMqc9L0wo HT+42PUEojhjdzyc Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Friday 29 January 2016 19:18:24 Al Viro wrote: > From: Al Viro > > Add asm-usable variants of EXPORT_SYMBOL/EXPORT_SYMBOL_GPL. This > commit just adds the default implementation; most of the architectures > can simply add export.h to asm/Kbuild and start using > from assembler. The area where the things might diverge from default > is the alignment; normally it's 8 bytes on 64bit targets and 4 on > 32bit ones, both for unsigned long and for struct kernel_symbol. > > Unfortunately, amd64 and m68k are unusual - m68k aligns to 2 bytes > (for both) and amd64 aligns struct kernel_symbol to 16 bytes. For > those we'll need to have asm/export.h overriding the constants used > by generic version (KSYM_ALIGN and KCRC_ALIGN for kernel_symbol and > unsigned long resp.) and including asm-generic/export.h. > > And no, __alignof__ would not do the trick - on amd64 __alignof__ > of struct kernel_symbol is 8, not 16. > > Signed-off-by: Al Viro > --- > include/asm-generic/export.h | 61 ++++++++++++++++++++++++++++++++++++++++++++ > 1 file changed, 61 insertions(+) > create mode 100644 include/asm-generic/export.h > For asm-generic: Acked-by: Arnd Bergmann