From: "Ilpo Järvinen" <ilpo.jarvinen@linux.intel.com>
To: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Cc: Hans de Goede <hdegoede@redhat.com>,
Julian Winkler <julian.winkler1@web.de>,
platform-driver-x86@vger.kernel.org,
LKML <linux-kernel@vger.kernel.org>,
Mika Westerberg <mika.westerberg@linux.intel.com>
Subject: Re: [PATCH v1 2/2] platform/x86: intel_scu_pcidrv: Remove unused intel-mid.h
Date: Wed, 6 Mar 2024 12:44:03 +0200 (EET) [thread overview]
Message-ID: <31213f82-196d-8ab0-6c24-a09a2db43388@linux.intel.com> (raw)
In-Reply-To: <20240305161539.1364717-3-andriy.shevchenko@linux.intel.com>
On Tue, 5 Mar 2024, Andy Shevchenko wrote:
> intel-mid.h is providing some core parts of the South Complex PM,
> which are usually are not used by individual drivers. In particular,
Both applied to review-ilpo. I fixed that double "are" for you while
applying.
--
i.
> this driver doesn't use it, so simply remove the unused header.
>
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> ---
> drivers/platform/x86/intel_scu_pcidrv.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/platform/x86/intel_scu_pcidrv.c b/drivers/platform/x86/intel_scu_pcidrv.c
> index d904fad499aa..dbf0310448da 100644
> --- a/drivers/platform/x86/intel_scu_pcidrv.c
> +++ b/drivers/platform/x86/intel_scu_pcidrv.c
> @@ -11,7 +11,6 @@
> #include <linux/init.h>
> #include <linux/pci.h>
>
> -#include <asm/intel-mid.h>
> #include <asm/intel_scu_ipc.h>
>
> static int intel_scu_pci_probe(struct pci_dev *pdev,
>
next prev parent reply other threads:[~2024-03-06 10:44 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-05 16:14 [PATCH v1 0/2] platform/x86: Remove unused intel-mid.h Andy Shevchenko
2024-03-05 16:14 ` [PATCH v1 1/2] platform/x86: intel_scu_wdt: " Andy Shevchenko
2024-03-05 19:37 ` Kuppuswamy Sathyanarayanan
2024-03-05 16:14 ` [PATCH v1 2/2] platform/x86: intel_scu_pcidrv: " Andy Shevchenko
2024-03-05 19:39 ` Kuppuswamy Sathyanarayanan
2024-03-06 10:44 ` Ilpo Järvinen [this message]
2024-03-06 13:32 ` Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=31213f82-196d-8ab0-6c24-a09a2db43388@linux.intel.com \
--to=ilpo.jarvinen@linux.intel.com \
--cc=andriy.shevchenko@linux.intel.com \
--cc=hdegoede@redhat.com \
--cc=julian.winkler1@web.de \
--cc=linux-kernel@vger.kernel.org \
--cc=mika.westerberg@linux.intel.com \
--cc=platform-driver-x86@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox