From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932942AbcIALVx (ORCPT ); Thu, 1 Sep 2016 07:21:53 -0400 Received: from mailout3.samsung.com ([203.254.224.33]:37191 "EHLO mailout3.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932212AbcIALVt (ORCPT ); Thu, 1 Sep 2016 07:21:49 -0400 X-AuditID: cbfee61a-f78ff6d000001462-6f-57c80f4a2ce5 From: Bartlomiej Zolnierkiewicz To: Krzysztof Kozlowski Cc: javier@osg.samsung.com, Arnd Bergmann , Kukjin Kim , Krzysztof Kozlowski , devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 2/2] ARM: dts: exynos: Fix mismatched values of SD drive strengh configuration on exynos4415 Date: Thu, 01 Sep 2016 13:21:42 +0200 Message-id: <3122615.TmPyqONA3V@amdc1976> User-Agent: KMail/4.13.3 (Linux/3.13.0-79-generic; KDE/4.13.3; x86_64; ; ) In-reply-to: <1472719022-27226-2-git-send-email-k.kozlowski@samsung.com> References: <1472719022-27226-1-git-send-email-k.kozlowski@samsung.com> <1472719022-27226-2-git-send-email-k.kozlowski@samsung.com> MIME-version: 1.0 Content-transfer-encoding: 7Bit Content-type: text/plain; charset=us-ascii X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFnrFLMWRmVeSWpSXmKPExsVy+t9jAV0v/hPhBk/um1n8nXSM3WL+kXOs Fm/ermGyeP3C0KL/8Wtmi/PnN7BbbHp8jdXi8q45bBYzzu9jcuD0+P1rEqPHplWdbB6bl9R7 bOm/y+7Rt2UVo8fnTXIBbFFcNimpOZllqUX6dglcGUsPdbIUPBWq2LyNu4FxBn8XIyeHhICJ xIG1i5kgbDGJC/fWs4HYQgJLGSWaHwtA2F8ZJR5dAYuzCVhJTGxfxQhiiwgYShzcvR2ol4uD WaCDSWLV6b+sIAlhgSKJ6W0TWLoYOThYBFQlfr1WAQnzCmhKHFm7mRnEFhXwkujZ/ghsDqeA h8SUZ7NZQeYICbQySuzv7mCGaBCU+DH5HguIzSwgL7Fv/1RWCFtLYv3O40wTGAVmISmbhaRs FpKyBYzMqxglUguSC4qT0nMN81LL9YoTc4tL89L1kvNzNzGCY+CZ1A7Gg7vcDzEKcDAq8fB6 BR4PF2JNLCuuzD3EKMHBrCTCW811IlyINyWxsiq1KD++qDQntfgQozQHi5I47+P/68KEBNIT S1KzU1MLUotgskwcnFINjCWzquct+WZz+88TU2V3ppyvk7bxedkISv7v4ORpEfF2l/U0y9sR 42mhatZ0c35yhbQUe4fy0wXSG+T6vj74Eb6IJbY76sQ9cYdax8ANpdY35MT59950etr99d73 lTnM69PLZDwjhM4fU+x25rn5gI/lMwPjc9ZFqackOqI5/0QcfF6csF1biaU4I9FQi7moOBEA W9w9en0CAAA= Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi, On Thursday, September 01, 2016 10:37:02 AM Krzysztof Kozlowski wrote: > The pinctrl drive strength register on exynos4415 is 2-bit wide for each > pin. The pins for SD2 were configured with value of 4. The driver does > not validate the value so this overflow effectively set a bit 1 in > adjacent pins thus configuring them to drive strength 2x. > > The author's intention was probably to set drive strength of 4x. > All other SD pins are configured with drive strength of 4x. Fix these > with same pattern. > > Fixes: 9246e7ff24c5 ("ARM: dts: Add dts files for exynos4415 SoC") > Signed-off-by: Krzysztof Kozlowski Reviewed-by: Bartlomiej Zolnierkiewicz BTW This reminds me that there are still no board files for Exynos4415 SoC based boards so maybe we should consider removal of its support? > --- > arch/arm/boot/dts/exynos4415-pinctrl.dtsi | 8 ++++---- > 1 file changed, 4 insertions(+), 4 deletions(-) > > diff --git a/arch/arm/boot/dts/exynos4415-pinctrl.dtsi b/arch/arm/boot/dts/exynos4415-pinctrl.dtsi > index f54aee53b6ec..76cfd872ead3 100644 > --- a/arch/arm/boot/dts/exynos4415-pinctrl.dtsi > +++ b/arch/arm/boot/dts/exynos4415-pinctrl.dtsi > @@ -480,14 +480,14 @@ > samsung,pins = "gpk2-0"; > samsung,pin-function = ; > samsung,pin-pud = ; > - samsung,pin-drv = <4>; > + samsung,pin-drv = ; > }; > > sd2_cmd: sd2-cmd { > samsung,pins = "gpk2-1"; > samsung,pin-function = ; > samsung,pin-pud = ; > - samsung,pin-drv = <4>; > + samsung,pin-drv = ; > }; > > sd2_cd: sd2-cd { > @@ -501,14 +501,14 @@ > samsung,pins = "gpk2-3"; > samsung,pin-function = ; > samsung,pin-pud = ; > - samsung,pin-drv = <4>; > + samsung,pin-drv = ; > }; > > sd2_bus4: sd2-bus-width4 { > samsung,pins = "gpk2-4", "gpk2-5", "gpk2-6"; > samsung,pin-function = ; > samsung,pin-pud = ; > - samsung,pin-drv = <4>; > + samsung,pin-drv = ; > }; > > cam_port_b_io: cam-port-b-io { Best regards, -- Bartlomiej Zolnierkiewicz Samsung R&D Institute Poland Samsung Electronics