The Linux Kernel Mailing List
 help / color / mirror / Atom feed
From: Daniel Carter <yass27106@gmail.com>
To: srinivas.kandagatla@oss.qualcomm.com
Cc: broonie@kernel.org, andersson@kernel.org, konradybcio@kernel.org,
	linux-arm-msm@vger.kernel.org, linux-sound@vger.kernel.org,
	linux-kernel@vger.kernel.org, yass27106@gmail.com
Subject: Re: [PATCH v3 3/4] ASoC: qcom: lpass macro / soundwire: asynchronous probe with clock retry
Date: Mon, 16 Nov 2026 11:30:55 -0800 (PST)	[thread overview]
Message-ID: <312911d6ca094b94b90264688aeb9df7@gmail.com> (raw)
In-Reply-To: <efa3cc40-15ff-44e2-b783-333306bc4ee4@oss.qualcomm.com>

Hi Srini,

Thanks for the review, and for the Reviewed-by on the
clk_prepare_enable() fix (Cc: stable will be added in the repost).

To answer your question about the retry patch: on the Asus Vivobook 16
X1607QA (X1P42100), the boot showed the LPASS macro and SoundWire
devices never coming up, with va_macro logging "qcom,dmic-sample-rate
dt entry missing" and the audio DAIs staying deferred. My diagnosis at
the time was that their clock providers registered late and never
triggered a deferred-probe retry, hence the retry attempt. That patch
is now dropped: following the review it became clear the driver core
does retrigger deferred-probe runs when suppliers register, so the
hack was aimed at the wrong thing. The actual fixes were in the device
tree - the missing qcom,dmic-sample-rate and vdd-micb-supply
properties on the VA macro, plus the unpopulated pmc8380_6 cluster
PMIC - which went into the current series (patch 2/3).

Best regards,
Daniel Carter

  reply	other threads:[~2026-11-16 19:30 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-13 13:24 [PATCH 0/2] qcom: add Asus Vivobook 16 X1607QA DT + LPASS audio clock retry yass27106
2026-11-13 13:24 ` [PATCH 1/2] arm64: dts: qcom: add device tree for Asus Vivobook 16 X1607QA yass27106
2026-11-13 13:24   ` [PATCH 2/2] ASoC: qcom: lpass macro / soundwire: retry deferred clock acquisition yass27106
2026-11-13 15:04     ` Mark Brown
2026-11-15 10:10     ` Srinivas Kandagatla
2026-11-13 15:44   ` [PATCH 1/2] arm64: dts: qcom: add device tree for Asus Vivobook 16 X1607QA Krzysztof Kozlowski
2026-11-13 20:33     ` [PATCH 1/2] arm64: dts: qcom: add device tree for Asus Vivobook 16 X1607QA — v2 series Daniel Carter
2026-11-13 20:33       ` [PATCH v2 1/3] dt-bindings: qcom: document Asus Vivobook 16 X1607QA Daniel Carter
2026-11-13 20:33         ` [PATCH v2 2/3] arm64: dts: qcom: add device tree for " Daniel Carter
2026-11-13 20:33           ` [PATCH v2 3/3] ASoC: qcom: lpass macro / soundwire: retry deferred clock acquisition Daniel Carter
2026-11-14  7:34         ` [PATCH v2 1/3] dt-bindings: qcom: document Asus Vivobook 16 X1607QA Krzysztof Kozlowski
2026-11-13 21:02       ` [PATCH v2 1/3] arm64: dts: qcom: add device tree for Asus Vivobook 16 X1607QA - v3 series Daniel Carter
2026-11-13 21:02         ` [PATCH v3 1/4] dt-bindings: qcom: document Asus Vivobook 16 X1607QA Daniel Carter
2026-11-13 21:02           ` [PATCH v3 2/4] arm64: dts: qcom: add device tree for " Daniel Carter
2026-11-13 21:02             ` [PATCH v3 3/4] ASoC: qcom: lpass macro / soundwire: asynchronous probe with clock retry Daniel Carter
2026-11-13 21:02               ` [PATCH v3 4/4] soundwire: qcom: check clk_prepare_enable() return values Daniel Carter
2026-11-15 10:19               ` [PATCH v3 3/4] ASoC: qcom: lpass macro / soundwire: asynchronous probe with clock retry Srinivas Kandagatla
2026-11-16 19:30                 ` Daniel Carter [this message]
2026-11-13 21:06           ` [PATCH v3 1/4] dt-bindings: qcom: document Asus Vivobook 16 X1607QA Mark Brown
2026-11-13 21:17             ` Daniel Carter
2026-11-13 21:29               ` Mark Brown
2026-11-14  7:35       ` [PATCH 1/2] arm64: dts: qcom: add device tree for Asus Vivobook 16 X1607QA — v2 series Krzysztof Kozlowski

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=312911d6ca094b94b90264688aeb9df7@gmail.com \
    --to=yass27106@gmail.com \
    --cc=andersson@kernel.org \
    --cc=broonie@kernel.org \
    --cc=konradybcio@kernel.org \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-sound@vger.kernel.org \
    --cc=srinivas.kandagatla@oss.qualcomm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox