From: <Andrei.Simion@microchip.com>
To: <krzysztof.kozlowski@linaro.org>, <robh@kernel.org>,
<krzysztof.kozlowski+dt@linaro.org>, <conor+dt@kernel.org>,
<Nicolas.Ferre@microchip.com>, <alexandre.belloni@bootlin.com>,
<claudiu.beznea@tuxon.dev>, <Mihai.Sain@microchip.com>
Cc: <linux-arm-kernel@lists.infradead.org>,
<linux-kernel@vger.kernel.org>, <devicetree@vger.kernel.org>
Subject: Re: [PATCH 1/2] ARM: boot: dts: microchip: at91-sama7g5ek: Replace regulator-suspend-voltage with the valid property
Date: Tue, 2 Apr 2024 11:27:29 +0000 [thread overview]
Message-ID: <312bed1a-0b8a-457d-a2e2-b8ee1b6f443b@microchip.com> (raw)
In-Reply-To: <34543ae2-4e78-45a4-9cff-389f7495fd4a@linaro.org>
On 02.04.2024 13:39, Krzysztof Kozlowski wrote:
> [You don't often get email from krzysztof.kozlowski@linaro.org. Learn why this is important at https://aka.ms/LearnAboutSenderIdentification ]
>
> EXTERNAL EMAIL: Do not click links or open attachments unless you know the content is safe
>
> On 02/04/2024 11:12, Andrei Simion wrote:
>> Replace regulator-suspend-voltage with regulator-suspend-microvolt.
>
> Why?
>
at91-sama7g5ek.dtb: mcp16502@5b: regulators:VDD_(CORE|OTHER)|LDO[1-2]:
regulator-state-standby 'regulator-suspend-voltage' does not match any of
the regexes 'pinctrl-[0-9]+' from schema
$id: http://devicetree.org/schemas/regulator/microchip,mcp16502.yaml#
no property named regulator-suspend-voltage in
https://github.com/torvalds/linux/blob/master/Documentation/devicetree/bindings/regulator/regulator.yaml
so if it is using this property there will be no effect as it was expected in
https://github.com/torvalds/linux/commit/85b1304b9daa06367139b471789c7ddb76250b9f
> Please explain what is the bug and how it manifests itself. Is one
> property incorrect and other correct?
>
The main reason is explained in the cover-letter but if you ask me to explain in each commit I will do it in next version.
> Please use subject prefixes matching the subsystem. You can get them for
> example with `git log --oneline -- DIRECTORY_OR_FILE` on the directory
> your patch is touching.
> Hint: there is no "boot"
>
Yes, in hurry I slipped that "boot" in subject.
>>
>
> Best regards,
> Krzysztof
>
--
Andrei Simion
next prev parent reply other threads:[~2024-04-02 11:27 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-02 9:12 [PATCH 0/2] Fix the regulator-state-standby definition Andrei Simion
2024-04-02 9:12 ` [PATCH 1/2] ARM: boot: dts: microchip: at91-sama7g5ek: Replace regulator-suspend-voltage with the valid property Andrei Simion
2024-04-02 10:39 ` Krzysztof Kozlowski
2024-04-02 11:27 ` Andrei.Simion [this message]
2024-04-02 12:07 ` Krzysztof Kozlowski
2024-04-02 9:12 ` [PATCH 2/2] ARM: boot: dts: microchip: at91-sama7g54_curiosity: " Andrei Simion
2024-04-02 10:18 ` [PATCH 0/2] Fix the regulator-state-standby definition Nicolas Ferre
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=312bed1a-0b8a-457d-a2e2-b8ee1b6f443b@microchip.com \
--to=andrei.simion@microchip.com \
--cc=Mihai.Sain@microchip.com \
--cc=Nicolas.Ferre@microchip.com \
--cc=alexandre.belloni@bootlin.com \
--cc=claudiu.beznea@tuxon.dev \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=krzysztof.kozlowski@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox