From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753334AbbG0LPO (ORCPT ); Mon, 27 Jul 2015 07:15:14 -0400 Received: from mailout3.samsung.com ([203.254.224.33]:56923 "EHLO mailout3.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752286AbbG0LPL (ORCPT ); Mon, 27 Jul 2015 07:15:11 -0400 X-AuditID: cbfee61a-f79a06d000005c6f-7e-55b612bca5b9 From: Bartlomiej Zolnierkiewicz To: Viresh Kumar Cc: Thomas Abraham , Sylwester Nawrocki , Michael Turquette , Kukjin Kim , Kukjin Kim , Krzysztof Kozlowski , Tomasz Figa , Lukasz Majewski , Heiko Stuebner , Chanwoo Choi , Kevin Hilman , Javier Martinez Canillas , Tobias Jakobi , Anand Moon , linux-samsung-soc@vger.kernel.org, linux-clk@vger.kernel.org, linux-pm@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 2/7] cpufreq: opp: fix handling of turbo modes Date: Mon, 27 Jul 2015 13:14:34 +0200 Message-id: <3141301.RS9TLygaba@amdc1976> User-Agent: KMail/4.13.3 (Linux/3.13.0-57-generic; KDE/4.13.3; x86_64; ; ) In-reply-to: <20150727103521.GA4103@linux> References: <1436456621-29839-1-git-send-email-b.zolnierkie@samsung.com> <1595601.YD6UTxy5Qg@amdc1976> <20150727103521.GA4103@linux> MIME-version: 1.0 Content-transfer-encoding: 7Bit Content-type: text/plain; charset=us-ascii X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFtrCIsWRmVeSWpSXmKPExsVy+t9jAd09QttCDZ4/EbS4/uU5q8X/R69Z La79nsFm8fqFoUXvgqtsFv2PXzNbfD28gtHizcPNjBabHl9jtfjYc4/V4vKuOWwWn3uPMFrM OL+PyWLdxlvsFhdPuVocftPOatGxjNGibfUHVotVu/4wWmz86uEg4vH+Riu7x9/ZrcweO2fd ZffYtKqTzePOtT1sHpuX1Hv8O8bu0bdlFaPH9mvzmD0+b5IL4IrisklJzcksSy3St0vgyphy dhVLwVTuij9rjzI2MH7j6GLk5JAQMJG48fYCI4QtJnHh3nq2LkYuDiGBpYwSl1d0sEM4Xxkl LuyZwg5SxSZgJTGxfRVQBweHiICWxMubqSA1zALPWSXuP9vMBlIjLOAqserFXhYQm0VAVeLs ilnMIDavgKbEysatYHFRAS+J778awOKcQHN6OydCbW5jlFiz/QVUg6DEj8n3wBqYBeQl9u2f ygpha0ms33mcaQKjwCwkZbOQlM1CUraAkXkVo0RqQXJBcVJ6rmFearlecWJucWleul5yfu4m RnBcPpPawXhwl/shRgEORiUe3gsqW0OFWBPLiitzDzFKcDArifA+jgIK8aYkVlalFuXHF5Xm pBYfYpTmYFES55XdsDlUSCA9sSQ1OzW1ILUIJsvEwSnVwLgr5Sj/1Zyj6vMYt1kE7Q0U3G80 tVRTzUHeKCgmb9LU3TV5N/Z82h7/v1z1U6DRowW8kw0k3eq5XF/vPFr2c//vY1Hiiz5urigv 3SS67bPpkfo6B5nfFQn1agc255o28c/4d7Pp0vsjLw/U5uipL3l17Vyu+SU9LQOHn//XLTJX /6zxqU5R45sSS3FGoqEWc1FxIgC0yhCDxwIAAA== Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi, On Monday, July 27, 2015 04:05:21 PM Viresh Kumar wrote: > On 27-07-15, 12:24, Bartlomiej Zolnierkiewicz wrote: > > Have you read my explanation of the issue? > > > > With your OPP-v2 patches cpufreq-dt picks turbo frequencies and uses > > them as normal ones. > > > > (More at: http://www.spinics.net/lists/arm-kernel/msg430397.html) > > Yes I did. I understand that the turbo frequencies are not considered > as such by OPP/cpufreq core and it requires your changes to get it > working. Sorry but you don't seem to understand the issue. The problem is that without my patch and with your OPP-v2 patches turbo frequencies get picked by OPP/cpufreq core and then by cpufreq-dt. This happens without enabling any boost & thermal etc. support for turbo frequencies. > But its not an issue or bug we are fixing, the problem is that the > code for opp-v2 isn't complete yet and your patches is putting things > in place. So, we are still doing the bring up here and not fixing a > bug really. I consider the possibility to use turbo frequencies without explicitly enabling boost support to be a buggy behavior. While it is unlikely that somebody defines turbo frequencies in their dts file in the near future (except Exynos ones) it costs as nearly nothing to prevent such behavior now. Best regards, -- Bartlomiej Zolnierkiewicz Samsung R&D Institute Poland Samsung Electronics