Announce: modutils 2.3.23 is available

Announce: modutils 2.3.23 is available

[Keith Owens]

ftp://ftp.<country>.kernel.org/pub/linux/utils/kernel/modutils/v2.3

patch-modutils-2.3.23.gz        Patch from modutils 2.3.22 to 2.3.23
modutils-2.3.23.tar.gz          Source tarball, includes RPM spec file
modutils-2.3.23-1.src.rpm       As above, in SRPM format
modutils-2.3.23-1.i386.rpm      Compiled with egcs-2.91.66, glibc 2.1.2
modutils-2.3.23-1.sparc.rpm     Compiled for combined sparc 32/64
patch-2.4.0-test13-pre2.gz	Adds persistent data and generic string
				support to kernel 2.4.0-test13-pre2.

Changelog extract

	* Correct error path in rmmod.c.  Andrew Morton.
	* Include latest Redhat alias list.  Bill Nottingham.
	* hppa and hppa64 support.  Richard Hirst.
	* Rework Makefiles for common 32/64 code.  Keith Owens.
	* Add parportmap.  Adam J Richter, Keith Owens.
	* Use GNU standards for cross compile.  Maciej W. Rozycki.
	* Fix bound check on generic_string.  Bug reported by Jaroslav Kysela,
	  different patch by Keith Owens.
	* Warn instead of error for invalid MODULE_PARM.  Keith Owens.

Notes:

(1) Persistent data is not on by default, you must run insmod with -e
    to support persistent data.  If you are loading modules via
    modprobe and you want persistent data for all modules then you need

      insmod_opt -e ""

    in /etc/modules.conf.

(2) Current kernels do not support persistent data nor generic strings.
    You must apply patch-2.4.0-test13-pre2 to get kernel support for
    these features.

(3) No modules currently have persistent data.  Module writers who
    want data to be persistent must make a one character change to
    their modules, read the above patch.  Even then, the user must
    activate the persistent data, see note (1).

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
Please read the FAQ at http://www.tux.org/lkml/

Re: Announce: modutils 2.3.23 is available

[Keith Owens]

modutils 2.3.23 has a bug with empty MODULE_GENERIC_STRING entries,
depmod loops.

Index: 23.11/depmod/depmod.c
--- 23.11/depmod/depmod.c Sun, 17 Dec 2000 10:18:04 +1100 kaos (modutils-2.3/b/43_depmod.c 1.39 644)
+++ 23.11(w)/depmod/depmod.c Wed, 20 Dec 2000 08:13:18 +1100 kaos (modutils-2.3/b/43_depmod.c 1.39 644)
@@ -388,9 +388,8 @@ static void extract_generic_string(struc
 			error("unterminated generic string '%*s'", p - s, s);
 			break;
 		}
-		if (p == s)		/* empty string? */
+		if (p++ == s)		/* empty string? */
 			continue;
-		p++;	/* step over NUL */
 		mod->generic_string = xrealloc(mod->generic_string, ++(mod->n_generic_string)*sizeof(*(mod->generic_string)));
 		latest = mod->generic_string + mod->n_generic_string-1;
 		*latest = xstrdup(s);

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
Please read the FAQ at http://www.tux.org/lkml/

Re: Announce: modutils 2.3.23 is available

[Christian Gennerat]

About Standard aliases:
> modprobe -c
...
alias ppp-compress-21 bsd_comp
...

Why bsd_comp is the standard alias?
/src/linux/Configure.help says that

The PPP Deflate compression method ("PPP Deflate compression",
  above) is preferable to BSD-Compress, because it compresses better
  and is patent-free.


-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
Please read the FAQ at http://www.tux.org/lkml/

Re: Announce: modutils 2.3.23 is available

[Nicholas Miell]

Christian Gennerat wrote:
> 
> About Standard aliases:
> > modprobe -c
> ...
> alias ppp-compress-21 bsd_comp
> ...
> 
> Why bsd_comp is the standard alias?
> /src/linux/Configure.help says that
> 
> The PPP Deflate compression method ("PPP Deflate compression",
>   above) is preferable to BSD-Compress, because it compresses better
>   and is patent-free.
> 

ppp-compress-21 refers to PPP compression method 21, which happens to
be BSD Compress. Deflate is 26 (and also 24, because it was assigned
that
value in the draft RFC).

Aliasing ppp-compress-21 to anything other than bsd_comp would break
PPP.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
Please read the FAQ at http://www.tux.org/lkml/

Re: Announce: modutils 2.3.23 is available

[Keith Owens]

On Wed, 20 Dec 2000 10:31:12 +0100, 
Christian Gennerat <christian.gennerat@vz.cit.alcatel.fr> wrote:
>About Standard aliases:
>> modprobe -c
>...
>alias ppp-compress-21 bsd_comp
>...
>
>Why bsd_comp is the standard alias?

You should also have
alias ppp-compress-24 ppp_deflate
alias ppp-compress-26 ppp_deflate

The number is the CPP option that was requested by pppd, which
compression option is used is controlled by userspaqce, not the kernel.

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
Please read the FAQ at http://www.tux.org/lkml/