From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752877AbbCKVsU (ORCPT ); Wed, 11 Mar 2015 17:48:20 -0400 Received: from mout.kundenserver.de ([212.227.17.10]:52387 "EHLO mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751349AbbCKVsQ (ORCPT ); Wed, 11 Mar 2015 17:48:16 -0400 From: Arnd Bergmann To: Arun Ramamurthy Cc: linux-arm-kernel@lists.infradead.org, Alan Stern , Mark Rutland , devicetree@vger.kernel.org, Scott Branden , Pawel Moll , Ian Campbell , Ray Jui , linux-kernel@vger.kernel.org, Kishon Vijay Abraham I , Jonathan Richardson , Rob Herring , bcm-kernel-feedback-list@broadcom.com, Dmitry Torokhov , Kumar Gala , Anatol Pomazau Subject: Re: [PATCH 1/2] phy: usbphy: Add dt documentation for Broadcom Cygnus USB PHY driver Date: Wed, 11 Mar 2015 22:47:30 +0100 Message-ID: <3142298.YeoA7WAayD@wuerfel> User-Agent: KMail/4.11.5 (Linux/3.16.0-10-generic; KDE/4.11.5; x86_64; ; ) In-Reply-To: <5500B5B6.50609@broadcom.com> References: <1424200821-16368-1-git-send-email-arun.ramamurthy@broadcom.com> <2079271.sEacVGN4vm@wuerfel> <5500B5B6.50609@broadcom.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" X-Provags-ID: V03:K0:7yXHw5/EisOMDUTLouyzfF8kzGwzYbdo4tRd4TonrDjE9m6QWNJ gnyxA05xrt3qSJehl8PepxXdzWGGZ09dIIjzsHp4kexMCKcsd30SZzziHqFIdtFhEu79NYe RZDVPuAqWs1K8D56mw7TfiLAwP3XXyBmCoWIRAMh2etn+iI05veiFa10Cd/hh39MqhpCc9k Ynw4/QW9BSlAogje+H9Zw== X-UI-Out-Filterresults: notjunk:1; Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wednesday 11 March 2015 14:37:58 Arun Ramamurthy wrote: > On 15-03-10 01:27 PM, Arnd Bergmann wrote: > > On Wednesday 25 February 2015 16:24:06 Arun Ramamurthy wrote: > >>>>> Should I run this by Alan Stern? > >>>> > >>>> I've added him to Cc here. He clearly didn't know the background about > >>>> the DT binding change, and should not need to, but he may have an opinion > >>>> on what names we should use. > >>>> > >>> > >> Arnd, should I re patch the ehci-platform driver to avoid phy-names > >> entirely? Alan, if not do you have an opinion on what the usb phy names > >> should be? The current patch uses "usbp" + port number such as "usbp0" , > >> "usbp1" etc > > > > I think avoiding the phy names would be best here, but it requires a > > kernel API change first, because we do not have a way to get a phy > > by index as we do for other subsystems (e.g. clocks or gpios). > > > Arnd , there is an existing api _of_phy_get that gets a phy by index. > However it is not exported and is called from of_phy_get which is in > turn called from devm_of_phy_get. > > My plan is to create a new function maybe devm_of_phy_get_by_index that > calls _of_phy_get directly? What are your thoughts? Sounds good to me. Arnd