From: Chris Mason <mason@suse.com>
To: linux-kernel@vger.kernel.org
Cc: torvalds@transmeta.com, alan@redhat.com, zam@namesys.botik.ru
Subject: [PATCH] reiserfs transaction overflow
Date: Wed, 18 Apr 2001 16:52:44 -0400 [thread overview]
Message-ID: <315290000.987627164@tiny> (raw)
Hi guys,
Under certain loads, the reiserfs journal can overflow the
max transaction size, leading to a crash (but not corruption).
When the transaction is too full for another writer to join,
the writer triggers a commit, and waits for the next transaction.
But, it doesn't properly check to make sure the next transcation
has enough room, which can lead to overflow. It is hard to
hit because there is a large margin of error in the way log space
is reserved (this bug was probably in v.00001 of the journal
code).
A similar patch will be needed for 3.5.x reiserfs, that will
follow soon.
Anyway, this patch should fix 2.4.x, please apply:
-chris
--- linux/fs/reiserfs/journal.c.1 Tue Apr 17 09:36:36 2001
+++ linux/fs/reiserfs/journal.c Tue Apr 17 09:37:50 2001
@@ -2052,7 +2052,7 @@
sleep_on(&(SB_JOURNAL(p_s_sb)->j_join_wait)) ;
}
}
- lock_journal(p_s_sb) ; /* relock to continue */
+ goto relock ;
}
if (SB_JOURNAL(p_s_sb)->j_trans_start_time == 0) { /* we are the first writer, set trans_id */
reply other threads:[~2001-04-18 20:53 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=315290000.987627164@tiny \
--to=mason@suse.com \
--cc=alan@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=torvalds@transmeta.com \
--cc=zam@namesys.botik.ru \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox