From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1762515AbcINN4w (ORCPT ); Wed, 14 Sep 2016 09:56:52 -0400 Received: from mout.kundenserver.de ([212.227.126.130]:50438 "EHLO mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1762448AbcINN4u (ORCPT ); Wed, 14 Sep 2016 09:56:50 -0400 From: Arnd Bergmann To: Thomas Gleixner Cc: Lee Jones , "Andrew F. Davis" , Marc Zyngier , Daniel Lezcano , linux-kernel@vger.kernel.org, Marcin Niestroj , Grygorii Strashko , Tony Lindgren Subject: Re: [PATCH] [RFC] irqchip or mfd/tps65217: fix link error Date: Wed, 14 Sep 2016 15:56:35 +0200 Message-ID: <3153379.K6IZxfs9ll@wuerfel> User-Agent: KMail/5.1.3 (Linux/4.4.0-34-generic; KDE/5.18.0; x86_64; ; ) In-Reply-To: References: <20160914084202.1032264-1-arnd@arndb.de> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" X-Provags-ID: V03:K0:iJFIAZg40B/wUU4enBpBZV2l4etjBWRLPJ7RNefDEYfL+XPQ/jW vrFEOSNCcVvwy5pRTmI1+gLcX13lqcmReIinfqeqsiy4Fnw5hsa8+o4u3qmMWSNPQGjM/Rv /nqmG0RM/zR9xzPjncfAQlegQ9gEl2VFTfvtfYxq0MXKmqzc+mVZH8SgEJc2ok8FgM3u16+ XvjJdCf2YqbhWaBBsxogg== X-UI-Out-Filterresults: notjunk:1;V01:K0:fRYBN4SAxcU=:omTzknUhkaiQR4dD3Hr5sS 6ZQb2cz/Ls84LJ5h5z3uEkh+ISvdbmFHjfSKTLFaA/1npXcuKR/nI8+Vu8BgJjZy9b24Z0t8J 8+tbFN2LEavG3jv939Ni00V5DYNgwjNQGYjhxJr0zdXN4uHWgBiMa2pO8ZuCwhZFgSW1uZfK8 9TNXxgWbUbDDGB4kzurI4KxCxmzljZM2qcjwrxmpL74O8E3JnIfC8F4IsNd6HMdXGrhWRKidY NHI7uofgrZ7xXe477ohG+3py/gkgP2ObIK9As/tYECht6/+qeZfqOgEPzrtnWNSW40/SqW+RY qRBuDt0cFj5V+ijbot8jgIbGCbyMLzUR2rTT+fdJwDjsPLq+yTXycZhpw0ZowNTzFP0dSnD3G nmGy/Jrz+7EOgiktkbJa10bvgGd5yHXXWspyfLpLROgdAQlQFfH+MvcQD6wdCiAIKRS88zGx7 lbxGMq9MlOP2Bo1TJ7tZbolsTIXmQtxk2tide37Qc68pdbwjF79hlcxj5y3cT/H9SNCl0oQmv 8SV0K6plI/14p6zFgagOAOPq3+HrS7JTi9GiBNLOhifcjYinFeAhP6A9PxvLRDvA32QwVc/U8 PRsRwHWHWRpol3tGz3l4ZxaVDSTyT3KjLK1NB+BxgChP1xfxaivjQtWL06MT4wirfezv6R84g 38vWz67eMksWelo0yV1jiPFsLrDh5QUijh0bDjCnQb8zfucMf6ZGvLHySYSexY6JL0hXyS6fl ovmDCMZXCv1k47e2 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wednesday, September 14, 2016 11:31:17 AM CEST Thomas Gleixner wrote: > On Wed, 14 Sep 2016, Arnd Bergmann wrote: > > Building tps65217 as a loadable module (as done in allmodconfig) > > now fails after we started calling irq_set_parent(): > > > > ERROR: "irq_set_parent" [drivers/mfd/tps65217.ko] undefined! > > > > The two obvious workarounds are either to force the driver > > to be built-in, or to make that symbol exported to modules. > > > > As it's not clear to me if either of them would be acceptable, > > I'm sending both of them here, please comment on which one > > you want to have, or whether the driver should handle this > > differently and not call irq_set_parent() at all. > > The question is why it needs to call that. But if it's justified, then I'm > not opposed to export it. Ok. I just noticed that I forgot to put the right people on Cc that worked on the patch originally, fixed that now. My other approach of making the symbol "bool" in the meantime has caused another problem when CONFIG_I2C=m: drivers/mfd/tps65217.o: In function `tps65217_init': tps65217.c:(.init.text+0x8): undefined reference to `i2c_register_driver' drivers/mfd/tps65217.o: In function `tps65217_probe': tps65217.c:(.text.tps65217_probe+0x94): undefined reference to `__devm_regmap_init_i2c' so the dependency would be "depends on I2C=y", getting increasingly ugly. I'll let Marcin or Grygorii reply on why the call is needed, we can then either export the symbol or change the code. Arnd