From: David Howells <dhowells@redhat.com>
To: Stefan Richter <stefanr@s5r6.in-berlin.de>
Cc: dhowells@redhat.com, linux-kernel@vger.kernel.org
Subject: Re: On patch "Remove all #inclusions of asm/system.h"
Date: Sat, 31 Mar 2012 20:31:33 +0100 [thread overview]
Message-ID: <31597.1333222293@redhat.com> (raw)
In-Reply-To: <20120329153409.7295eda9@stein>
Stefan Richter <stefanr@s5r6.in-berlin.de> wrote:
> commit 9ffc93f2 "Remove all #inclusions of asm/system.h" removes a lot of
> includes while its parent commit 96f951ed "Add #includes needed to permit
> the removal of asm/system.h" adds only a few. Some of the files modified
> by commit 9ffc93f2 now only work due to indirect inclusion, don't they?
>
> For example, drivers/firewire/{core-device,core-topology,ohci,sbp2}.c use
> smp_rmb()¹ and used to include asm/system.h. Now they do not include
> asm/barrier.h. Is this by mistake or on purpose?
I tried to make sure allyesconfig worked for x86_64 and a bunch of defconfigs
worked. I can't guarantee that that got 100% coverage. I also knew there
would be some breakage from the base Linux kernel having moved on by the time
Linus pulled myu patches - though I don't know if this is the case here (I
suspect not).
David
next prev parent reply other threads:[~2012-03-31 19:31 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-03-29 13:34 On patch "Remove all #inclusions of asm/system.h" Stefan Richter
2012-03-31 19:31 ` David Howells [this message]
2012-03-31 20:44 ` Stefan Richter
2012-04-01 1:46 ` David Howells
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=31597.1333222293@redhat.com \
--to=dhowells@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=stefanr@s5r6.in-berlin.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox