public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: "Rafael J. Wysocki" <rjw@rjwysocki.net>
To: Linux ACPI <linux-acpi@vger.kernel.org>,
	Maximilian Luz <luzmaximilian@gmail.com>
Cc: LKML <linux-kernel@vger.kernel.org>,
	Hans de Goede <hdegoede@redhat.com>,
	Mark Gross <mgross@linux.intel.com>,
	platform-driver-x86@vger.kernel.org
Subject: [PATCH v3 5/7] surface: surface3_power: Drop redundant acpi_bus_get_device() call
Date: Wed, 13 Oct 2021 18:12:31 +0200	[thread overview]
Message-ID: <3160001.aeNJFYEL58@kreacher> (raw)
In-Reply-To: <2503491.Lt9SDvczpP@kreacher>

From: Rafael J. Wysocki <rafael.j.wysocki@intel.com>

If the ACPI companion of a given device is not present, the result
of the ACPI_HANDLE() evaluation for it will be NULL, so calling
acpi_bus_get_device() on ACPI_HANDLE() result in order to validate
it is redundant.

Drop the redundant acpi_bus_get_device() call from mshw0011_notify()
along with a local variable related to it.

No intentional functional impact.

Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
Reviewed-by: Maximilian Luz <luzmaximilian@gmail.com>
---

v2 -> v3:
   * Resend with a different From and S-o-b address and with R-by from
     Maximilian.  No other changes.

---
 drivers/platform/surface/surface3_power.c |    3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

Index: linux-pm/drivers/platform/surface/surface3_power.c
===================================================================
--- linux-pm.orig/drivers/platform/surface/surface3_power.c
+++ linux-pm/drivers/platform/surface/surface3_power.c
@@ -159,12 +159,11 @@ mshw0011_notify(struct mshw0011_data *cd
 		unsigned int *ret_value)
 {
 	union acpi_object *obj;
-	struct acpi_device *adev;
 	acpi_handle handle;
 	unsigned int i;
 
 	handle = ACPI_HANDLE(&cdata->adp1->dev);
-	if (!handle || acpi_bus_get_device(handle, &adev))
+	if (!handle)
 		return -ENODEV;
 
 	obj = acpi_evaluate_dsm_typed(handle, &mshw0011_guid, arg1, arg2, NULL,




  parent reply	other threads:[~2021-10-13 16:16 UTC|newest]

Thread overview: 28+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-10-12 17:35 [PATCH v1 0/7] ACPI: Use ACPI_COMPANION() directly to simplify code Rafael J. Wysocki
2021-10-12 17:44 ` [PATCH v1 1/7] gpio-amdpt: ACPI: Use the ACPI_COMPANION() macro directly Rafael J. Wysocki
2021-10-13 14:44   ` Bartosz Golaszewski
2021-10-13 16:06   ` [PATCH v2 " Rafael J. Wysocki
2021-10-12 17:44 ` [PATCH v1 2/7] nouveau: " Rafael J. Wysocki
2021-10-12 22:04   ` Ben Skeggs
2021-10-13 16:08   ` [PATCH v2 " Rafael J. Wysocki
2021-10-12 17:44 ` [PATCH v1 3/7] i2c: i2c-amd-mp2-plat: ACPI: Use ACPI_COMPANION() directly Rafael J. Wysocki
2021-10-12 18:12   ` Shyam Sundar S K
2021-10-13 16:09   ` [PATCH v2 " Rafael J. Wysocki
2021-10-17 14:22     ` Wolfram Sang
2021-10-12 17:44 ` [PATCH v1 4/7] surface: surface3-wmi: " Rafael J. Wysocki
2021-10-12 18:13   ` Maximilian Luz
2021-10-13 16:10   ` [PATCH v2 " Rafael J. Wysocki
2021-10-19 14:56     ` Hans de Goede
2021-10-12 17:46 ` [PATCH v1 5/7] surface: surface3_power: " Rafael J. Wysocki
2021-10-12 18:21   ` Maximilian Luz
2021-10-12 19:11     ` Rafael J. Wysocki
2021-10-12 19:32   ` [PATCH v2 5/7] surface: surface3_power: Drop redundant acpi_bus_get_device() call Rafael J. Wysocki
2021-10-12 19:40     ` Maximilian Luz
2021-10-13 16:12     ` Rafael J. Wysocki [this message]
2021-10-19 14:56       ` [PATCH v3 " Hans de Goede
2021-10-12 17:48 ` [PATCH v1 6/7] platform: x86: ideapad-laptop: Use ACPI_COMPANION() directly Rafael J. Wysocki
2021-10-13 16:13   ` [PATCH v2 " Rafael J. Wysocki
2021-10-19 14:57     ` Hans de Goede
2021-10-12 17:50 ` [PATCH v1 7/7] perf: qcom_l2_pmu: ACPI: " Rafael J. Wysocki
2021-10-13 16:15   ` [PATCH v2 " Rafael J. Wysocki
2021-10-26 13:41     ` Rafael J. Wysocki

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=3160001.aeNJFYEL58@kreacher \
    --to=rjw@rjwysocki.net \
    --cc=hdegoede@redhat.com \
    --cc=linux-acpi@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=luzmaximilian@gmail.com \
    --cc=mgross@linux.intel.com \
    --cc=platform-driver-x86@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox