From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752410AbcFBHqM (ORCPT ); Thu, 2 Jun 2016 03:46:12 -0400 Received: from mout.kundenserver.de ([217.72.192.73]:60489 "EHLO mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751721AbcFBHqL (ORCPT ); Thu, 2 Jun 2016 03:46:11 -0400 From: Arnd Bergmann To: Binoy Jayan Cc: Greg Kroah-Hartman , devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 4/4] rtl8192u: Replace semaphore rf_sem with mutex Date: Thu, 02 Jun 2016 09:46:45 +0200 Message-ID: <3160394.ryVW7iLUlP@wuerfel> User-Agent: KMail/5.1.3 (Linux/4.4.0-22-generic; KDE/5.18.0; x86_64; ; ) In-Reply-To: <1464843475-4870-5-git-send-email-binoy.jayan@linaro.org> References: <1464843475-4870-1-git-send-email-binoy.jayan@linaro.org> <1464843475-4870-5-git-send-email-binoy.jayan@linaro.org> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" X-Provags-ID: V03:K0:HNtHtuYAUUlrN465BuLvQUjCfFe9LsstUBQ9XAOmiyg++yQC+qS KSv2rMzJ05eTX7Fv9SGp1QrhpHs6wArPnorJCTQUyhAGjVGTSvrbPwUyZkxFWqXYF9Y4gfn 6VtGuLdWBR0J1G1r84uKtGC8wChzk5cktcQuynTcahGMSfgYCqy7EaA9rvfjg/GlDNY2CUD N0D2T/ksLZiFdsmCUDNWQ== X-UI-Out-Filterresults: notjunk:1;V01:K0:j8Rwcp3pTx8=:fs8/uyOe8PeWwzJRtqsUqU S4uShrK53ZQBqfQXQ5TwLmWBa4folMP+mO5kQtdVkUaeOMIs5wNHwJvHxzSuXP1UrXFw1NBCF 2+UY6EQM+BLlPq+/9satmrZsCR9JGFBLAyWtA/llo+Tna3S12jZU6eRyVdpAVsheTo5p4qNAC UffV4pzzNOeQGmiLlXJ63JGdbFtKcAYv3lqoxI+7GKtKQVzMnZlO6dcbMNy8KUGv6En30LD1h D/YrkJ9U3cydtZQ82pUdHDy8OU10mQpbHt7IlNZ5g2OEbGxWQJO+b94p+XUjsI/FDeNOfzJvI ror8PpgSE4f3peqV9KSN7oXUua5SzWp/N7D3QFDJ6iwdly4VJ+0kBCgP5WezpgQtCsk0iCfBJ VpCBtQpqskuDWTPJg/R5CxuGcxzM0b/I23hzcaqII6XoTDRYiu99UgcArmlGraXJDfvHY0VVI YpU1UGcpF1p5iGIA7Kyt0DtzmXqdJ+6fyocGOaPXQY6YehbRcBHUIcsy4kjCoKQgKMdN/9+R5 t97jyJ+PnlLp+2hQOiH03tvV73+mTeQQ5hnrO8Ml8176or5g5shpcyDi+aQaCyNQG0ggR/CfA JjXPSyhpLy9fON/S0I34ynZANQv5trYRmH4k1DsCT7WjRuBmEy2t5ULIwtczgdcrQgYuNs6fP PdbbWjlEHuRQp9+E7mYLbACa+Jl9wZDojjrMOiRLegZpF3zR73k6dplmIPJ5qITPLHiilVIMa rSZTnMjknMI2IQGE Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thursday, June 2, 2016 10:27:55 AM CEST Binoy Jayan wrote: > diff --git a/drivers/staging/rtl8192u/r8192U.h b/drivers/staging/rtl8192u/r8192U.h > index 2780838..7b921d4 100644 > --- a/drivers/staging/rtl8192u/r8192U.h > +++ b/drivers/staging/rtl8192u/r8192U.h > @@ -880,7 +880,7 @@ typedef struct r8192_priv { > short crcmon; > > struct mutex wx_mutex; > - struct semaphore rf_sem; /* Used to lock rf write operation */ > + struct mutex rf_mutex; /* Used to lock rf write operation */ > > u8 rf_type; /* 0: 1T2R, 1: 2T4R */ > RT_RF_TYPE_819xU rf_chip; > diff --git a/drivers/staging/rtl8192u/r8192U_core.c b/drivers/staging/rtl8192u/r8192U_core.c > index c6d3119..46d613a 100644 > --- a/drivers/staging/rtl8192u/r8192U_core.c > +++ b/drivers/staging/rtl8192u/r8192U_core.c > @@ -2374,7 +2374,7 @@ static void rtl8192_init_priv_lock(struct r8192_priv *priv) > spin_lock_init(&priv->tx_lock); > spin_lock_init(&priv->irq_lock); > mutex_init(&priv->wx_mutex); > - sema_init(&priv->rf_sem, 1); > + mutex_init(&priv->rf_mutex); > mutex_init(&priv->mutex); > } I think this one should be done differently: as there are obviously no users of this semaphore, there is no need to replace it with a mutex, it should just be removed entirely. Arnd