* 2.6.7-mm2 build failure
@ 2004-06-24 14:43 Martin J. Bligh
0 siblings, 0 replies; 3+ messages in thread
From: Martin J. Bligh @ 2004-06-24 14:43 UTC (permalink / raw)
To: Andrew Morton; +Cc: linux-kernel
drivers/base/node.c: In function `node_read_meminfo':
drivers/base/node.c:56: warning: implicit declaration of function `hugetlb_report_node_meminfo'
drivers/built-in.o(.text+0x1f615): In function `node_read_meminfo':
: undefined reference to `hugetlb_report_node_meminfo'
make: *** [.tmp_vmlinux1] Error 1
Hmmm. I wonder if anyone tested that patch ;-)
M.
^ permalink raw reply [flat|nested] 3+ messages in thread
* RE: 2.6.7-mm2 build failure
[not found] <20040624115640.5f01ce20.akpm@osdl.org>
@ 2004-06-24 19:10 ` Chen, Kenneth W
2004-06-24 20:35 ` Martin J. Bligh
0 siblings, 1 reply; 3+ messages in thread
From: Chen, Kenneth W @ 2004-06-24 19:10 UTC (permalink / raw)
To: 'Andrew Morton'; +Cc: linux-kernel
> Begin forwarded message:
>
> Date: Thu, 24 Jun 2004 07:43:58 -0700
> From: "Martin J. Bligh" <mbligh@aracnet.com>
> To: Andrew Morton <akpm@osdl.org>
> Cc: linux-kernel <linux-kernel@vger.kernel.org>
> Subject: 2.6.7-mm2 build failure
>
>
> drivers/base/node.c: In function `node_read_meminfo':
> drivers/base/node.c:56: warning: implicit declaration of function
> `hugetlb_report_node_meminfo'
> drivers/built-in.o(.text+0x1f615): In function `node_read_meminfo':
> : undefined reference to `hugetlb_report_node_meminfo'
> make: *** [.tmp_vmlinux1] Error 1
>
> Hmmm. I wonder if anyone tested that patch ;-)
>
Sorry, missing a #include. Tested with/without hugetlb config'ed. Previous
patch was tested with hugetlb page configured.
diff -Nur linux-2.6.7.orig/drivers/base/node.c linux-2.6.7/drivers/base/node.c
--- linux-2.6.7.orig/drivers/base/node.c 2004-06-15 22:18:59.000000000 -0700
+++ linux-2.6.7/drivers/base/node.c 2004-06-24 12:01:48.000000000 -0700
@@ -7,6 +7,7 @@
#include <linux/init.h>
#include <linux/mm.h>
#include <linux/node.h>
+#include <linux/hugetlb.h>
#include <linux/cpumask.h>
#include <linux/topology.h>
^ permalink raw reply [flat|nested] 3+ messages in thread
* RE: 2.6.7-mm2 build failure
2004-06-24 19:10 ` 2.6.7-mm2 build failure Chen, Kenneth W
@ 2004-06-24 20:35 ` Martin J. Bligh
0 siblings, 0 replies; 3+ messages in thread
From: Martin J. Bligh @ 2004-06-24 20:35 UTC (permalink / raw)
To: Chen, Kenneth W, 'Andrew Morton'; +Cc: linux-kernel
>> drivers/base/node.c: In function `node_read_meminfo':
>> drivers/base/node.c:56: warning: implicit declaration of function
>> `hugetlb_report_node_meminfo'
>> drivers/built-in.o(.text+0x1f615): In function `node_read_meminfo':
>> : undefined reference to `hugetlb_report_node_meminfo'
>> make: *** [.tmp_vmlinux1] Error 1
>>
>> Hmmm. I wonder if anyone tested that patch ;-)
>>
>
> Sorry, missing a #include. Tested with/without hugetlb config'ed. Previous
> patch was tested with hugetlb page configured.
>
>
> diff -Nur linux-2.6.7.orig/drivers/base/node.c linux-2.6.7/drivers/base/node.c
> --- linux-2.6.7.orig/drivers/base/node.c 2004-06-15 22:18:59.000000000 -0700
> +++ linux-2.6.7/drivers/base/node.c 2004-06-24 12:01:48.000000000 -0700
> @@ -7,6 +7,7 @@
> #include <linux/init.h>
> #include <linux/mm.h>
> #include <linux/node.h>
> +#include <linux/hugetlb.h>
> #include <linux/cpumask.h>
> #include <linux/topology.h>
Thanks, that fixed it ...
M.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2004-06-24 20:37 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <20040624115640.5f01ce20.akpm@osdl.org>
2004-06-24 19:10 ` 2.6.7-mm2 build failure Chen, Kenneth W
2004-06-24 20:35 ` Martin J. Bligh
2004-06-24 14:43 Martin J. Bligh
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox