From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1033383AbdAFTcN (ORCPT ); Fri, 6 Jan 2017 14:32:13 -0500 Received: from gloria.sntech.de ([95.129.55.99]:55697 "EHLO gloria.sntech.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1033286AbdAFTcJ (ORCPT ); Fri, 6 Jan 2017 14:32:09 -0500 From: Heiko Stuebner To: Douglas Anderson Cc: linux-rockchip@lists.infradead.org, mturquette@baylibre.com, sboyd@codeaurora.org, linux-clk@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] clk: rockchip: Remove useless init of "grf" to -EPROBE_DEFER Date: Fri, 06 Jan 2017 20:32:02 +0100 Message-ID: <3165407.VSLAtN8Q2L@phil> User-Agent: KMail/5.2.3 (Linux/4.8.0-2-amd64; KDE/5.27.0; x86_64; ; ) In-Reply-To: <20170106163101.32048-1-dianders@chromium.org> References: <20170106163101.32048-1-dianders@chromium.org> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Am Freitag, 6. Januar 2017, 08:31:01 CET schrieb Douglas Anderson: > When we used to defer setting the "grf" member to > rockchip_clk_get_grf() it was important to init the "grf" member to an > error value in rockchip_clk_init(). With recent changes, we now set > "grf" right in rockchip_clk_init() (two lines below the place where we > initted it). That makes the old init useless. Get rid of it. > > Fixes: 6f339dc2719e ("clk: rockchip: lookup General Register Files in > rockchip_clk_init") Signed-off-by: Douglas Anderson thanks for the catch, applied for 4.11 Thanks Heiko