From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751839AbcAAM4w (ORCPT ); Fri, 1 Jan 2016 07:56:52 -0500 Received: from mout.kundenserver.de ([212.227.17.10]:60961 "EHLO mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751638AbcAAM4u (ORCPT ); Fri, 1 Jan 2016 07:56:50 -0500 From: Arnd Bergmann To: linux-arm-kernel@lists.infradead.org Cc: Florian Fainelli , Xing Zheng , linux-rockchip@lists.infradead.org, heiko@sntech.de, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, Paul Gortmaker , Geert Uytterhoeven , keescook@google.com, leozwang@google.com, davem@davemloft.net Subject: Re: [RESEND PATCH v1 3/4] net: ethernet: arc: Add support emac for RK3036 Date: Fri, 01 Jan 2016 13:55:42 +0100 Message-ID: <3169681.aSJgN2TRic@wuerfel> User-Agent: KMail/4.11.5 (Linux/3.16.0-10-generic; KDE/4.11.5; x86_64; ; ) In-Reply-To: References: <1451287341-16453-1-git-send-email-zhengxing@rock-chips.com> <1451287341-16453-4-git-send-email-zhengxing@rock-chips.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" X-Provags-ID: V03:K0:90rYXKcMdVzhEy3d7NGqlyKIQOhgcpVtgs2trsRhsniUBOycJ8W lqMR+6KkhENXq+Jf/1wokkNGoz1o+kEfWM+LgJxO1Bo+d8J4mhUPRLjLf4MIHjXchSrKXxd sEC2LNlmyyh8BhPjtZWII4hT43RSMYUj3x12A/C6FYvnMHYsRBYk+qWnOOyaBbTs+D80AAs 2WgZFEHLJu2W9hurvesCQ== X-UI-Out-Filterresults: notjunk:1;V01:K0:pqx/f3DsJOw=:EQLol15WxGMnqoQFUixnGW xiGNy96kOPUZG3puWoL/JBUbHq/Kf7RcGGYivmjcvD2zm9CDBTHrFeAoVZK9RXADNwMzaPDaF R/jZetbaoSlazz1HeIt/C2jrYPbbQZUeAJa5x85jgX2PR6SOVL0C1V9cWpUqSwRdKnxaiVEEI LpY1LTvbJCtt1FVWaYrvD5ePicJ/V5DkmiZWbswV7RVzSAapuk+8R/3BhWEeFl0hR4L3wynD1 dvuh1LziUpoMoIKgOaXMQebmefqcjlfIXDaUL2nZOFNj6foK7nqpUHkPYYMviKHeqAFD9jTCG 1lCn96ZaJTfhviwpdRfjuzgqIARKwwx2/IVUvWM9XBEDdQB3iDgM4OAzXM9iJRANL/y+BTOUa FikSpMEoomIoo51dSlYFfbdzkiIvvjJp84vNbGWTLPH/Fw0Y5sJj+SD3kkJ1MKZTNoURRgm+n xeagtHTtRw+zZo9OiGaJWxkaxDd5MIoLRcW5tdx5S8742igUYGQFhlCPVJJDGOKuNS/Mx1sDy U5zTxSIxJOXIcjcpQGqDLzAaio1eqFqkfWKDxDKnr2Xf0Ig0rpJ8aeowGIzw5aVAX6TdjG3Ro dzQmqDoHQ4y0YrpWxnktYGC7HHLDItkr44McDowbz0OyTGlirk3SXvonBHk5kpTStHOaik1oO wEdykZXYeE8BFgs17e14UZQsOt9ZFM9gzmyiUkqpvzeOZ4vBks7C3VZdNXYZ/j3GjsnyPXZFx iAPxreZo/nnxxrGm Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tuesday 29 December 2015 14:59:59 Florian Fainelli wrote: > On December 27, 2015 11:22:20 PM PST, Xing Zheng wrote: > >The RK3036's GRFs offset are different with RK3066/RK3188, and need to > >set > >mac TX/RX clock before probe emac. > > > >Signed-off-by: Xing Zheng > >--- > > > }; > > > > static const struct of_device_id emac_rockchip_dt_ids[] = { > >- { .compatible = "rockchip,rk3066-emac", .data = > >&emac_rockchip_dt_data[0] }, > >- { .compatible = "rockchip,rk3188-emac", .data = > >&emac_rockchip_dt_data[1] }, > >+ { .compatible = "rockchip,rk3036-emac", .data = > >&emac_rockchip_dt_data[0] }, > >+ { .compatible = "rockchip,rk3066-emac", .data = > >&emac_rockchip_dt_data[1] }, > >+ { .compatible = "rockchip,rk3188-emac", .data = > >&emac_rockchip_dt_data[2] }, > > { /* Sentinel */ } > > Food for thought, you might want to use an enum here to index emac_rockchip_dt_data which would be less error prone if you add/remove entries in this structure. > I would use named structures instead: static const struct emac_rockchip_soc_data emac_rk3066_emac_data = { .grf_offset = 0x154, }; static const struct of_device_id emac_rockchip_dt_ids[] = { { .compatible = "rockchip,rk3066-emac", .data = &emac_rk3066_emac_data, ... }; Armd