From: David Howells <dhowells@redhat.com>
To: Tim Abbott <tabbott@MIT.EDU>
Cc: dhowells@redhat.com, Sam Ravnborg <sam@ravnborg.org>,
Linus Torvalds <torvalds@linux-foundation.org>,
Linux kernel mailing list <linux-kernel@vger.kernel.org>,
Anders Kaseorg <andersk@MIT.EDU>, Waseem Daher <wdaher@MIT.EDU>,
Denys Vlasenko <vda.linux@googlemail.com>,
Jeff Arnold <jbarnold@MIT.EDU>, Paul Mundt <lethal@linux-sh.org>
Subject: Re: [PATCH 03/14] mn10300: Use macros for .bss.page_aligned section.
Date: Tue, 28 Apr 2009 13:45:36 +0100 [thread overview]
Message-ID: <31713.1240922736@redhat.com> (raw)
In-Reply-To: <alpine.DEB.1.10.0904271946520.27012@vinegar-pot.mit.edu>
Tim Abbott <tabbott@MIT.EDU> wrote:
> No, it is. The macro is new in PATCH 1/14 of this series.
Aha! Okay, I've applied that patch too, and now I see:
LD .tmp_vmlinux1
/opt/nickc/H-i686-pc-linux-gnulibc2.3/bin/am33_2.0-linux-gnu-ld:arch/mn10300/kernel/vmlinux.lds:237: syntax error
Where the error occurs on line 237, which is:
__bss_start = .; /* BSS */
.bss : {
. = ALIGN(+(1 << 12)) *(.bss.page_aligned)
*(.bss)
==> }
. = ALIGN(4);
__bss_stop = .;
in the expanded linker script.
The problem is that your patch #1 is wrong. You need to apply:
---
diff --git a/include/asm-generic/vmlinux.lds.h b/include/asm-generic/vmlinux.lds.h
index a76275f..c9b16a6 100644
--- a/include/asm-generic/vmlinux.lds.h
+++ b/include/asm-generic/vmlinux.lds.h
@@ -118,11 +118,11 @@
TRACE_SYSCALLS()
#define PAGE_ALIGNED_DATA \
- . = ALIGN(PAGE_SIZE) \
+ . = ALIGN(PAGE_SIZE); \
*(.data.page_aligned)
#define PAGE_ALIGNED_BSS \
- . = ALIGN(PAGE_SIZE) \
+ . = ALIGN(PAGE_SIZE); \
*(.bss.page_aligned)
#define RO_DATA(align) \
---
to it.
David
next prev parent reply other threads:[~2009-04-28 12:47 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-04-27 20:32 [PATCH 00/14] clean up page aligned data and bss sections Tim Abbott
2009-04-27 20:32 ` [PATCH 01/14] Add new macros for page-aligned " Tim Abbott
2009-04-27 20:32 ` [PATCH 02/14] sh: Use macros for .bss.page_aligned section Tim Abbott
2009-04-27 20:32 ` [PATCH 03/14] mn10300: " Tim Abbott
2009-04-27 20:32 ` [PATCH 04/14] xtensa: " Tim Abbott
2009-04-27 20:32 ` [PATCH 05/14] x86: " Tim Abbott
2009-04-27 20:33 ` [PATCH 06/14] alpha: Use macros for .data.page_aligned Tim Abbott
2009-04-27 20:33 ` [PATCH 07/14] avr32: Use standard macros for .data.page_aligned section Tim Abbott
2009-04-27 20:33 ` [PATCH 08/14] sh: Use " Tim Abbott
2009-04-27 20:33 ` [PATCH 09/14] s390: Use macros for .data.page_aligned Tim Abbott
2009-04-27 20:33 ` [PATCH 10/14] powerpc: Remove unused __page_aligned macro Tim Abbott
2009-04-27 20:33 ` [PATCH 11/14] powerpc: Use macros for .data.page_aligned section Tim Abbott
2009-04-27 20:33 ` [PATCH 12/14] mn10300: Drop unused .data.idt section Tim Abbott
2009-04-27 20:33 ` [PATCH 13/14] x86: Use section .data.page_aligned for the idt_table Tim Abbott
2009-04-27 20:33 ` [PATCH 14/14] x86: Use macros for .data.page_aligned Tim Abbott
2009-04-28 4:41 ` [PATCH 12/14] mn10300: Drop unused .data.idt section Cyrill Gorcunov
2009-04-28 4:20 ` [PATCH 11/14] powerpc: Use macros for .data.page_aligned section Tim Abbott
2009-04-28 4:21 ` [PATCH 1/2] powerpc: share .data output section definition between 32 and 64 bits Tim Abbott
2009-04-28 4:21 ` [PATCH 2/2] powerpc: Use macros for .data.page_aligned section Tim Abbott
2009-04-28 15:07 ` [PATCH 11/14] " Stephen Rothwell
2009-04-28 15:13 ` Tim Abbott
2009-04-28 15:17 ` Stephen Rothwell
2009-04-28 7:39 ` [PATCH 09/14] s390: Use macros for .data.page_aligned Cyrill Gorcunov
2009-04-27 21:57 ` [PATCH 08/14] sh: Use macros for .data.page_aligned section Paul Mundt
2009-04-28 14:49 ` [PATCH 07/14] avr32: Use standard " Haavard Skinnemoen
2009-04-27 23:43 ` [PATCH 03/14] mn10300: Use macros for .bss.page_aligned section David Howells
2009-04-27 23:48 ` Tim Abbott
2009-04-28 12:45 ` David Howells [this message]
2009-04-27 21:57 ` [PATCH 02/14] sh: " Paul Mundt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=31713.1240922736@redhat.com \
--to=dhowells@redhat.com \
--cc=andersk@MIT.EDU \
--cc=jbarnold@MIT.EDU \
--cc=lethal@linux-sh.org \
--cc=linux-kernel@vger.kernel.org \
--cc=sam@ravnborg.org \
--cc=tabbott@MIT.EDU \
--cc=torvalds@linux-foundation.org \
--cc=vda.linux@googlemail.com \
--cc=wdaher@MIT.EDU \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox