From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from out-183.mta0.migadu.com (out-183.mta0.migadu.com [91.218.175.183]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9DD1D1C860B for ; Fri, 6 Feb 2026 02:53:56 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=91.218.175.183 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770346436; cv=none; b=se7SpNzxjXb8H+6SVohBn/boPJLd3zp+exiThcPLZdcRrlQrOaI+GDWisUSHe4OQUrvn1U13yKWHqxqyFZD99nyHw5XSNpASKu/1MJd9oqb38CV2MQXFx2QBHBZQ/iBz3MNqwD5mS98dVnGcrsJjRf8ookqGRQIi4plYKpr8MjY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770346436; c=relaxed/simple; bh=ocStP8pUgXMdNZ160TeZWnDu6YtjqwlqIrdbRjnkSL4=; h=MIME-Version:Date:Content-Type:From:Message-ID:Subject:To:Cc: In-Reply-To:References; b=lSYw+Q0LddnalghstvVtj/8Is7XZhADu7AmfNT3EVUJ+KTs0uD67APNIDhMAjJgRzLHLdXnTCOxW6SRCf4eiHIIbNrQs6bMyFkO1Z4N2vbpqdL7Oi3t7I2aMBd4LbHt/v3wLeTj7XST0ClvoNx6sUV7g6B334zorVGXwNYc7z+I= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev; spf=pass smtp.mailfrom=linux.dev; dkim=pass (1024-bit key) header.d=linux.dev header.i=@linux.dev header.b=YYh+RTqw; arc=none smtp.client-ip=91.218.175.183 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linux.dev Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linux.dev header.i=@linux.dev header.b="YYh+RTqw" Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1770346434; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=kl9ABNqAlIP37pttYDfGhjd/d6eepItkd6PhmTOS3dg=; b=YYh+RTqwwONx2rQgKhQpqNIq8/TXI9Xlz9xZCA1xyELrT6+0RpTXYnmCeU/thQSURgvqL4 PG7eqo5WflFalJGaR+lY14UjOtXHjOsYqL/B/VveREiAoh+1Dti+m3mdk+gTPCPWLwnoVq UKxX48kFYmh5suHUnGeLsGnAVL5hfo0= Date: Fri, 06 Feb 2026 02:53:52 +0000 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: "Jiayuan Chen" Message-ID: <3179fa38027bdacdd38b4ef34b493bdb5ef7a19a@linux.dev> TLS-Required: No Subject: Re: [PATCH v1] mm: zswap: add per-memcg stat for incompressible pages To: "Yosry Ahmed" , "SeongJae Park" Cc: "SeongJae Park" , linux-mm@kvack.org, "Jiayuan Chen" , "Johannes Weiner" , "Michal Hocko" , "Roman Gushchin" , "Shakeel Butt" , "Muchun Song" , "Nhat Pham" , "Chengming Zhou" , "Andrew Morton" , "Nick Terrell" , "David Sterba" , cgroups@vger.kernel.org, linux-kernel@vger.kernel.org In-Reply-To: References: <20260206022152.67992-1-sj@kernel.org> X-Migadu-Flow: FLOW_OUT February 6, 2026 at 10:33, "Yosry Ahmed" wrote: >=20 >=20>=20 >=20> On Thu, 5 Feb 2026 13:30:12 +0800 Jiayuan Chen <> wrote: > >=20=20 >=20>=20=20 >=20> From: Jiayuan Chen > >=20=20 >=20> The global zswap_stored_incompressible_pages counter was added in = commit > > dca4437a5861 ("mm/zswap: store > to track how many pages are stored in raw (uncompressed) form in zsw= ap. > > However, in containerized environments, knowing which cgroup is > > contributing incompressible pages is essential for effective resourc= e > > management. > >=20=20 >=20> Add a new memcg stat 'zswpraw' to track incompressible pages per c= group. > > This helps administrators and orchestrators to: > >=20=20 >=20> 1. Identify workloads that produce incompressible data (e.g., encr= ypted > > data, already-compressed media, random data) and may not benefit fro= m > > zswap. > >=20=20 >=20> 2. Make informed decisions about workload placement - moving > > incompressible workloads to nodes with larger swap backing devices > > rather than relying on zswap. > >=20=20 >=20> 3. Debug zswap efficiency issues at the cgroup level without needi= ng to > > correlate global stats with individual cgroups. > >=20=20 >=20> While the compression ratio can be estimated from existing stats > > (zswap / zswapped * PAGE_SIZE), this doesn't distinguish between > > "uniformly poor compression" and "a few completely incompressible pa= ges > > mixed with highly compressible ones". The zswpraw stat provides dire= ct > > visibility into the latter case. > >=20=20 >=20> Changes > > ------- > >=20=20 >=20> 1. Add zswap_is_raw() helper (include/linux/zswap.h) > > - Abstract the PAGE_SIZE comparison logic for identifying raw entrie= s > > - Keep the incompressible check in one place for maintainability > >=20=20 >=20> 2. Add MEMCG_ZSWAP_RAW stat definition (include/linux/memcontrol.h= , > > mm/memcontrol.c) > > - Add MEMCG_ZSWAP_RAW to memcg_stat_item enum > > - Register in memcg_stat_items[] and memory_stats[] arrays > > - Export as "zswpraw" in memory.stat > >=20=20 >=20> 3. Update statistics accounting (mm/memcontrol.c, mm/zswap.c) > > - Track MEMCG_ZSWAP_RAW in obj_cgroup_charge/uncharge_zswap() > > - Use zswap_is_raw() helper in zswap.c for consistency > >=20=20 >=20> Test > > ---- > >=20=20 >=20> I wrote a simple test program[1] that allocates memory and compres= ses it > > with zstd, so kernel zswap cannot compress further. > >=20=20 >=20> $ cgcreate -g memory:test > > $ cgexec -g memory:test ./test_zswpraw & > > $ cat /sys/fs/cgroup/test/memory.stat | grep zswp > > zswpraw 0 > > zswpin 0 > > zswpout 0 > > zswpwb 0 > >=20=20 >=20> $ echo "100M" > /sys/fs/cgroup/test/memory.reclaim > > $ cat /sys/fs/cgroup/test/memory.stat | grep zswp > > zswpraw 104800256 > > zswpin 0 > > zswpout 51222 > > zswpwb 0 > >=20=20 >=20> $ pkill test_zswpraw > > $ cat /sys/fs/cgroup/test/memory.stat | grep zswp > > zswpraw 0 > > zswpin 1 > > zswpout 51222 > > zswpwb 0 > >=20=20 >=20> [1] https://gist.github.com/mrpre/00432c6154250326994fbeaf62e0e6f1 > >=20=20 >=20> Signed-off-by: Jiayuan Chen > > --- > > include/linux/memcontrol.h | 1 + > > include/linux/zswap.h | 9 +++++++++ > > mm/memcontrol.c | 6 ++++++ > > mm/zswap.c | 6 +++--- > > 4 files changed, 19 insertions(+), 3 deletions(-) > >=20=20 >=20> As others also mentioned, the documentation of the new stat would = be needed. > >=20=20 >=20>=20=20 >=20> diff --git a/include/linux/memcontrol.h b/include/linux/memcontrol= .h > > index b6c82c8f73e1..83d1328f81d1 100644 > > --- a/include/linux/memcontrol.h > > +++ b/include/linux/memcontrol.h > > @@ -39,6 +39,7 @@ enum memcg_stat_item { > > MEMCG_KMEM, > > MEMCG_ZSWAP_B, > > MEMCG_ZSWAPPED, > > + MEMCG_ZSWAP_RAW, > > MEMCG_NR_STAT, > > }; > >=20=20 >=20> diff --git a/include/linux/zswap.h b/include/linux/zswap.h > > index 30c193a1207e..94f84b154b71 100644 > > --- a/include/linux/zswap.h > > +++ b/include/linux/zswap.h > > @@ -7,6 +7,15 @@ > >=20=20 >=20> struct lruvec; > >=20=20 >=20> +/* > > + * Check if a zswap entry is stored in raw (uncompressed) form. > > + * This happens when compression doesn't reduce the size. > > + */ > > +static inline bool zswap_is_raw(size_t size) > > +{ > > + return size =3D=3D PAGE_SIZE; > > +} > > + > >=20=20 >=20> No strong opinion, but I'm not really sure if the helper is needed= , because it > > feels quite simple logic: > >=20=20 >=20> "If an object is compressed and the size is same to the original o= ne, the > > object is incompressible." > >=20=20 >=20> I also feel the function name bit odd, given the type of the param= eter. Based > > on the function name and the comment, I'd expect it to receive a zsw= ap_entry > > object. I understand it is better to receive a size_t, to be called = from > > obj_cgroup_[un]charge_zswap(), though. Even in the case, I think the= name can > > be better (e.g., zswap_compression_failed() or zswap_was_incompressi= ble() ?), > > or at least the coment can be more kindly explain the fact that the = parameter > > is the size of object after the compression attempt. > >=20 >=20I vote to drop the helper. > The reason I introduced the helper is that the incompressible check now l= ives in two places: In zswap.c - for the global zswap_stored_incompressible_pages counter In memcontrol.c - for the per-memcg MEMCG_ZSWAP_INCOMP stat By extracting a shared helper, both modules use the same logic, which hel= ps with maintainability. That said, I'm fine with dropping the helper if preferred. I can add a co= mment in memcontrol.c explaining the logic. My only concern is that if the incompressible detec= tion logic in zswap ever changes, someone might forget to update the memcg accounting accordi= ngly. But perhaps that's an unlikely scenario.