From: Chris Mason <mason@suse.com>
To: Andreas Klein <asklein@cip.physik.uni-wuerzburg.de>,
linux-kernel@vger.kernel.org, reiserfs-list@namesys.com
Subject: Re: reiserfs-oops; kernel 2.4.3-pre4
Date: Thu, 15 Mar 2001 09:58:51 -0500 [thread overview]
Message-ID: <319210000.984668331@tiny> (raw)
In-Reply-To: <Pine.GHP.4.21.0103151342010.7504-100000@wpax13.physik.uni-wuerzburg.de>
[-- Attachment #1: Type: text/plain, Size: 747 bytes --]
On Thursday, March 15, 2001 02:00:11 PM +0100 Andreas Klein
<asklein@cip.physik.uni-wuerzburg.de> wrote:
[ oops ]
>>> EIP; c016f090 <comp_short_keys+10/40> <=====
> Trace; c0160046 <reiserfs_iget+6a/a4>
> Trace; c015c8a8 <reiserfs_lookup+94/c4>
>
> The machine is running linux-2.4.3-pre4 including the reiserfs-patches
> from Alexander Zarochentcev.
Ah, I see. objectid-sharing.diff will pass a null inode to comp_short_keys
if iget4 returns a bad_inode.
Looks like you were using NFS, you'll want to look through the docs on
www.reiserfs.org for the additional patches required to make NFS and
reiserfs play nice.
The attached patch replaces objectid-sharing.diff. The bug was not present
in pure 2.4.x or 2.4.x-ac kernels.
-chris
[-- Attachment #2: objectid-sharing-2.diff --]
[-- Type: text/plain, Size: 804 bytes --]
--- diff/linux/fs/reiserfs/inode.c Thu Mar 15 09:47:18 2001
+++ linux/fs/reiserfs/inode.c Thu Mar 15 09:39:06 2001
@@ -1159,11 +1159,17 @@
if (!inode)
return inode ;
- // if (comp_short_keys (INODE_PKEY (inode), key)) {
if (is_bad_inode (inode)) {
reiserfs_warning ("vs-13048: reiserfs_iget: "
"bad_inode. Stat data of (%lu %lu) not found\n",
key->on_disk_key.k_dir_id, key->on_disk_key.k_objectid);
+ iput (inode);
+ inode = 0;
+ } else if (comp_short_keys (INODE_PKEY (inode), key)) {
+ reiserfs_warning ("vs-13049: reiserfs_iget: "
+ "Looking for (%lu %lu), found inode of (%lu %lu)\n",
+ key->on_disk_key.k_dir_id, key->on_disk_key.k_objectid,
+ INODE_PKEY (inode)->k_dir_id, INODE_PKEY (inode)->k_objectid);
iput (inode);
inode = 0;
}
prev parent reply other threads:[~2001-03-15 14:59 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2001-03-15 13:00 reiserfs-oops; kernel 2.4.3-pre4 Andreas Klein
2001-03-15 14:58 ` Chris Mason [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=319210000.984668331@tiny \
--to=mason@suse.com \
--cc=asklein@cip.physik.uni-wuerzburg.de \
--cc=linux-kernel@vger.kernel.org \
--cc=reiserfs-list@namesys.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox