From: Shuah Khan <skhan@linuxfoundation.org>
To: "Nysal Jan K.A" <nysal@linux.ibm.com>,
Thomas Gleixner <tglx@linutronix.de>,
Ingo Molnar <mingo@redhat.com>
Cc: "Peter Zijlstra" <peterz@infradead.org>,
"Darren Hart" <dvhart@infradead.org>,
"Davidlohr Bueso" <dave@stgolabs.net>,
"André Almeida" <andrealmeid@igalia.com>,
"Shuah Khan" <shuah@kernel.org>,
linux-kernel@vger.kernel.org, linux-kselftest@vger.kernel.org,
"Shuah Khan" <skhan@linuxfoundation.org>
Subject: Re: [PATCH] selftests/futex: Order calls to futex_lock_pi
Date: Wed, 16 Aug 2023 10:52:34 -0600 [thread overview]
Message-ID: <3193a5a7-ea3b-e6ed-d42c-fa034c2affdc@linuxfoundation.org> (raw)
In-Reply-To: <20230814080927.61048-1-nysal@linux.ibm.com>
On 8/14/23 02:09, Nysal Jan K.A wrote:
> Observed occassional failures in the futex_wait_timeout test:
>
> ok 1 futex_wait relative succeeds
> ok 2 futex_wait_bitset realtime succeeds
> ok 3 futex_wait_bitset monotonic succeeds
> ok 4 futex_wait_requeue_pi realtime succeeds
> ok 5 futex_wait_requeue_pi monotonic succeeds
> not ok 6 futex_lock_pi realtime returned 0
> ......
>
> The test expects the child thread to complete some steps before
> the parent thread gets to run. There is an implicit expectation
> of the order of invocation of futex_lock_pi between the child thread
> and the parent thread. Make this order explicit. If the order is
> not met, the futex_lock_pi call in the parent thread succeeds and
> will not timeout.
>
> Fixes: f4addd54b161 ("selftests: futex: Expand timeout test")
> Signed-off-by: Nysal Jan K.A <nysal@linux.ibm.com>
> ---
Thank you. Applied to linux-kselftest next for Linux 6.6-rc1.
thanks,
-- Shuah
prev parent reply other threads:[~2023-08-16 16:54 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-14 8:09 [PATCH] selftests/futex: Order calls to futex_lock_pi Nysal Jan K.A
2023-08-16 16:52 ` Shuah Khan [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3193a5a7-ea3b-e6ed-d42c-fa034c2affdc@linuxfoundation.org \
--to=skhan@linuxfoundation.org \
--cc=andrealmeid@igalia.com \
--cc=dave@stgolabs.net \
--cc=dvhart@infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=nysal@linux.ibm.com \
--cc=peterz@infradead.org \
--cc=shuah@kernel.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox