From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7EB24C41513 for ; Wed, 16 Aug 2023 16:54:04 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1344963AbjHPQxe (ORCPT ); Wed, 16 Aug 2023 12:53:34 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:44994 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1344960AbjHPQxI (ORCPT ); Wed, 16 Aug 2023 12:53:08 -0400 Received: from mail-il1-x134.google.com (mail-il1-x134.google.com [IPv6:2607:f8b0:4864:20::134]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 02FE3E4C for ; Wed, 16 Aug 2023 09:53:07 -0700 (PDT) Received: by mail-il1-x134.google.com with SMTP id e9e14a558f8ab-3496e3e02f3so5318625ab.0 for ; Wed, 16 Aug 2023 09:53:06 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linuxfoundation.org; s=google; t=1692204786; x=1692809586; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=lTSeYU3JyTRpC8MJkT9sFIq+oIiYKkH14KvEcr7o5GA=; b=BBzzif0AayYda7c4a9xibgNV0egsHz2CC+x+7A2T4Hgb7Noi0B4ZQCjnOk06IN4ydd GQNecB6WPh1L6q2HFIvWUmHWGugTWfAhSgg94xGIkLhd76Y8GmsjtfNP0fMWlnEqEYO3 /2Fm3IXGCiyE4FmUABsfCWEdyutTyTaCDu3M4= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1692204786; x=1692809586; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=lTSeYU3JyTRpC8MJkT9sFIq+oIiYKkH14KvEcr7o5GA=; b=h8zGk8eNOzFQFbxFc68wJT872LgslTWSkOijnA4fNCOkxpEafY4YHi1L9yKR7GthCK br0zZhrojiwvRssgyA6wuRPoRoJJL8sFo45AKYwMW78xYRp1R1c8JREy7n5tIW0nSG5e Vk3MlQWB4DyDebgJLScRzLmeJughTm3gHTleFPhudJ6O8QZ1NlZaTITv94g+IHNOS5N3 rpmYP2nFhP2+UuAeLDjYUXh3bv9mH4WCV7ZeQbogvZQyW3nFhgvznxl5/07wDc1iTYUP 7YT5GqbunZxrNwNGNap2A3864Ihtr3WY3ar0nQB83FI2N9Nc2MhBrZ+rU/VFauM1R688 qMBw== X-Gm-Message-State: AOJu0Yy9mjyQ4DNHUDtZqbLxjOenianbwHq8UNJTY1cIqUNi3visOn9k i3S/Fsyp/fjiagN1yyxLkBKcAPvswX9uF37k1Xo= X-Google-Smtp-Source: AGHT+IGvK6s5Yc2BIInO8ztWs1EXMoonbB3rlX4P/LXTaEaHSUlEyofeK7VM2BgXuyJrq2wnnPBmWw== X-Received: by 2002:a92:b0c:0:b0:349:983c:4940 with SMTP id b12-20020a920b0c000000b00349983c4940mr3556570ilf.1.1692204786417; Wed, 16 Aug 2023 09:53:06 -0700 (PDT) Received: from [192.168.1.128] ([38.15.45.1]) by smtp.gmail.com with ESMTPSA id b16-20020a92db10000000b003424b3d6d37sm4759933iln.24.2023.08.16.09.52.43 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 16 Aug 2023 09:53:05 -0700 (PDT) Message-ID: <3193a5a7-ea3b-e6ed-d42c-fa034c2affdc@linuxfoundation.org> Date: Wed, 16 Aug 2023 10:52:34 -0600 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.13.0 Subject: Re: [PATCH] selftests/futex: Order calls to futex_lock_pi Content-Language: en-US To: "Nysal Jan K.A" , Thomas Gleixner , Ingo Molnar Cc: Peter Zijlstra , Darren Hart , Davidlohr Bueso , =?UTF-8?Q?Andr=c3=a9_Almeida?= , Shuah Khan , linux-kernel@vger.kernel.org, linux-kselftest@vger.kernel.org, Shuah Khan References: <20230814080927.61048-1-nysal@linux.ibm.com> From: Shuah Khan In-Reply-To: <20230814080927.61048-1-nysal@linux.ibm.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 8/14/23 02:09, Nysal Jan K.A wrote: > Observed occassional failures in the futex_wait_timeout test: > > ok 1 futex_wait relative succeeds > ok 2 futex_wait_bitset realtime succeeds > ok 3 futex_wait_bitset monotonic succeeds > ok 4 futex_wait_requeue_pi realtime succeeds > ok 5 futex_wait_requeue_pi monotonic succeeds > not ok 6 futex_lock_pi realtime returned 0 > ...... > > The test expects the child thread to complete some steps before > the parent thread gets to run. There is an implicit expectation > of the order of invocation of futex_lock_pi between the child thread > and the parent thread. Make this order explicit. If the order is > not met, the futex_lock_pi call in the parent thread succeeds and > will not timeout. > > Fixes: f4addd54b161 ("selftests: futex: Expand timeout test") > Signed-off-by: Nysal Jan K.A > --- Thank you. Applied to linux-kselftest next for Linux 6.6-rc1. thanks, -- Shuah