public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Richard Weinberger <richard@sigma-star.at>
To: Richard Weinberger <richard@nod.at>, upstream@sigma-star.at
Cc: linux-remoteproc@vger.kernel.org, linux-kernel@vger.kernel.org,
	andersson@kernel.org, upstream+rproc@sigma-star.at,
	ohad@wizery.com, s-anna@ti.com, t-kristo@ti.com,
	Mathieu Poirier <mathieu.poirier@linaro.org>
Subject: Re: [PATCH] rpmsg_ns: Work around TI non-standard message
Date: Tue, 15 Oct 2024 18:58:33 +0200	[thread overview]
Message-ID: <3194112.zE8UqtGg2D@somecomputer> (raw)
In-Reply-To: <Zw6cyFirqQ6Esr+0@p14s>

Mathieu,

Am Dienstag, 15. Oktober 2024, 18:48:08 CEST schrieb Mathieu Poirier:
> Good morning Richard,
> 
> On Fri, Oct 11, 2024 at 02:39:22PM +0200, Richard Weinberger wrote:
> > Texas Instruments ships a patch in their vendor kernels,
> > which adds a new NS message that includes a description field.
> > While TI is free to do whatever they want in their copy of the kernel,
> > it becomes a mess when people switch to a mainline kernel and want
> > to use their existing DSP programs with it.
> 
> I suspect there is a lot more things to change when going from downstream to a
> mainline kernel.

Not really.
I had to revert c6aed238b7a9b ("remoteproc: modify vring allocation to rely on centralized carveout allocator")
because the DSP has a sub-optimal resource table, and this workaround.
With that the DSP program worked as-is on kernel 6.6.
Downstream was 4.19 TI.

> > 
> > To make it easier to migrate to a mainline kernel,
> > let's make the kernel aware of their non-standard extension but
> > briefly ignore the description field.
> 
> In my opinion the real fix here is to get TI to use the standard message
> announcement structure.  The ->desc field doesn't seem to be that useful since
> it gets discarted.

This is for the future, the goal of my patch is helping people to
get existing DSP programs work with mainline.
Not everyone can or want to rebuild theirs DSP programs when moving to a mainline
kernel.

Thanks,
//richard

-- 
​​​​​sigma star gmbh | Eduard-Bodem-Gasse 6, 6020 Innsbruck, AUT
UID/VAT Nr: ATU 66964118 | FN: 374287y



  reply	other threads:[~2024-10-15 16:58 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-10-11 12:39 [PATCH] rpmsg_ns: Work around TI non-standard message Richard Weinberger
2024-10-12 15:53 ` kernel test robot
2024-10-14  9:24   ` Richard Weinberger
2024-10-15 16:48 ` Mathieu Poirier
2024-10-15 16:58   ` Richard Weinberger [this message]
2024-10-15 17:56     ` Mathieu Poirier
2024-10-15 18:00       ` Richard Weinberger
2024-10-29 16:15         ` Romain Naour
2024-12-03 15:19         ` Andrew Davis
2024-12-03 16:40           ` Richard Weinberger

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=3194112.zE8UqtGg2D@somecomputer \
    --to=richard@sigma-star.at \
    --cc=andersson@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-remoteproc@vger.kernel.org \
    --cc=mathieu.poirier@linaro.org \
    --cc=ohad@wizery.com \
    --cc=richard@nod.at \
    --cc=s-anna@ti.com \
    --cc=t-kristo@ti.com \
    --cc=upstream+rproc@sigma-star.at \
    --cc=upstream@sigma-star.at \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox