From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3AD58C3A5A4 for ; Mon, 2 Sep 2019 02:15:27 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 0B63C21874 for ; Mon, 2 Sep 2019 02:15:27 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729250AbfIBCP0 (ORCPT ); Sun, 1 Sep 2019 22:15:26 -0400 Received: from mga02.intel.com ([134.134.136.20]:7913 "EHLO mga02.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728926AbfIBCPZ (ORCPT ); Sun, 1 Sep 2019 22:15:25 -0400 X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga005.fm.intel.com ([10.253.24.32]) by orsmga101.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 01 Sep 2019 19:15:24 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.64,457,1559545200"; d="scan'208";a="381729047" Received: from allen-box.sh.intel.com (HELO [10.239.159.136]) ([10.239.159.136]) by fmsmga005.fm.intel.com with ESMTP; 01 Sep 2019 19:15:20 -0700 Cc: baolu.lu@linux.intel.com, David Woodhouse , Joerg Roedel , Bjorn Helgaas , Christoph Hellwig , ashok.raj@intel.com, jacob.jun.pan@intel.com, alan.cox@intel.com, kevin.tian@intel.com, mika.westerberg@linux.intel.com, Ingo Molnar , Greg Kroah-Hartman , pengfei.xu@intel.com, Konrad Rzeszutek Wilk , Marek Szyprowski , Robin Murphy , Jonathan Corbet , Boris Ostrovsky , Juergen Gross , Stefano Stabellini , iommu@lists.linux-foundation.org, linux-kernel@vger.kernel.org, Jacob Pan Subject: Re: [PATCH v8 6/7] iommu/vt-d: Add trace events for device dma map/unmap To: Steven Rostedt References: <20190830071718.16613-1-baolu.lu@linux.intel.com> <20190830071718.16613-7-baolu.lu@linux.intel.com> <20190830095349.1c222240@gandalf.local.home> From: Lu Baolu Message-ID: <319db353-6641-61af-a86a-93d832b742c2@linux.intel.com> Date: Mon, 2 Sep 2019 10:13:57 +0800 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.8.0 MIME-Version: 1.0 In-Reply-To: <20190830095349.1c222240@gandalf.local.home> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Steve, On 8/30/19 9:53 PM, Steven Rostedt wrote: > On Fri, 30 Aug 2019 15:17:17 +0800 > Lu Baolu wrote: > >> This adds trace support for the Intel IOMMU driver. It >> also declares some events which could be used to trace >> the events when an IOVA is being mapped or unmapped in >> a domain. >> >> Cc: Ashok Raj >> Cc: Jacob Pan >> Cc: Kevin Tian >> Signed-off-by: Mika Westerberg >> Signed-off-by: Lu Baolu >> Reviewed-by: Steven Rostedt (VMware) >> --- >> drivers/iommu/Makefile | 1 + >> drivers/iommu/intel-trace.c | 14 +++++ >> include/trace/events/intel_iommu.h | 84 ++++++++++++++++++++++++++++++ >> 3 files changed, 99 insertions(+) >> create mode 100644 drivers/iommu/intel-trace.c >> create mode 100644 include/trace/events/intel_iommu.h >> >> diff --git a/drivers/iommu/Makefile b/drivers/iommu/Makefile >> index f13f36ae1af6..bfe27b2755bd 100644 >> --- a/drivers/iommu/Makefile >> +++ b/drivers/iommu/Makefile >> @@ -17,6 +17,7 @@ obj-$(CONFIG_ARM_SMMU) += arm-smmu.o >> obj-$(CONFIG_ARM_SMMU_V3) += arm-smmu-v3.o >> obj-$(CONFIG_DMAR_TABLE) += dmar.o >> obj-$(CONFIG_INTEL_IOMMU) += intel-iommu.o intel-pasid.o >> +obj-$(CONFIG_INTEL_IOMMU) += intel-trace.o >> obj-$(CONFIG_INTEL_IOMMU_DEBUGFS) += intel-iommu-debugfs.o >> obj-$(CONFIG_INTEL_IOMMU_SVM) += intel-svm.o >> obj-$(CONFIG_IPMMU_VMSA) += ipmmu-vmsa.o >> diff --git a/drivers/iommu/intel-trace.c b/drivers/iommu/intel-trace.c >> new file mode 100644 >> index 000000000000..bfb6a6e37a88 >> --- /dev/null >> +++ b/drivers/iommu/intel-trace.c >> @@ -0,0 +1,14 @@ >> +// SPDX-License-Identifier: GPL-2.0 >> +/* >> + * Intel IOMMU trace support >> + * >> + * Copyright (C) 2019 Intel Corporation >> + * >> + * Author: Lu Baolu >> + */ >> + >> +#include >> +#include >> + >> +#define CREATE_TRACE_POINTS >> +#include >> diff --git a/include/trace/events/intel_iommu.h b/include/trace/events/intel_iommu.h >> new file mode 100644 >> index 000000000000..9c28e6cae86f >> --- /dev/null >> +++ b/include/trace/events/intel_iommu.h >> @@ -0,0 +1,84 @@ >> +/* SPDX-License-Identifier: GPL-2.0 */ >> +/* >> + * Intel IOMMU trace support >> + * >> + * Copyright (C) 2019 Intel Corporation >> + * >> + * Author: Lu Baolu >> + */ >> +#ifdef CONFIG_INTEL_IOMMU >> +#undef TRACE_SYSTEM >> +#define TRACE_SYSTEM intel_iommu >> + >> +#if !defined(_TRACE_INTEL_IOMMU_H) || defined(TRACE_HEADER_MULTI_READ) >> +#define _TRACE_INTEL_IOMMU_H >> + >> +#include >> +#include >> + >> +DECLARE_EVENT_CLASS(dma_map, >> + TP_PROTO(struct device *dev, dma_addr_t dev_addr, phys_addr_t phys_addr, >> + size_t size), >> + >> + TP_ARGS(dev, dev_addr, phys_addr, size), >> + >> + TP_STRUCT__entry( >> + __string(dev_name, dev_name(dev)) >> + __field(dma_addr_t, dev_addr) >> + __field(phys_addr_t, phys_addr) >> + __field(size_t, size) >> + ), >> + >> + TP_fast_assign( >> + __assign_str(dev_name, dev_name(dev)); >> + __entry->dev_addr = dev_addr; >> + __entry->phys_addr = phys_addr; >> + __entry->size = size; >> + ), >> + >> + TP_printk("dev=%s dev_addr=0x%llx phys_addr=0x%llx size=%zu", >> + __get_str(dev_name), >> + (unsigned long long)__entry->dev_addr, >> + (unsigned long long)__entry->phys_addr, >> + __entry->size) >> +); >> + >> +DEFINE_EVENT(dma_map, bounce_map_single, >> + TP_PROTO(struct device *dev, dma_addr_t dev_addr, phys_addr_t phys_addr, >> + size_t size), >> + TP_ARGS(dev, dev_addr, phys_addr, size) >> +); > > Do you plan on adding more events to these classes? This patch has two > distinct DECLARE_EVENT_CLASS() calls, and each has one DEFINE_EVENT() > for them. Yes, we will add more. This patch only adds the trace events that are necessary for this patch series's development. It's easy to extend to other events. > > It's fine to do this, but I'm curious to why you did not use > the "TRACE_EVENT()" macro, which basically is just a single > DECLARE_EVENT_CLASS() followed by a single DEFINE_EVENT(). In other > words, you just open coded TRACE_EVENT(). Fair enough. > > -- Steve Best regards, Lu Baolu > >> + >> +DECLARE_EVENT_CLASS(dma_unmap, >> + TP_PROTO(struct device *dev, dma_addr_t dev_addr, size_t size), >> + >> + TP_ARGS(dev, dev_addr, size), >> + >> + TP_STRUCT__entry( >> + __string(dev_name, dev_name(dev)) >> + __field(dma_addr_t, dev_addr) >> + __field(size_t, size) >> + ), >> + >> + TP_fast_assign( >> + __assign_str(dev_name, dev_name(dev)); >> + __entry->dev_addr = dev_addr; >> + __entry->size = size; >> + ), >> + >> + TP_printk("dev=%s dev_addr=0x%llx size=%zu", >> + __get_str(dev_name), >> + (unsigned long long)__entry->dev_addr, >> + __entry->size) >> +); >> + >> +DEFINE_EVENT(dma_unmap, bounce_unmap_single, >> + TP_PROTO(struct device *dev, dma_addr_t dev_addr, size_t size), >> + TP_ARGS(dev, dev_addr, size) >> +); >> + >> +#endif /* _TRACE_INTEL_IOMMU_H */ >> + >> +/* This part must be outside protection */ >> +#include >> +#endif /* CONFIG_INTEL_IOMMU */ > >