From: Krzysztof Kozlowski <krzk@kernel.org>
To: Janaki Ramaiah Thota <quic_janathot@quicinc.com>
Cc: Marcel Holtmann <marcel@holtmann.org>,
Luiz Augusto von Dentz <luiz.dentz@gmail.com>,
Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Balakrishna Godavarthi <quic_bgodavar@quicinc.com>,
Rocky Liao <quic_rjliao@quicinc.com>,
quic_mohamull@quicinc.com, quic_hbandi@quicinc.com,
quic_anubhavg@quicinc.com, linux-bluetooth@vger.kernel.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v6 1/1] dt-bindings: bluetooth: update the wcn6750 required properties
Date: Tue, 24 Dec 2024 14:27:09 +0100 [thread overview]
Message-ID: <31ddcb1f-4606-4c5b-893a-179718ed6339@kernel.org> (raw)
In-Reply-To: <c87b12d2-06cd-4982-838d-ecaa97572369@quicinc.com>
On 24/12/2024 12:51, Janaki Ramaiah Thota wrote:
>
>
> On 12/24/2024 2:46 PM, Krzysztof Kozlowski wrote:
>> On Mon, Dec 23, 2024 at 07:27:00PM +0530, Janaki Ramaiah Thota wrote:
>>
>> Subject: everything is an update... say something useful, e.g. use PMU
>> abstraction for WCN6750
>>
>
> Sure will correct it in next patch.
>
>>> Drop the inputs from the host and instead expect the Bluetooth node to
>>> consume the outputs of the internal PMU.
>>
>> On which device?
>>
>
> It is for BT module wcn6750 attached on qcs6490-rb3gen2 board.
> will update same on next commit message.
>
>> But anyway I have doubts this is correct. enable GPIO is a pin going
>> from the host, not from PMU.
>>
>
> Yes you are correct, enable GPIO is out pin of host, but here updated
> the entries required for Bluetooth node from PMU, not from host to PMU.
Hm? No, you removed for example enable-gpios, which is input from the
host. Sorry, I don't understand the reason behind this patch and commit
msg does not help me there.
Best regards,
Krzysztof
next prev parent reply other threads:[~2024-12-24 13:27 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-12-23 13:56 [PATCH v6 0/1] Enable Bluetooth on qcs6490-rb3gen2 board Janaki Ramaiah Thota
2024-12-23 13:57 ` [PATCH v6 1/1] dt-bindings: bluetooth: update the wcn6750 required properties Janaki Ramaiah Thota
2024-12-24 9:16 ` Krzysztof Kozlowski
2024-12-24 11:51 ` Janaki Ramaiah Thota
2024-12-24 13:27 ` Krzysztof Kozlowski [this message]
2024-12-26 6:11 ` Janaki Ramaiah Thota
2024-12-27 7:05 ` Krzysztof Kozlowski
2024-12-27 10:46 ` Janaki Ramaiah Thota
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=31ddcb1f-4606-4c5b-893a-179718ed6339@kernel.org \
--to=krzk@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=krzk+dt@kernel.org \
--cc=linux-bluetooth@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=luiz.dentz@gmail.com \
--cc=marcel@holtmann.org \
--cc=quic_anubhavg@quicinc.com \
--cc=quic_bgodavar@quicinc.com \
--cc=quic_hbandi@quicinc.com \
--cc=quic_janathot@quicinc.com \
--cc=quic_mohamull@quicinc.com \
--cc=quic_rjliao@quicinc.com \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox