From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 61285C433DB for ; Wed, 20 Jan 2021 06:43:49 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 1B74F2313C for ; Wed, 20 Jan 2021 06:43:48 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726445AbhATGnU (ORCPT ); Wed, 20 Jan 2021 01:43:20 -0500 Received: from new4-smtp.messagingengine.com ([66.111.4.230]:43997 "EHLO new4-smtp.messagingengine.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726739AbhATGjl (ORCPT ); Wed, 20 Jan 2021 01:39:41 -0500 Received: from compute3.internal (compute3.nyi.internal [10.202.2.43]) by mailnew.nyi.internal (Postfix) with ESMTP id B7B2558059E; Wed, 20 Jan 2021 01:38:28 -0500 (EST) Received: from imap2 ([10.202.2.52]) by compute3.internal (MEProxy); Wed, 20 Jan 2021 01:38:28 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=aj.id.au; h= mime-version:message-id:in-reply-to:references:date:from:to:cc :subject:content-type; s=fm1; bh=xYUL5Lpkut2ajLp2HHqqFc/SO8e3GAJ 6jWEOsfPOZpo=; b=p1hdjXq+NLGlOJ4czoa6dwjGUO5OGNYmlHtjm3JBlgy+JCy tD6nT+jWB1/UKVhmd9CJoY8w5ryNLpuL9w7PEDlcKnjj4d81Gl3EnB++2ggXYEQr 7YtIaUKtbgm/shMqUS1qVh/aOChv6HGuzYWMasXRlfflS1yUY0h9jEdgHF3w7TRL URgjSiPFf1M6yfHHx+2l37e1pKHiaxdzx8zSYPD/a8YHy7F+v/bYJs9SigmI+2wl HWRavrLO+/6VpplWIwATICiW9A2YpoGAkZY8W5C0WyPs2LxBOlUC/4+G8baGACq5 FzWK1pSYLl0PHShwjCeKZzV9K4AxlIs9ZfdggYQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm1; bh=xYUL5L pkut2ajLp2HHqqFc/SO8e3GAJ6jWEOsfPOZpo=; b=bO79YdT1bsyMWvDdKYh9ML DsInCKRvaXWLHrSeQ6YhvAJ0uoQKqzydkV2GjWUbYzgkfMRRd+J1g/Yr45wRhqR2 kEvLLMNZvCa3BCstI+LK2n/EYbOABXb0VDkyDmQPVCOXiON13vuaQNO0mfpm9/My x1lCSX015WUKMw2Sb1YLSDBMOlUk1UDjlZsCDwZvjUskLjMWEiwEhFgPXHBTNY68 tZwuLHC46W6MtVSo2VYdkssaqdVMuB620bX5b73/+yhei2MA6IzWETaoZAz4xlEK Q6n+ao9AQT4PB9+TiV2m1C7mKVgpf/y0r8OfKKkJDuOZGtSYTnjAVuNBKwz204EA == X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduledruddugdelkecutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpefofgggkfgjfhffhffvufgtsehttdertderredtnecuhfhrohhmpedftehnughr vgifucflvghffhgvrhihfdcuoegrnhgurhgvfiesrghjrdhiugdrrghuqeenucggtffrrg htthgvrhhnpeehhfefkefgkeduveehffehieehudejfeejveejfedugfefuedtuedvhefh veeuffenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpe grnhgurhgvfiesrghjrdhiugdrrghu X-ME-Proxy: Received: by mailuser.nyi.internal (Postfix, from userid 501) id 0481AA0005D; Wed, 20 Jan 2021 01:38:27 -0500 (EST) X-Mailer: MessagingEngine.com Webmail Interface User-Agent: Cyrus-JMAP/3.5.0-alpha0-78-g36b56e88ef-fm-20210120.001-g36b56e88 Mime-Version: 1.0 Message-Id: <31ea8453-bbb1-4e68-8ee4-f7e524e38b88@beta.fastmail.com> In-Reply-To: References: <20210118065059.2478078-1-troy_lee@aspeedtech.com> <20210118065059.2478078-5-troy_lee@aspeedtech.com> <2bf67d3a-cd5f-4f9c-b043-709b18a759d5@www.fastmail.com> Date: Wed, 20 Jan 2021 17:07:56 +1030 From: "Andrew Jeffery" To: "Ryan Chen" , "Troy Lee" , "openbmc@lists.ozlabs.org" , "Joel Stanley" , "Philipp Zabel" , "open list" , "moderated list:ARM/ASPEED MACHINE SUPPORT" , "moderated list:ARM/ASPEED MACHINE SUPPORT" Cc: "Chia-Wei, Wang" , "Troy Lee" , "kbuild test robot" Subject: Re: [PATCH v3 4/4] hwmon: Support Aspeed AST2600 PWM/Fan tachometer Content-Type: text/plain Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 20 Jan 2021, at 15:53, Ryan Chen wrote: > > -----Original Message----- > > From: Andrew Jeffery > > Sent: Wednesday, January 20, 2021 1:16 PM > > To: Troy Lee ; openbmc@lists.ozlabs.org; Joel > > Stanley ; Philipp Zabel ; open list > > ; moderated list:ARM/ASPEED MACHINE > > SUPPORT ; moderated > > list:ARM/ASPEED MACHINE SUPPORT > > Cc: Ryan Chen ; ChiaWei Wang > > ; Troy Lee ; kbuild > > test robot > > Subject: Re: [PATCH v3 4/4] hwmon: Support Aspeed AST2600 PWM/Fan > > tachometer > > > > Hi Troy, > > > > On Mon, 18 Jan 2021, at 17:20, Troy Lee wrote: > > > Add Aspeed AST2600 PWM/Fan tacho driver. AST2600 has 16 PWM channel > > > and > > > 16 FAN tacho channel. > > > > > > Changes since v2: > > > - declare local function as static function > > > > > > Changes since v1: > > > - fixed review comments > > > - fixed double-looped calculation of div_h and div_l > > > - moving configuration to device tree > > > - register hwmon driver with devm_hwmon_device_register_with_info() > > > > > > Signed-off-by: Troy Lee > > > Reported-by: kernel test robot > > > --- > > > drivers/hwmon/Kconfig | 10 + > > > drivers/hwmon/Makefile | 1 + > > > drivers/hwmon/aspeed2600-pwm-tacho.c | 756 > > > +++++++++++++++++++++++++++ > > > 3 files changed, 767 insertions(+) > > > create mode 100644 drivers/hwmon/aspeed2600-pwm-tacho.c > > > > ... > > > > > diff --git a/drivers/hwmon/Makefile b/drivers/hwmon/Makefile index > > > 09a86c5e1d29..1a415d493ffc 100644 > > > --- a/drivers/hwmon/Makefile > > > +++ b/drivers/hwmon/Makefile > > > @@ -52,6 +52,7 @@ obj-$(CONFIG_SENSORS_ARM_SCPI) += > > scpi-hwmon.o > > > obj-$(CONFIG_SENSORS_AS370) += as370-hwmon.o > > > obj-$(CONFIG_SENSORS_ASC7621) += asc7621.o > > > obj-$(CONFIG_SENSORS_ASPEED) += aspeed-pwm-tacho.o > > > +obj-$(CONFIG_SENSORS_ASPEED2600_PWM_TACHO) += > > aspeed2600-pwm-tacho.o > > > > Why does this have to be a separate implementation from the existing ASPEED > > PWM/Tacho driver? Is there really nothing in common? > > > Hello Andrew, > The register set is fully re-arrange. And it is new design at AST2600, > can't be compatible with older PWM. > Ah, okay. I hadn't looked. Thanks Ryan. Andrew