From: Enric Balletbo i Serra <enric.balletbo@collabora.com>
To: Sarthak Kukreti <sarthakkukreti@chromium.org>, bleung@chromium.org
Cc: keescook@chromium.org, anton@enomsg.org,
linux-kernel@vger.kernel.org, ccross@android.com,
tony.luck@intel.com, gwendal@chromium.org
Subject: Re: [PATCH 1/1] platform/chrome: chromeos_pstore: set user space log size
Date: Tue, 14 Apr 2020 15:14:59 +0200 [thread overview]
Message-ID: <31fceb88-0d0d-083a-ce4d-3ebba1822a40@collabora.com> (raw)
In-Reply-To: <20200402001548.177025-1-sarthakkukreti@chromium.org>
Hi Sarthak,
Thank you for your patch.
On 2/4/20 2:15, Sarthak Kukreti wrote:
> On x86 ChromiumOS devices, the pmsg_size is set to 0 (check
> /sys/module/ramoops/parameters/pmsg_size): this prevents use of
> pstore-pmsg, even if CONFIG_PSTORE_PMSG is enabled. Set pmsg_size
> to a value that is consistent with the size used on non-x86 ChromiumOS
> devices.
>
> Signed-off-by: Sarthak Kukreti <sarthakkukreti@chromium.org>
> ---
Applied for 5.8
> drivers/platform/chrome/chromeos_pstore.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/platform/chrome/chromeos_pstore.c b/drivers/platform/chrome/chromeos_pstore.c
> index d13770785fb5..82dea8cb5da1 100644
> --- a/drivers/platform/chrome/chromeos_pstore.c
> +++ b/drivers/platform/chrome/chromeos_pstore.c
> @@ -57,6 +57,7 @@ static struct ramoops_platform_data chromeos_ramoops_data = {
> .record_size = 0x40000,
> .console_size = 0x20000,
> .ftrace_size = 0x20000,
> + .pmsg_size = 0x20000,
> .dump_oops = 1,
> };
>
>
prev parent reply other threads:[~2020-04-14 13:40 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-02 0:15 [PATCH 1/1] platform/chrome: chromeos_pstore: set user space log size Sarthak Kukreti
2020-04-02 7:10 ` Kees Cook
2020-04-14 13:14 ` Enric Balletbo i Serra [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=31fceb88-0d0d-083a-ce4d-3ebba1822a40@collabora.com \
--to=enric.balletbo@collabora.com \
--cc=anton@enomsg.org \
--cc=bleung@chromium.org \
--cc=ccross@android.com \
--cc=gwendal@chromium.org \
--cc=keescook@chromium.org \
--cc=linux-kernel@vger.kernel.org \
--cc=sarthakkukreti@chromium.org \
--cc=tony.luck@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox