From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752303AbeEPVN2 (ORCPT ); Wed, 16 May 2018 17:13:28 -0400 Received: from smtp.codeaurora.org ([198.145.29.96]:55322 "EHLO smtp.codeaurora.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751375AbeEPVN0 (ORCPT ); Wed, 16 May 2018 17:13:26 -0400 MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII; format=flowed Content-Transfer-Encoding: 7bit Date: Wed, 16 May 2018 14:13:25 -0700 From: Subhash Jadavani To: Asutosh Das Cc: cang@codeaurora.org, vivek.gautam@codeaurora.org, rnayak@codeaurora.org, vinholikatti@gmail.com, jejb@linux.vnet.ibm.com, martin.petersen@oracle.com, linux-mmc@vger.kernel.org, linux-scsi@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org, linux-scsi-owner@vger.kernel.org Subject: Re: [PATCH v2 07/10] scsi: ufs-qcom: remove broken hci version quirk In-Reply-To: References: Message-ID: <31fe63a7a6497299dd2902fb15cc6346@codeaurora.org> User-Agent: Roundcube Webmail/1.2.5 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2018-05-03 04:07, Asutosh Das wrote: > From: Subhash Jadavani > > UFSHCD_QUIRK_BROKEN_UFS_HCI_VERSION is only applicable for QCOM UFS > host > controller version 2.x.y and this has been fixed from version 3.x.y > onwards, hence this change removes this quirk for version 3.x.y > onwards. > > Signed-off-by: Subhash Jadavani > Signed-off-by: Asutosh Das > --- > drivers/scsi/ufs/ufs-qcom.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/scsi/ufs/ufs-qcom.c b/drivers/scsi/ufs/ufs-qcom.c > index d9edef8..27be327 100644 > --- a/drivers/scsi/ufs/ufs-qcom.c > +++ b/drivers/scsi/ufs/ufs-qcom.c > @@ -1103,7 +1103,7 @@ static void ufs_qcom_advertise_quirks(struct > ufs_hba *hba) > hba->quirks |= UFSHCD_QUIRK_BROKEN_LCC; > } > > - if (host->hw_ver.major >= 0x2) { > + if (host->hw_ver.major == 0x2) { > hba->quirks |= UFSHCD_QUIRK_BROKEN_UFS_HCI_VERSION; > hba->quirks |= UFSHCD_QUIRK_BROKEN_PWR_MODE_CHANGE; > if (!ufs_qcom_cap_qunipro(host)) Looks good to me. -- The Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, a Linux Foundation Collaborative Project