From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 67B1EC4360C for ; Fri, 4 Oct 2019 20:04:16 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 47A772133F for ; Fri, 4 Oct 2019 20:04:16 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731104AbfJDUEP (ORCPT ); Fri, 4 Oct 2019 16:04:15 -0400 Received: from gloria.sntech.de ([185.11.138.130]:37430 "EHLO gloria.sntech.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730989AbfJDUEP (ORCPT ); Fri, 4 Oct 2019 16:04:15 -0400 Received: from 94.112.246.102.static.b2b.upcbusiness.cz ([94.112.246.102] helo=phil.localnet) by gloria.sntech.de with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1iGToC-0006Up-Gs; Fri, 04 Oct 2019 22:04:12 +0200 From: Heiko Stuebner To: Soeren Moch Cc: linux-rockchip@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 1/3] arm64: dts: rockchip: fix RockPro64 vdd-log regulator settings Date: Fri, 04 Oct 2019 22:04:11 +0200 Message-ID: <3200327.mLoWUYiBOS@phil> In-Reply-To: <20191003215036.15023-1-smoch@web.de> References: <20191003215036.15023-1-smoch@web.de> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Am Donnerstag, 3. Oktober 2019, 23:50:34 CEST schrieb Soeren Moch: > The RockPro64 schematic [1] page 18 states a min voltage of 0.8V and a > max voltage of 1.4V for the VDD_LOG pwm regulator. However, there is an > additional note that the pwm parameter needs to be modified. > From the schematics a voltage range of 0.8V to 1.7V can be calculated. > Additional voltage measurements on the board show that this fix indeed > leads to the correct voltage, while without this fix the voltage was set > too high. > > [1] http://files.pine64.org/doc/rockpro64/rockpro64_v21-SCH.pdf > > Fixes: e4f3fb490967 ("arm64: dts: rockchip: add initial dts support for Rockpro64") > Signed-off-by: Soeren Moch applied as fix for 5.4 Thanks for going that extra mile with all the calculations and measurements Heiko