From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757268AbbBELCV (ORCPT ); Thu, 5 Feb 2015 06:02:21 -0500 Received: from mailout4.samsung.com ([203.254.224.34]:41638 "EHLO mailout4.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751212AbbBELCT (ORCPT ); Thu, 5 Feb 2015 06:02:19 -0500 X-AuditID: cbfee61b-f79d76d0000024d6-7d-54d34db88cba From: Bartlomiej Zolnierkiewicz To: Nicholas Krause Cc: tj@kernel.org, linux-ide@vger.kernel.org, linux-kernel@vger.kernel.org, One Thousand Gnomes Subject: Re: [PATCH] ata:Remove no longer valid FIXME comment in pata_ninja32.c for the function,ninja32_init_one Date: Thu, 05 Feb 2015 12:02:06 +0100 Message-id: <3201438.osoPqSWP4R@amdc1032> User-Agent: KMail/4.8.4 (Linux/3.2.0-70-generic-pae; KDE/4.8.5; i686; ; ) In-reply-to: <1423093661-32188-1-git-send-email-xerofoify@gmail.com> References: <1423093661-32188-1-git-send-email-xerofoify@gmail.com> MIME-version: 1.0 Content-transfer-encoding: 7Bit Content-type: text/plain; charset=ISO-8859-1 X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFjrNLMWRmVeSWpSXmKPExsVy+t9jQd0dvpdDDOYfMLOYNOUvm8WxHY+Y LC7vmsNm8Wv5UUaLX1NkHVg9ds66y+6xaVUnm0fryU2sHp83yQWwRHHZpKTmZJalFunbJXBl rHq5gbVgIn/Fv5adbA2M23m6GDk5JARMJFoPTGKFsMUkLtxbz9bFyMUhJDCdUWJFRxc7hNPC JHH71yywKjYBK4mJ7asYQWwRAU2J58/2g9nMAnUSf86uA2rg4BAWKJZYfycaJMwioCrxZMtJ JhCbF6i870gHM4gtKuApsXP6AbBWTgEXifun97OD2EICzhIrVm9nh6gXlPgx+R4LxHh5iX37 p7JC2DoS+1unsU1gFJiFpGwWkrJZSMoWMDKvYhRNLUguKE5KzzXSK07MLS7NS9dLzs/dxAgO 4mfSOxhXNVgcYhTgYFTi4bXYdylEiDWxrLgy9xCjBAezkgjvFq/LIUK8KYmVValF+fFFpTmp xYcYpTlYlMR5lezbQoQE0hNLUrNTUwtSi2CyTBycUg2MfgkMPZ2tc68KCrw8dzayoGlF6dUZ Z/L+M0eK3Nxc8WTd9yijNa+f1YtcdV/YHCcuk3Rq45QUpym/JA0PB0TLTdWuPphhxn5X1Tt7 dUA6C99Ulor5Ytf2L18uw3lZ/2y03usVlWG/vyicD5g/aa9nj6zrQz85W96Dt8/sXmb9MsQm d5lc14JkJZbijERDLeai4kQAY1++bV4CAAA= Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi, On Wednesday, February 04, 2015 06:47:41 PM Nicholas Krause wrote: > Removes the no longer valid fix me comment in the function, ninja32_init_one for > questioning if we are required to remove the activated device at the end of this > function by calling the function, ata_host_activate to activate the device passed > by the caller of the function ninja_init_one. This comment is no longer needed as > we need to deallocate the memory used to store this device's information when the > device is no longer in use by the system in order to avoid leaking memory. Due to > this the driver in the file,ninja32_init_one has the function,ata_pci_remove_one > to release the memory allocated in it's init function and therefore this comment > can now be removed due to use correctly freeing the memory allocated from the > driver's init function,ninja32_init_one. > > Signed-off-by: Nicholas Krause > --- > drivers/ata/pata_ninja32.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/drivers/ata/pata_ninja32.c b/drivers/ata/pata_ninja32.c > index efb272d..47b30d3 100644 > --- a/drivers/ata/pata_ninja32.c > +++ b/drivers/ata/pata_ninja32.c > @@ -147,7 +147,6 @@ static int ninja32_init_one(struct pci_dev *dev, const struct pci_device_id *id) > ap->pflags = ATA_PFLAG_PIO32 | ATA_PFLAG_PIO32CHANGE; > > ninja32_program(base); > - /* FIXME: Should we disable them at remove ? */ After looking at the driver history I think that the comment is about ninja32_program() enabling interrupt lines (which don't get disabled when the host controller is detached from the driver) not about the cleanup done during ata_pci_remove_one(). Alan, is this correct? > return ata_host_activate(host, dev->irq, ata_bmdma_interrupt, > IRQF_SHARED, &ninja32_sht); > } Best regards, -- Bartlomiej Zolnierkiewicz Samsung R&D Institute Poland Samsung Electronics