From: Keith Owens <kaos@ocs.com.au>
To: Kai Germaschewski <kai@tp1.ruhr-uni-bochum.de>
Cc: Thomas Hood <jdthood@home.dhs.org>,
linux-kernel@vger.kernel.org, jdthood@mail.com
Subject: Re: [PATCH] parport_pc to use pnpbios_register_driver()
Date: Mon, 12 Nov 2001 12:56:29 +1100 [thread overview]
Message-ID: <32053.1005530189@kao2.melbourne.sgi.com> (raw)
In-Reply-To: Your message of "Sun, 11 Nov 2001 21:42:34 BST." <Pine.LNX.4.33.0111112134430.1518-100000@vaio>
On Sun, 11 Nov 2001 21:42:34 +0100 (CET),
Kai Germaschewski <kai@tp1.ruhr-uni-bochum.de> wrote:
>linux/isapnp.h has the following code:
>
>---
>#if defined(CONFIG_ISAPNP) || (defined(CONFIG_ISAPNP_MODULE) && defined(MODULE))
>
>#define __ISAPNP__
>---
>
>I believe the pnpbios driver should do things something similar. Users of
>the interface should then only check for #ifdef __PNPBIOS__.
>
>The reasoning behind this is the following: When you have a driver
>built-in, but pnpbios modular, the driver cannot use pnpbios
>functionality. The above definition reflects exactly this.
Does this combination make sense? If you are building a pnpbios driver
into the kernel then the configuration should force pnpbios support to
be built in as well. We don't allow this combination for things like
scsi or ide, they require the common support to be built in if any
drivers are built in. IMHO this problem should be fixed in .config,
not in driver source.
next prev parent reply other threads:[~2001-11-12 1:56 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2001-11-10 5:36 [PATCH] parport_pc to use pnpbios_register_driver() Thomas Hood
[not found] ` <200111102104.fAAL4pk19362@spf4.us4.outblaze.com>
2001-11-11 4:52 ` [PATCH] parport_pc to use pnpbios_register_driver() #2 Thomas Hood
2001-11-11 20:42 ` [PATCH] parport_pc to use pnpbios_register_driver() Kai Germaschewski
2001-11-12 1:56 ` Keith Owens [this message]
2001-11-12 8:30 ` Kai Germaschewski
2001-11-13 21:41 ` Thomas Hood
2001-11-14 9:25 ` Kai Germaschewski
2001-11-14 10:17 ` David Woodhouse
2001-11-14 15:46 ` Thomas Hood
2001-11-15 13:30 ` [PATCH] parport_pc to use pnpbios_register_driver() #4 Thomas Hood
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=32053.1005530189@kao2.melbourne.sgi.com \
--to=kaos@ocs.com.au \
--cc=jdthood@home.dhs.org \
--cc=jdthood@mail.com \
--cc=kai@tp1.ruhr-uni-bochum.de \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox