From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754408AbbK0N7d (ORCPT ); Fri, 27 Nov 2015 08:59:33 -0500 Received: from mout.kundenserver.de ([212.227.126.133]:62126 "EHLO mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751484AbbK0N7a (ORCPT ); Fri, 27 Nov 2015 08:59:30 -0500 From: Arnd Bergmann To: Andrew Morton Cc: Vlastimil Babka , Joonsoo Kim , Minchan Kim , Sasha Levin , "Kirill A. Shutemov" , Mel Gorman , Michal Hocko , linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org Subject: [PATCH] mm, page_owner: only track migration if enabled Date: Fri, 27 Nov 2015 14:58:37 +0100 Message-ID: <3209032.Njpu4mxStH@wuerfel> User-Agent: KMail/4.11.5 (Linux/3.16.0-10-generic; KDE/4.11.5; x86_64; ; ) MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" X-Provags-ID: V03:K0:7bpCLLb9CxzAqRamdxsov3lSg8m+SHFpjfaGrwyUDPYz9IcoHkw q3Eqxhww4vOyTu3tVbV4h35sBbeyLO4EsX+cthVcDE5clXuOQbF+PzrqGOt1XxDbCQUuSOL zhgkwVJanZuhYDP7Zdfr6EVUYVX+rgXg3zfW48AcJVzeezHA04T0Dy6QUqxVsAAX5QJWgc0 cx76gbSRPeKUTgZwRqcXA== X-UI-Out-Filterresults: notjunk:1;V01:K0:6YvMnCEP5T0=:Cos3PWXiuFoXCxeJEHvS7Y zYN/d78wauK7bwlrYMQyJBLsaeD656l/3QKZCi4BVpQNTNJ1VyEiT1cR1qIdWrMI0C2SBRv/7 uBfC5aWaorN8FoFIxJ/2q4AbdL4g91kZCoMFe8zEtp67ps7OlHgmcoBNeEbl80WwaqVK0t9qO bHCOKoXsbaBGPshhYO2a/8SwHcr5Ja2kMTacClSwAjyeBMUzTvXfZBiJ/sUjYP0p4n60m5IRX etCH8NkUuiwC4YKmocTZQa5hjVIEjaLxEI1ZED25MXp+uHcavPrhOuwzOgiLHjwoMo33BAay2 e1Utzv6LuG/aJSSWTQlkSEdnwIC0zrvNrDM0OoMUf9Nt7E1Q2ZGYuUJgzcdLiOUvUQqfIsWFK OuyjcMaDcDwCbrnKZ1DHtgdIVgPBL+7eh3YMg69Fg48DTjPhXKjIkFUV0XobSPhYrIJUq9g0B NgXXROlMM+KMrODGke2JHkEy3SWvNS4AcbJBysIZtMpLB/ctjQ4i6kLjng3pqnGOz/qcuaM2H PkJnLMRMg0qvYPGlj532ZNj7i67EaUFDqFbq0wZi4NnZRT/IQxbkn125jRq9MlfxJzgSTC0TR wFqCq0gR7mcWyOgHWn2P5i35i0sETLjrsNz3LQ0u62ZlGCAgiR7tdG7GtxZ4UepTvrE2p5Xtc mIxm9hpcUwuV2J9FhittclxjLMS2jUeFOxaByJYX4I4clMC5wl1u4H1Uy2zXAHukSAWtTP7h5 vHeqHQ9kjaNHH21m Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org The newly added code to print page ownership in dump_page fails to link when CONFIG_MIGRATION is disabled: mm/built-in.o: In function `print_page_owner': frame_vector.c:(.text+0x72358): undefined reference to `migrate_reason_names' This changes the two users of migrate_reason_names to first check CONFIG_MIGRATION, which avoids the error. Signed-off-by: Arnd Bergmann Fixes: cf7ec391dae4 ("mm, page_owner: dump page owner info from dump_page()") --- Found on yesterday's linux-next with ARM randconfig builds. The patch that introduced this is currently in Andrews tree. If you don't already have a fix, please apply this one on top, or fold it into the original commit. diff --git a/mm/page_owner.c b/mm/page_owner.c index a81cfa0c13c3..4033542c3f5a 100644 --- a/mm/page_owner.c +++ b/mm/page_owner.c @@ -170,7 +170,8 @@ print_page_owner(char __user *buf, size_t count, unsigned long pfn, if (ret >= count) goto err; - if (page_ext->last_migrate_reason != -1) { + if (IS_ENABLED(CONFIG_MIGRATION) && + page_ext->last_migrate_reason != -1) { ret += snprintf(kbuf + ret, count - ret, "Page has been migrated, last migrate reason: %s\n", migrate_reason_names[page_ext->last_migrate_reason]); @@ -213,7 +214,8 @@ void __dump_page_owner(struct page *page) dump_gfpflag_names(gfp_mask); print_stack_trace(&trace, 0); - if (page_ext->last_migrate_reason != -1) + if (IS_ENABLED(CONFIG_MIGRATION) && + page_ext->last_migrate_reason != -1) pr_alert("page has been migrated, last migrate reason: %s\n", migrate_reason_names[page_ext->last_migrate_reason]); }